Patch Detail
Show a patch.
GET /api/1.1/patches/18272/?format=api
{ "id": 18272, "url": "https://patchwork.libcamera.org/api/1.1/patches/18272/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18272/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230209124311.2504434-1-kieran.bingham@ideasonboard.com>", "date": "2023-02-09T12:43:11", "name": "[libcamera-devel] README: Add unit tests instructions", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "ad7c442ff6176ccf079471af5de6c60c7ec8a54c", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18272/mbox/", "series": [ { "id": 3746, "url": "https://patchwork.libcamera.org/api/1.1/series/3746/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3746", "date": "2023-02-09T12:43:11", "name": "[libcamera-devel] README: Add unit tests instructions", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3746/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18272/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18272/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 78491BDB1C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 9 Feb 2023 12:43:22 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B7108625E3;\n\tThu, 9 Feb 2023 13:43:21 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D93A0603BD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 9 Feb 2023 13:43:19 +0100 (CET)", "from Monstersaurus.local\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 51CC9D4A;\n\tThu, 9 Feb 2023 13:43:19 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1675946601;\n\tbh=crv5ZDSaklsFZsqyq/a4WvFW5nHuUmQUIYcHC4Vc/8k=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:Cc:From;\n\tb=j0Olhe2J6RsoPhHPdDRSrlGvdVdQACmS5VQ36CVjIeIBwaDdgVVhjobPIQlYfD+tS\n\t59/pCHVCXpq/ajY2nitQBXLCA/B1w/1c0WiRPn3ke7UKr4vP9MIwg7DvaPM29D6krd\n\tmgsyMkhQkAsImRKnsHfc65vW029Tl3RfENUywLz8d9roFsjI1r66xYw037VOmjEfPK\n\tFEy/7tdE4e+g0qhIQF2Kw5uK8i+B6nu0SxnJDs8KYNYf8eHcfzY3a0u3p7bz/aI/wr\n\t0M/VdlzFAo/4zlYyEyo4/KuKVsVQPAHEPQ8SsqBtoU5PTfD/K1DmIyEzB4JV1QfMXz\n\tyo/LGjM1Vwytg==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1675946599;\n\tbh=crv5ZDSaklsFZsqyq/a4WvFW5nHuUmQUIYcHC4Vc/8k=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=oYrv1wXuK4F7FY6GgwdAdBK6KkbRaLuww9fqN0viTdXROQVj/im/zCjuRUOBuLZs6\n\twf96/grptsU9g8aUP7i3ZlvoriW/cs1Zsy1FddjgsnwrhrC+HIJSrSLx0AAiHIzrV9\n\t/58zEkKAnOR3Msgld2+LUdhZpbvqBgWAxQqNxJMI=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"oYrv1wXu\"; dkim-atps=neutral", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Thu, 9 Feb 2023 12:43:11 +0000", "Message-Id": "<20230209124311.2504434-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] README: Add unit tests instructions", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Cc": "William Salmon <pointswaves@gmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The unit tests require kernel modules to be loaded to support the\nvirtual test cameras. Add notes to the readme to highlight that it can\nbe done, and what kernel configurations are required.\n\nSuggested-by: William Salmon <pointswaves@gmail.com>\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n README.rst | 43 +++++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 43 insertions(+)", "diff": "diff --git a/README.rst b/README.rst\nindex 82dde16eedb8..58aab39d8883 100644\n--- a/README.rst\n+++ b/README.rst\n@@ -119,6 +119,49 @@ setting the ``LIBCAMERA_LOG_LEVELS`` environment variable:\n \n :~$ LIBCAMERA_LOG_LEVELS=*:DEBUG cam -l\n \n+Running the unit tests\n+~~~~~~~~~~~~~~~~~~~~~~\n+\n+When submitting patches, it is recommeded to run the unit tests. To use the\n+unit test framework, virtual test drivers are required to be loaded.\n+\n+The unit tests rely on kernel drivers which produce virtual devices. These can\n+be either built into the kernel, or provided as modules (=y or =m):\n+\n+.. code::\n+\n+ CONFIG_MEDIA_TEST_SUPPORT=y\n+ CONFIG_V4L_TEST_DRIVERS=y\n+\n+ CONFIG_VIDEO_VIM2M=m\n+ CONFIG_VIDEO_VIMC=m\n+ CONFIG_VIDEO_VIVID=m\n+\n+If the kernel provides the test drivers as modules - they need to be loaded\n+before running the tests:\n+\n+.. code::\n+\n+ sudo modprobe vimc\n+ sudo modprobe vivid\n+ sudo modprobe vim2m\n+\n+Make sure your build configuration has tests enabled:\n+\n+.. code::\n+\n+ meson build -Dtest=true\n+\n+Enabling 'test=true' will implcitly add test pipeline handlers including the\n+VIMC pipeline handler to the build configuration.\n+\n+Then the tests can be run with\n+\n+.. code::\n+\n+ ninja -C build test\n+\n+\n Using GStreamer plugin\n ~~~~~~~~~~~~~~~~~~~~~~\n \n", "prefixes": [ "libcamera-devel" ] }