Patch Detail
Show a patch.
GET /api/1.1/patches/18262/?format=api
{ "id": 18262, "url": "https://patchwork.libcamera.org/api/1.1/patches/18262/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18262/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230208033319.1361109-2-chenghaoyang@google.com>", "date": "2023-02-08T03:33:15", "name": "[libcamera-devel,v10,1/5] libcamera: framebuffer: Allow inheritance of FrameBuffer", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "1824248175cc997dd16eac279826e130593ec312", "submitter": { "id": 117, "url": "https://patchwork.libcamera.org/api/1.1/people/117/?format=api", "name": "Cheng-Hao Yang", "email": "chenghaoyang@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18262/mbox/", "series": [ { "id": 3743, "url": "https://patchwork.libcamera.org/api/1.1/series/3743/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3743", "date": "2023-02-08T03:33:14", "name": "Add CrOS JEA implementation", "version": 10, "mbox": "https://patchwork.libcamera.org/series/3743/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18262/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18262/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AD677BEFBE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 8 Feb 2023 03:33:31 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 60869625E3;\n\tWed, 8 Feb 2023 04:33:31 +0100 (CET)", "from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com\n\t[IPv6:2607:f8b0:4864:20::1029])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 834DE603B8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 8 Feb 2023 04:33:27 +0100 (CET)", "by mail-pj1-x1029.google.com with SMTP id\n\tc10-20020a17090a1d0a00b0022e63a94799so956473pjd.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 07 Feb 2023 19:33:27 -0800 (PST)", "from chenghaoyang-low.c.googlers.com.com\n\t(46.165.189.35.bc.googleusercontent.com. [35.189.165.46])\n\tby smtp.gmail.com with ESMTPSA id\n\te9-20020a170902784900b00194c82c2a7bsm9621963pln.224.2023.02.07.19.33.24\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 07 Feb 2023 19:33:25 -0800 (PST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1675827211;\n\tbh=nxQH6Fnf5tBxut2vw18X01WtPIl2E0cii2wz2Jf/Um4=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=prXhUb5kDJXz/rGncXmEON16ZyL2V1gRsBFThLIgd3KKz8FGzwG/FpSz+/0jj1Hjh\n\t4ywTuYCMckt5gkBszzw1sDXNYAUnB+7TyQaqXH90lHDbCVPtDOHBT4267MbA4KEch9\n\tm1KxNdsWOGi7+GCfxDJ4fREtIbbjskw2OudNPm4T8aLPTebT6SZH71b13XNswV/lMY\n\tv7JJ8BBY1ozOIaW+3gTo/25zGXWlnLaZWOwyQOxgMb3gam5Qnd1dH9x4FGH1pa3l0i\n\trA4UJtLYOi57xl2CffM4ygnuCDc45Nfm7UqWqHFvOwQivRsqkWZkvwjYKupJwTay2D\n\t+EwDoiAREieVQ==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=skPLhBnh3iLkI1XSxbHLlMVG/RIJVEbJWy1VZEFkv5k=;\n\tb=eR9sNZLc3Pci1i+5nAJUKp6IMtLL6mmh7fs96nxWUbe+z0Zw4OVx7rjYWEuuPXJ744\n\twycRT9Lih+SMumFGnHMo0vTWUA73fcaymZFhh1A/7ZxGRpJn9dWq2kWAfErAv0dFlJVN\n\tFquZMbSov5ONLUsPzB9B6U6O3W/VrMdIFTrKI=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=chromium.org\n\theader.i=@chromium.org header.b=\"eR9sNZLc\"; \n\tdkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=skPLhBnh3iLkI1XSxbHLlMVG/RIJVEbJWy1VZEFkv5k=;\n\tb=o/WjIi08JkRVTWsMTlBtG0ZyK4A9x/abVzD6ZRk8Ig4cdUcBelWWFSJlJ7nfFZbUwH\n\tZZTNvs7O1wX7SouP5INFDD+uFPO1mdu7vKdiPEZXC4tzE5eBQaznQipL+j1c+KEIJ0gW\n\tCwE/OO20jN5Ukn0yk9cuIIWEwBJ99i3s+cM8L96hNmUe+5JsiNBJzrwfMOGao4KK+ap4\n\tByFC9Fr6lEZ4D0QFh4iPuFSnkEv4hvWgXIjKlDHTIix/ONGeB30zqe4sg+dB38YlWcKC\n\tr1UgWTBVbFh3kOQgajaQvp32PLJCUtWd/m5To7T6Dc1C0yemGg1oMjDWZIiivoGqtwte\n\tKbPA==", "X-Gm-Message-State": "AO0yUKUJtpBbdU8GlIcbXPY/tLSaq6X+KIxyUmZeocqcgdGZJUH57yBx\n\t1XBal3RAF83A09ubZNBYBkvmioo3L2ufHGFE", "X-Google-Smtp-Source": "AK7set9pHY4IlquhrjWGH1dNJRVIjmJLgFnfFKW2xoUSMMqD8obO3Hmm+9d1Mm+1O8d0I4JEEuLggQ==", "X-Received": "by 2002:a17:902:ce86:b0:199:1375:279c with SMTP id\n\tf6-20020a170902ce8600b001991375279cmr5793585plg.69.1675827205703; \n\tTue, 07 Feb 2023 19:33:25 -0800 (PST)", "X-Google-Original-From": "Harvey Yang <chenghaoyang@google.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 8 Feb 2023 03:33:15 +0000", "Message-Id": "<20230208033319.1361109-2-chenghaoyang@google.com>", "X-Mailer": "git-send-email 2.39.1.519.gcb327c4b5f-goog", "In-Reply-To": "<20230208033319.1361109-1-chenghaoyang@google.com>", "References": "<20230208033319.1361109-1-chenghaoyang@google.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v10 1/5] libcamera: framebuffer: Allow\n\tinheritance of FrameBuffer", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Harvey Yang via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Harvey Yang <chenghaoyang@chromium.org>", "Cc": "Harvey Yang <chenghaoyang@chromium.org>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Harvey Yang <chenghaoyang@chromium.org>\n\nTo add buffer_handle_t access in android, this patch allows inheritance\nof FrameBuffer to add a derived class in android.\n\nSigned-off-by: Harvey Yang <chenghaoyang@chromium.org>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Han-Lin Chen <hanlinchen@chromium.org>\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/framebuffer.h | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/framebuffer.h b/include/libcamera/framebuffer.h\nindex 69553999..61244829 100644\n--- a/include/libcamera/framebuffer.h\n+++ b/include/libcamera/framebuffer.h\n@@ -46,7 +46,7 @@ private:\n \tstd::vector<Plane> planes_;\n };\n \n-class FrameBuffer final : public Extensible\n+class FrameBuffer : public Extensible\n {\n \tLIBCAMERA_DECLARE_PRIVATE()\n \n@@ -60,6 +60,7 @@ public:\n \n \tFrameBuffer(const std::vector<Plane> &planes, unsigned int cookie = 0);\n \tFrameBuffer(std::unique_ptr<Private> d);\n+\tvirtual ~FrameBuffer() {}\n \n \tconst std::vector<Plane> &planes() const;\n \tRequest *request() const;\n", "prefixes": [ "libcamera-devel", "v10", "1/5" ] }