Patch Detail
Show a patch.
GET /api/1.1/patches/18232/?format=api
{ "id": 18232, "url": "https://patchwork.libcamera.org/api/1.1/patches/18232/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18232/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230202111252.3366729-4-matthias.fend@emfend.at>", "date": "2023-02-02T11:12:48", "name": "[libcamera-devel,RFC,3/7] pipeline: rkisp1: transparently pass lens controls from the IPA to the lens", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "28480b0c103fc0370a8f3ff23449dee06ee7f3fc", "submitter": { "id": 134, "url": "https://patchwork.libcamera.org/api/1.1/people/134/?format=api", "name": "Matthias Fend", "email": "matthias.fend@emfend.at" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18232/mbox/", "series": [ { "id": 3735, "url": "https://patchwork.libcamera.org/api/1.1/series/3735/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3735", "date": "2023-02-02T11:12:45", "name": "add support for more complex optics", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3735/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18232/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18232/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B44ECC329C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 2 Feb 2023 11:13:08 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D1F86603BF;\n\tThu, 2 Feb 2023 12:13:06 +0100 (CET)", "from lx20.hoststar.hosting (lx20.hoststar.hosting [168.119.41.54])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D043B625DD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 2 Feb 2023 12:13:03 +0100 (CET)", "from 194-208-208-245.tele.net ([194.208.208.245]:51050\n\thelo=localhost.localdomain)\n\tby lx20.hoststar.hosting with esmtpsa (TLS1.3) tls\n\tTLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93)\n\t(envelope-from <matthias.fend@emfend.at>)\n\tid 1pNXWZ-008Uhs-2g; Thu, 02 Feb 2023 12:13:03 +0100" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1675336386;\n\tbh=WVDPlWY1vqRIsqop3ZaZPhFJ7lDNiETEj+WaEiZVmao=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=BI30YlIr26eHOdStd7weY0qrivp+A5OzywfK08qYae+OZLIoW9R1ocN3qr7WBnEoA\n\t30VoEuBYB1J2LM7d2kKbabBJF3C2imMwNmLBrvVDLXfterwqgoGD5trH0lRCimJT4R\n\tUIOmLDvaoibwo8GMJsSdoSzrnu+wFqEvXW3JCouGLxHvpk2fC0G6yQAWRB7PnOR9qn\n\tLzYEOonDioDnnxdDix+mXPyipILVsK2K8rP+SPJKTrP396m3wvAStMmM+/2u0fy64d\n\t6vBNS6hnET0AxHaoe0P4WrX1KomNG7j3LsnlsqUkL9i1bi+O8iTnnSsLQIGh2CHCIP\n\td8TSJivOdlDow==", "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=emfend.at;\n\ts=mail;\n\th=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:\n\tMessage-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=2oKGyofZPFVFSyRgoLKCL6PmzvWBKUB94KWl8cArkF8=;\n\tb=hQZpeIPwSVBswh6kPyP5cPwwnI\n\txslHJunuuHPrRlu2hGfjlHvQ45HAFF7CKZhsE5BdWUlB+jvqieeMUBy36mGGT1Yq9rjRvOPLcXdht\n\tw2R1Aktvz8f3V30JX2QYrjo+aMxukI9Xh1iM/UMC5HI+yWrrwKbW4/+ASJmRmYUdesWg=;" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=emfend.at header.i=@emfend.at\n\theader.b=\"hQZpeIPw\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 2 Feb 2023 12:12:48 +0100", "Message-Id": "<20230202111252.3366729-4-matthias.fend@emfend.at>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230202111252.3366729-1-matthias.fend@emfend.at>", "References": "<20230202111252.3366729-1-matthias.fend@emfend.at>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Spam-Score": "-1.0", "X-Spam-Bar": "-", "X-Spam-Report": "Spam detection software,\n\trunning on the system \"lx20.hoststar.hosting\", \n\thas NOT identified this incoming email as spam. The original\n\tmessage has been attached to this so you can view it or label\n\tsimilar future email. If you have any questions, see\n\tthe administrator of that system for details.\n\tContent preview: This method allows v4l2 controls to be set directly\n\ton the underlying v4l2 subdevice. Signed-off-by: Matthias Fend\n\t<matthias.fend@emfend.at>\n\t--- include/libcamera/internal/camera_lens.h | 1 +\n\tsrc/libcamera/camera_lens.cpp\n\t| 10 ++++++++++ 2 files changed, 11 insertions(+) \n\tContent analysis details: (-1.0 points, 5.0 required)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP\n\t0.0 TVD_RCVD_IP Message was received from an IP address\n\t0.0 KAM_DMARC_STATUS Test Rule for DKIM or SPF Failure with Strict\n\tAlignment", "Subject": "[libcamera-devel] [RFC PATCH 3/7] pipeline: rkisp1: transparently\n\tpass lens controls from the IPA to the lens", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Matthias Fend via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Matthias Fend <matthias.fend@emfend.at>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Instead of parsing the values in the v4l2 controls from the IPA and passing\nthem to CameraLens (where they are then converted back to v4l2 controls),\nthe IPA v4l2 controls are reused directly.\n\nSigned-off-by: Matthias Fend <matthias.fend@emfend.at>\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 10 ++--------\n 1 file changed, 2 insertions(+), 8 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex d4fbcf4b..e4f328cb 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -403,14 +403,8 @@ void RkISP1CameraData::setSensorControls([[maybe_unused]] unsigned int frame,\n \tdelayedCtrls_->push(sensorControls);\n \n \tCameraLens *lens = sensor_->focusLens();\n-\tif (!lens)\n-\t\treturn;\n-\n-\tif (lensControls.contains(V4L2_CID_FOCUS_ABSOLUTE)) {\n-\t\tconst ControlValue &focusValue = lensControls.get(V4L2_CID_FOCUS_ABSOLUTE);\n-\n-\t\tlens->setFocusPosition(focusValue.get<int32_t>());\n-\t}\n+\tif (lens)\n+\t\tlens->setSubdevControls(lensControls);\n }\n \n void RkISP1CameraData::metadataReady(unsigned int frame, const ControlList &metadata)\n", "prefixes": [ "libcamera-devel", "RFC", "3/7" ] }