Patch Detail
Show a patch.
GET /api/1.1/patches/18231/?format=api
{ "id": 18231, "url": "https://patchwork.libcamera.org/api/1.1/patches/18231/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18231/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230202111252.3366729-3-matthias.fend@emfend.at>", "date": "2023-02-02T11:12:47", "name": "[libcamera-devel,RFC,2/7] libcamera: camera_lens: add method to set controls on subdev", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "9b31fe37531e75208cb5181748729920f67df29f", "submitter": { "id": 134, "url": "https://patchwork.libcamera.org/api/1.1/people/134/?format=api", "name": "Matthias Fend", "email": "matthias.fend@emfend.at" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18231/mbox/", "series": [ { "id": 3735, "url": "https://patchwork.libcamera.org/api/1.1/series/3735/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3735", "date": "2023-02-02T11:12:45", "name": "add support for more complex optics", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3735/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18231/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18231/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 34557C323E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 2 Feb 2023 11:13:08 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 73106625DD;\n\tThu, 2 Feb 2023 12:13:06 +0100 (CET)", "from lx20.hoststar.hosting (lx20.hoststar.hosting [168.119.41.54])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 67AA3625DD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 2 Feb 2023 12:13:03 +0100 (CET)", "from 194-208-208-245.tele.net ([194.208.208.245]:51050\n\thelo=localhost.localdomain)\n\tby lx20.hoststar.hosting with esmtpsa (TLS1.3) tls\n\tTLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93)\n\t(envelope-from <matthias.fend@emfend.at>)\n\tid 1pNXWY-008Uhs-L6; Thu, 02 Feb 2023 12:13:02 +0100" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1675336386;\n\tbh=x9zKuY85f+MSA/WV8hlaY6W4lcG/2BIOCArLQIxJBqA=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=rmYrIFwAKrTUNwbGcH/n1B5UM+zYUmacXHASKZ4AapP6bAerjMudcDQVA4hZxGkiJ\n\tZvxcRwmhdELT5KVzaGV8khHOnQ14Du+p8YAL8XuSv1Du6cIAMClm0qhMnZcQHiMD05\n\ttunW7vBJTjBiQCKU2mFPjFktsl81nWsg7GJXnI3f9U0GLSsIumShqvwKfROTwd52iT\n\tCW0pov4SHwdI9LvtAnOPwHhTnDIkX0rVtMJFSnbUyM2OxSz5TB3pP9T3LYfDdeNrnS\n\tS5zEF7t1EJntul74PRm978p780UymiMjGsXBb/u0OKmSTH2Szg174RDT5KAdrNCNQo\n\tR1Ly+9fhtH3Nw==", "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=emfend.at;\n\ts=mail;\n\th=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:\n\tMessage-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=SdbSshu4kv/MXr1ASzNqa+xRbnLNFNWqqO+mPH27ygA=;\n\tb=YpLa0fK28f4aAiBFJ+NoVSQq2b\n\tsC9RmCd+itBNxgb17EwWhx/OagKxU3sNFxESU3yCR+sd6pGrwHE1BHEZJaNYum2Yic64F1cknlcNa\n\t+qAxpxE+ODhOtubI7VA3E8KbollOq2YU8V5Vt8OmJe4fQGFbQs2k1TdL+9+cdKH49vVo=;" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=emfend.at header.i=@emfend.at\n\theader.b=\"YpLa0fK2\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 2 Feb 2023 12:12:47 +0100", "Message-Id": "<20230202111252.3366729-3-matthias.fend@emfend.at>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230202111252.3366729-1-matthias.fend@emfend.at>", "References": "<20230202111252.3366729-1-matthias.fend@emfend.at>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Spam-Score": "-1.0", "X-Spam-Bar": "-", "X-Spam-Report": "Spam detection software,\n\trunning on the system \"lx20.hoststar.hosting\", \n\thas NOT identified this incoming email as spam. The original\n\tmessage has been attached to this so you can view it or label\n\tsimilar future email. If you have any questions, see\n\tthe administrator of that system for details.\n\tContent preview: Adding basic support for lenses,\n\tas has been done similarly\n\tin other pipeline handlers. Parts of it will be changed later in the\n\tseries, \n\tbut the intended changes are more recognizable. Signed-off-by:\n\tMatthias Fend\n\t<matthias.fend@emfend.at> --- include/libcamera/ipa/rkisp1.mojom | 4\n\t+++-\n\tsrc/libcamera/pipeline/rkisp1/rkisp1.cpp | 21 +++++++++++++++++++-- 2\n\tfiles changed, 22 insertion [...] \n\tContent analysis details: (-1.0 points, 5.0 required)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP\n\t0.0 TVD_RCVD_IP Message was received from an IP address\n\t0.0 KAM_DMARC_STATUS Test Rule for DKIM or SPF Failure with Strict\n\tAlignment", "Subject": "[libcamera-devel] [RFC PATCH 2/7] libcamera: camera_lens: add\n\tmethod to set controls on subdev", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Matthias Fend via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Matthias Fend <matthias.fend@emfend.at>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This method allows v4l2 controls to be set directly on the underlying\nv4l2 subdevice.\n\nSigned-off-by: Matthias Fend <matthias.fend@emfend.at>\n---\n include/libcamera/internal/camera_lens.h | 1 +\n src/libcamera/camera_lens.cpp | 10 ++++++++++\n 2 files changed, 11 insertions(+)", "diff": "diff --git a/include/libcamera/internal/camera_lens.h b/include/libcamera/internal/camera_lens.h\nindex 277417da..66c32a46 100644\n--- a/include/libcamera/internal/camera_lens.h\n+++ b/include/libcamera/internal/camera_lens.h\n@@ -27,6 +27,7 @@ public:\n \n \tint init();\n \tint setFocusPosition(int32_t position);\n+\tint setSubdevControls(const ControlList &controls);\n \n \tconst std::string &model() const { return model_; }\n \ndiff --git a/src/libcamera/camera_lens.cpp b/src/libcamera/camera_lens.cpp\nindex b3d48199..c8fadda5 100644\n--- a/src/libcamera/camera_lens.cpp\n+++ b/src/libcamera/camera_lens.cpp\n@@ -95,6 +95,16 @@ int CameraLens::setFocusPosition(int32_t position)\n \treturn 0;\n }\n \n+int CameraLens::setSubdevControls(const ControlList &controls)\n+{\n+\tControlList lensCtrls(controls);\n+\n+\tif (subdev_->setControls(&lensCtrls))\n+\t\treturn -EINVAL;\n+\n+\treturn 0;\n+}\n+\n int CameraLens::validateLensDriver()\n {\n \tint ret = 0;\n", "prefixes": [ "libcamera-devel", "RFC", "2/7" ] }