Patch Detail
Show a patch.
GET /api/1.1/patches/18118/?format=api
{ "id": 18118, "url": "https://patchwork.libcamera.org/api/1.1/patches/18118/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18118/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230116002808.16014-2-laurent.pinchart@ideasonboard.com>", "date": "2023-01-16T00:28:01", "name": "[libcamera-devel,v9,1/8] libcamera: framebuffer: Allow inheritance of FrameBuffer", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "1824248175cc997dd16eac279826e130593ec312", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18118/mbox/", "series": [ { "id": 3712, "url": "https://patchwork.libcamera.org/api/1.1/series/3712/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3712", "date": "2023-01-16T00:28:00", "name": "Add CrOS JEA implementation", "version": 9, "mbox": "https://patchwork.libcamera.org/series/3712/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18118/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18118/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D8E0FBD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 16 Jan 2023 00:28:12 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 92E0C625EA;\n\tMon, 16 Jan 2023 01:28:12 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 79368625E7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 16 Jan 2023 01:28:10 +0100 (CET)", "from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C9FD3997;\n\tMon, 16 Jan 2023 01:28:09 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1673828892;\n\tbh=wmPq7P28jwxF2raIg3WaEvq4ng2ER7Eb+6lQp7HSeSI=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=SBt0p91Yyg88cdmQbUVQJS84DSdSm4fe3GD8tyWCsslpwQUUqr5iGu6ZVsgtSPgf9\n\tAujKh0CsWwYarLcZNJlaxeGi8S8oqnxG7b0z9e8zPYwbsuqF4ghlrBwsLCMVziXIA2\n\tFxsMaIeodqB03nREUoSPDsYTgSTOGLIhhMzpSo1WsoSzwobZzofHmsBDDEYCMsycS8\n\tjXHXsutg0wfFfOg75YuAzRvJS41xsjnOCjNfmMxqtuIlmxcnTudEQUC0EuP7zn3bfO\n\tRFYKOSJGhdjdwGh9u/mDLc999o3MKCT4wn2VHfst1qWSzbMelWvYDYa45LhOtAJBlJ\n\td4aq2YhDn1mUw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1673828890;\n\tbh=wmPq7P28jwxF2raIg3WaEvq4ng2ER7Eb+6lQp7HSeSI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=mJq39e8SCTFWIfnP3OZTtWGitCiJbHOHzn9mn0s/UsnV+pC0l5kCWnbnnZBOtITJD\n\tIT3vDjcAc2ns+xmkTPUb4YTHr9Wm18axgJfxeHegyzbYKYevfeDO7VTqYPZhT6b+Lc\n\tIjbnKnW1mxCg0pWpfmAMvD5gGjsoa41804j7a0r8=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"mJq39e8S\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 16 Jan 2023 02:28:01 +0200", "Message-Id": "<20230116002808.16014-2-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.38.2", "In-Reply-To": "<20230116002808.16014-1-laurent.pinchart@ideasonboard.com>", "References": "<20230116002808.16014-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v9 1/8] libcamera: framebuffer: Allow\n\tinheritance of FrameBuffer", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Cc": "Harvey Yang <chenghaoyang@chromium.org>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Harvey Yang <chenghaoyang@chromium.org>\n\nTo add buffer_handle_t access in android, this patch allows inheritance\nof FrameBuffer to add a derived class in android.\n\nSigned-off-by: Harvey Yang <chenghaoyang@chromium.org>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Han-Lin Chen <hanlinchen@chromium.org>\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/framebuffer.h | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/framebuffer.h b/include/libcamera/framebuffer.h\nindex 695539993f96..612448290a24 100644\n--- a/include/libcamera/framebuffer.h\n+++ b/include/libcamera/framebuffer.h\n@@ -46,7 +46,7 @@ private:\n \tstd::vector<Plane> planes_;\n };\n \n-class FrameBuffer final : public Extensible\n+class FrameBuffer : public Extensible\n {\n \tLIBCAMERA_DECLARE_PRIVATE()\n \n@@ -60,6 +60,7 @@ public:\n \n \tFrameBuffer(const std::vector<Plane> &planes, unsigned int cookie = 0);\n \tFrameBuffer(std::unique_ptr<Private> d);\n+\tvirtual ~FrameBuffer() {}\n \n \tconst std::vector<Plane> &planes() const;\n \tRequest *request() const;\n", "prefixes": [ "libcamera-devel", "v9", "1/8" ] }