Patch Detail
Show a patch.
GET /api/1.1/patches/18085/?format=api
{ "id": 18085, "url": "https://patchwork.libcamera.org/api/1.1/patches/18085/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18085/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230104161501.100221-1-matti.lehtimaki@gmail.com>", "date": "2023-01-04T16:15:01", "name": "[libcamera-devel] libcamera: Use C++17 [[fallthrough]] everywhere", "commit_ref": "504b6437613f35de043485bd064843d6af269c74", "pull_url": null, "state": "accepted", "archived": false, "hash": "ac37f37e25b4105993371101c659b6d60dd90afe", "submitter": { "id": 144, "url": "https://patchwork.libcamera.org/api/1.1/people/144/?format=api", "name": "Matti Lehtimäki", "email": "matti.lehtimaki@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18085/mbox/", "series": [ { "id": 3699, "url": "https://patchwork.libcamera.org/api/1.1/series/3699/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3699", "date": "2023-01-04T16:15:01", "name": "[libcamera-devel] libcamera: Use C++17 [[fallthrough]] everywhere", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3699/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18085/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18085/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ECA9ABD78E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 4 Jan 2023 16:31:56 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 32220625DE;\n\tWed, 4 Jan 2023 17:31:56 +0100 (CET)", "from mail-lf1-x135.google.com (mail-lf1-x135.google.com\n\t[IPv6:2a00:1450:4864:20::135])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A3F4F603C5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 4 Jan 2023 17:15:24 +0100 (CET)", "by mail-lf1-x135.google.com with SMTP id bp15so51060407lfb.13\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 04 Jan 2023 08:15:24 -0800 (PST)", "from i-vetokaappi.home.lan (dsl-hkibng42-56733b-36.dhcp.inet.fi.\n\t[86.115.59.36]) by smtp.gmail.com with ESMTPSA id\n\ta25-20020ac25e79000000b004a0589786ddsm5219482lfr.69.2023.01.04.08.15.22\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 04 Jan 2023 08:15:23 -0800 (PST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1672849916;\n\tbh=lK6zSkernqH9qql71Z9YSI3zLaL2q2iF3oUqMfcIbDk=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:Cc:From;\n\tb=nmHGep9bh9poTLdH537Vv66/O1Z2o7h1Ja8QMUoKHNZB4HT+Vg5ms7WyJepmwneu0\n\tO2ygHx1xE531jqD1lr9j/DKQ3i+ku3+03eRszornyjV5VSvDyQpb4aqiqzcWplFExf\n\tfW7hJ0aAp3kM7PuwHq217+UlUvMLGKqBL1Vcleb+h98SFWJLsCRrzY74HXlsIPQMxJ\n\tFDIVqavG3n9Km5xAK24EFeUXm5f1rcAA76S8yg3onyudjY96lvCMAlaadhs4vZmK4+\n\tJ/m2WVzq/xiAkuX4KyJy9w/t8LSkWr6Be4LuFw+3yvfj1umoCK5uimaPoZjFTd+tGw\n\ttlMjkK1keQRUg==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=kRuNMhYlDOZTUn/sYF0y7T0N10eWjorF2vYXFMtcUlM=;\n\tb=KZHl5ohZPVaKkLFiTPr7ByYkp8OQmeFuyGhgd+SVCIj1IwENsK1fcr7IkQYaz88s3L\n\tpcLgDbFsBToYyprfm07b+MGx7j8At8vBBczubw5ssijLbqN7OzV13zkSOwvJlEeqU6Rh\n\tj1V+stMG/r7DaqDq/+xe7I1l9Jk58mTACnwSnRsghH+JUZzHiAcduApoqMAiJOgc2hot\n\tHXJJX8CTGuht8NysaVRY4fuYi5vAtsiOhH3iAGlK29OebvUtykkANR64r5HsoJScEz7f\n\t6jFSmYQ30GFhGnSTvEF8qlayplzyxLT00N99qZexoaPBcCwlZPPVE1gvUpcdl5jXpio/\n\t1bQA==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"KZHl5ohZ\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=kRuNMhYlDOZTUn/sYF0y7T0N10eWjorF2vYXFMtcUlM=;\n\tb=dnuEc0qw3F0F3xgH6BY3ezJoiIVlGip1gfzfLqRkJIAhkbIZF5WlEMHwxQOc0Hxl5y\n\tZ9+0SkgXQChV/+dsdh3fAR8q2+BWMQuP91JNvrBiDijwT3JMD4mQWCfiI6Ky1lGJIFgd\n\t1X5uSJZP5YuZgND8gYgnv9CAeEHOX2HLt4s+xH7cP2+LXGusj2rZ/Cs/dzfz0TGHbgXQ\n\tKJ5Kn7LdXBBvyELJbo3eXzXIHIJ6rxA7wx8QAu5ja6/EfQQJGmSyE5mW5IpEjQi05x2r\n\tz0vw/wbpM07BrstdQLk3jGZ7Ayi/DsnUjqdGEbopV8KqNWTYtcdRbZwSKKyjUmUdvXEr\n\tdgqA==", "X-Gm-Message-State": "AFqh2kpOkWtNrKTW/t79QwmxoOunjiDqbxyQ/SLK+RjN1MwGUfaHsoo+\n\tp5N0tqoMvzh/wHGvLcVM8RXXLLnyZsE=", "X-Google-Smtp-Source": "AMrXdXvUkBvCs+dA30aJ3LD484FXQSaM2PGFi6OeZ3uY0d/zbD6fbFZd4K7WIHbcx128mScEsDl3WA==", "X-Received": "by 2002:a05:6512:3a8f:b0:4c8:5f19:ccb8 with SMTP id\n\tq15-20020a0565123a8f00b004c85f19ccb8mr14249065lfu.48.1672848923702; \n\tWed, 04 Jan 2023 08:15:23 -0800 (PST)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 4 Jan 2023 18:15:01 +0200", "Message-Id": "<20230104161501.100221-1-matti.lehtimaki@gmail.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Wed, 04 Jan 2023 17:31:55 +0100", "Subject": "[libcamera-devel] [PATCH] libcamera: Use C++17 [[fallthrough]]\n\teverywhere", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "=?utf-8?q?Matti_Lehtim=C3=A4ki_via_libcamera-devel?=\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "=?utf-8?q?Matti_Lehtim=C3=A4ki?= <matti.lehtimaki@gmail.com>", "Cc": "=?utf-8?q?Matti_Lehtim=C3=A4ki?= <matti.lehtimaki@gmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Fixes build failure on some build environments.\n\nSigned-off-by: Matti Lehtimäki <matti.lehtimaki@gmail.com>\n---\n src/gstreamer/gstlibcamera-utils.cpp | 2 +-\n src/libcamera/camera_sensor.cpp | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\nindex 16aac441..750ec351 100644\n--- a/src/gstreamer/gstlibcamera-utils.cpp\n+++ b/src/gstreamer/gstlibcamera-utils.cpp\n@@ -154,7 +154,7 @@ colorspace_from_colorimetry(const GstVideoColorimetry &colorimetry)\n \tcase GST_VIDEO_TRANSFER_GAMMA22:\n \tcase GST_VIDEO_TRANSFER_GAMMA28:\n \t\tGST_WARNING(\"GAMMA 18, 20, 22, 28 transfer functions not supported\");\n-\t/* fallthrough */\n+\t\t[[fallthrough]];\n \tcase GST_VIDEO_TRANSFER_GAMMA10:\n \t\tcolorspace->transferFunction = ColorSpace::TransferFunction::Linear;\n \t\tbreak;\ndiff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\nindex ae3127d6..a210aa4f 100644\n--- a/src/libcamera/camera_sensor.cpp\n+++ b/src/libcamera/camera_sensor.cpp\n@@ -427,7 +427,7 @@ int CameraSensor::initProperties()\n \t\t\tLOG(CameraSensor, Warning)\n \t\t\t\t<< \"Unsupported camera location \"\n \t\t\t\t<< v4l2Orientation << \", setting to External\";\n-\t\t\t/* Fall-through */\n+\t\t\t[[fallthrough]];\n \t\tcase V4L2_CAMERA_ORIENTATION_EXTERNAL:\n \t\t\tpropertyValue = properties::CameraLocationExternal;\n \t\t\tbreak;\n", "prefixes": [ "libcamera-devel" ] }