Patch Detail
Show a patch.
GET /api/1.1/patches/18065/?format=api
{ "id": 18065, "url": "https://patchwork.libcamera.org/api/1.1/patches/18065/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18065/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221228223003.2265712-10-paul.elder@ideasonboard.com>", "date": "2022-12-28T22:29:53", "name": "[libcamera-devel,v10,09/19] libcamera: pipeline: imx8-isi: Don't rely on bufferCount", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "917d26f829a03125aba657f392679a4b34f0fb23", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18065/mbox/", "series": [ { "id": 3691, "url": "https://patchwork.libcamera.org/api/1.1/series/3691/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3691", "date": "2022-12-28T22:29:44", "name": "lc-compliance: Add test to queue more requests than hardware depth", "version": 10, "mbox": "https://patchwork.libcamera.org/series/3691/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18065/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18065/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 85B02C3220\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 28 Dec 2022 22:30:35 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 42A36625F1;\n\tWed, 28 Dec 2022 23:30:35 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3FF66625E2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 28 Dec 2022 23:30:28 +0100 (CET)", "from pyrite.mediacom.info (unknown\n\t[IPv6:2604:2d80:ad8a:9000:1bf9:855b:22de:3645])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6C0926D0;\n\tWed, 28 Dec 2022 23:30:27 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1672266635;\n\tbh=KwCPVGMhnKnk3gOlN8lsIY4y9ZgU1B0i6eBSxJaRGbg=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=dKabyulCys+M+J4JxDAXMTOy9lXMIwitQBS6JpP9SPpLF8hA+qNK9sk2LJecA4xe8\n\tq1ADHjRpWvzImu52fthjIdHLWBmyTvzr0iQ15Sm+BfuoXZUEgH0tEOLt73PGLjjczQ\n\tm4fP6jzANDUE6qoNPYEIVUl6YjUKVAaggtWkqYQMNx/c3R5fseYbCqOEefNA1RbuI8\n\t5m8dek/8+QSfJ0CDkRMv50ScmSymd83JIvBecwm4ouYqFKl+nUwmvcYXdQpZicECRC\n\tNnQI27yLxv2FCShNfcG1RaC4R6hrQwKIZI69B8bmajVFAjX0yOQ1uaJrGvW4YXboZf\n\tMvBMmR+3IYeEw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1672266628;\n\tbh=KwCPVGMhnKnk3gOlN8lsIY4y9ZgU1B0i6eBSxJaRGbg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=WWm0h8H0ntMl8qRegeQPzMC0UznKS0Zz9ghdEUFvhOOrUpEdsJsRxnZZNhDzKbWcW\n\tz+P/TAZDDfdtvU59rH7cSlULW31ieG6fqTyFCfLhqsx8qfDLdo3vTCMRVnFrJ+a7O+\n\t4t0jEuCI9Wj7NEFFHSyvfIgY338tHWPRh+0dVDYY=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"WWm0h8H0\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 28 Dec 2022 16:29:53 -0600", "Message-Id": "<20221228223003.2265712-10-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20221228223003.2265712-1-paul.elder@ideasonboard.com>", "References": "<20221228223003.2265712-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v10 09/19] libcamera: pipeline: imx8-isi:\n\tDon't rely on bufferCount", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Paul Elder via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Paul Elder <paul.elder@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Instead of using bufferCount as the number of V4L2 buffer slots to\nreserve in the isi pipeline handler, use a reasonably high constant: 16.\nOverallocating isn't a problem as buffer slots are cheap. Having too\nfew, on the other hand, could degrade performance. It is expected that\nthis number will be more than enough for most, if not all, use cases.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\nNew in v10\n---\n src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\nindex 434fbd63..73eeaf0e 100644\n--- a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n+++ b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n@@ -148,6 +148,8 @@ private:\n \n \tstd::unique_ptr<V4L2Subdevice> crossbar_;\n \tstd::vector<Pipe> pipes_;\n+\n+\tstatic constexpr unsigned int kBufferSlotCount = 16;\n };\n \n /* -----------------------------------------------------------------------------\n@@ -820,9 +822,8 @@ int PipelineHandlerISI::start(Camera *camera,\n \n \tfor (const auto &stream : data->enabledStreams_) {\n \t\tPipe *pipe = pipeFromStream(camera, stream);\n-\t\tconst StreamConfiguration &config = stream->configuration();\n \n-\t\tint ret = pipe->capture->importBuffers(config.bufferCount);\n+\t\tint ret = pipe->capture->importBuffers(kBufferSlotCount);\n \t\tif (ret)\n \t\t\treturn ret;\n \n", "prefixes": [ "libcamera-devel", "v10", "09/19" ] }