Patch Detail
Show a patch.
GET /api/1.1/patches/18044/?format=api
{ "id": 18044, "url": "https://patchwork.libcamera.org/api/1.1/patches/18044/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18044/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<Y6NFu/O6VDG+WYdN@duo.ucw.cz>", "date": "2022-12-21T17:43:23", "name": "[libcamera-devel] Add bayer8 support to gstlibcamera", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "efc946f6a9616e806cb28fc55d40767ec7f4c09f", "submitter": { "id": 49, "url": "https://patchwork.libcamera.org/api/1.1/people/49/?format=api", "name": "Pavel Machek", "email": "pavel@ucw.cz" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18044/mbox/", "series": [ { "id": 3683, "url": "https://patchwork.libcamera.org/api/1.1/series/3683/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3683", "date": "2022-12-21T17:43:23", "name": "[libcamera-devel] Add bayer8 support to gstlibcamera", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3683/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18044/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18044/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EDC1BC3213\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 21 Dec 2022 17:43:26 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4D2ED633AC;\n\tWed, 21 Dec 2022 18:43:26 +0100 (CET)", "from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F26D961F15\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 21 Dec 2022 18:43:24 +0100 (CET)", "by jabberwock.ucw.cz (Postfix, from userid 1017)\n\tid 71DA91C09F5; Wed, 21 Dec 2022 18:43:24 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1671644606;\n\tbh=GtSgvHXNXWx7fvL1culj1EoC2pDv0WIrQUOVxwSopAU=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=UW/DJFbbFEgwvKdPK+NBP3rv7/oJU8xwblk2v0Svg1UbBAGC7PENLLuur/dtc9qo3\n\tS0vP1nNN0AQ3FL+FvvkUBG9ivVQy7vErENcFGCiWy+oSquQLenodGKxCqziOmF9pmG\n\t+bUOvo+7y3xwb3+l2yzy1dKRVQ24O7+X8x6MkUv+D+JKS1Sz1p/yAPTUa/PL4JVAH7\n\t036zswS0S7nghOdyVGNJqGeOGWKmADYiNFaJPTQinnoy+S525Mb7WWFtpeBHBh137O\n\tKnrV5G+wpRP0WgjQUlNVTf1A5tQeZj6dLS0iX5ThmEn673o8A8wvVEwb769lxwZurc\n\tHFIJFwgffQstw==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucw.cz; s=gen1;\n\tt=1671644604;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=/iix150x8ATjlHoL+Jbt1D1Ee40ifT3DyIUxRz99Mf8=;\n\tb=ncNQiFbWBOJujRHkR+g5hKI7fPoXWWTwJyc0DQeLJH4ndyXsd3eJ12VUGdYfUWsCSwq2ku\n\tfqd3XFzbNzf/a2uMt5YhE3t//xXgTGfYQZh861Vaz0XX4Vq9VMkTxOmXk/jIpm1AAB0MEX\n\t2+YSpzXBwLhlJUnZwZD0v7i/XC7ECZM=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ucw.cz header.i=@ucw.cz\n\theader.b=\"ncNQiFbW\"; dkim-atps=neutral", "Date": "Wed, 21 Dec 2022 18:43:23 +0100", "To": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Message-ID": "<Y6NFu/O6VDG+WYdN@duo.ucw.cz>", "References": "<Y52jM6iQtzs0Vysm@duo.ucw.cz>\n\t<CAKQmDh9BDUWonGdnOqz4uNPwS+L6cQMh1A2O4Be3Z=z+JqbQTQ@mail.gmail.com>\n\t<Y545RJF0JMWIQUwe@duo.ucw.cz>\n\t<a060b121a53465d2118d8d6194cd866e32ccc238.camel@ndufresne.ca>\n\t<Y6IzhjY3XQZn2oci@duo.ucw.cz>\n\t<167162721688.3944359.738999548555516756@Monstersaurus>", "MIME-Version": "1.0", "Content-Type": "multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\"; boundary=\"0xWFbC74ah5KugBd\"", "Content-Disposition": "inline", "In-Reply-To": "<167162721688.3944359.738999548555516756@Monstersaurus>", "Subject": "[libcamera-devel] [PATCH] Add bayer8 support to gstlibcamera", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Pavel Machek via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Pavel Machek <pavel@ucw.cz>", "Cc": "Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>,\n\tPavel Machek via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Bayer8 support is useful on hardware such as Librem 5, as gstreamer\nprovides easy solution for debayering and display of the camera\ndata. Add neccessary glue to gstlibcamera.\n\nSigned-off-by: Pavel Machek <pavel@ucw.cz>", "diff": "diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\nindex 36b9564c..b2cc7661 100644\n--- a/src/gstreamer/gstlibcamera-utils.cpp\n+++ b/src/gstreamer/gstlibcamera-utils.cpp\n@@ -20,6 +20,12 @@ static struct {\n \t/* Compressed */\n \t{ GST_VIDEO_FORMAT_ENCODED, formats::MJPEG },\n \n+\t/* Bayer formats, gstreamer only supports 8-bit */\n+\t{ GST_VIDEO_FORMAT_ENCODED, formats::SGRBG8 },\n+\t{ GST_VIDEO_FORMAT_ENCODED, formats::SGBRG8 },\n+\t{ GST_VIDEO_FORMAT_ENCODED, formats::SRGGB8 },\n+\t{ GST_VIDEO_FORMAT_ENCODED, formats::SBGGR8 },\n+\n \t/* RGB16 */\n \t{ GST_VIDEO_FORMAT_RGB16, formats::RGB565 },\n \n@@ -228,6 +234,22 @@ gst_format_to_pixel_format(GstVideoFormat gst_format)\n \treturn PixelFormat{};\n }\n \n+static const gchar *\n+bayer_format_to_string(int format)\n+{\n+\tswitch (format) {\n+\tcase formats::SGRBG8:\n+\t\treturn \"grbg\";\n+\tcase formats::SGBRG8:\n+\t\treturn \"gbrg\";\n+\tcase formats::SRGGB8:\n+\t\treturn \"rggb\";\n+\tcase formats::SBGGR8:\n+\t\treturn \"bggr\";\n+\t}\n+\treturn NULL;\n+}\n+\n static GstStructure *\n bare_structure_from_format(const PixelFormat &format)\n {\n@@ -243,6 +265,12 @@ bare_structure_from_format(const PixelFormat &format)\n \tswitch (format) {\n \tcase formats::MJPEG:\n \t\treturn gst_structure_new_empty(\"image/jpeg\");\n+\tcase formats::SGRBG8:\n+\tcase formats::SGBRG8:\n+\tcase formats::SRGGB8:\n+\tcase formats::SBGGR8:\n+\t\treturn gst_structure_new(\"video/x-bayer\", \"format\", G_TYPE_STRING,\n+\t\t\t\t\t bayer_format_to_string(format), nullptr);\n \tdefault:\n \t\treturn nullptr;\n \t}\ndiff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex 8d97d7c2..2ceeeb99 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -161,7 +161,7 @@ G_DEFINE_TYPE_WITH_CODE(GstLibcameraSrc, gst_libcamera_src, GST_TYPE_ELEMENT,\n \t\t\tGST_DEBUG_CATEGORY_INIT(source_debug, \"libcamerasrc\", 0,\n \t\t\t\t\t\t\"libcamera Source\"))\n \n-#define TEMPLATE_CAPS GST_STATIC_CAPS(\"video/x-raw; image/jpeg\")\n+#define TEMPLATE_CAPS GST_STATIC_CAPS(\"video/x-raw; video/x-bayer; image/jpeg\")\n \n /* For the simple case, we have a src pad that is always present. */\n GstStaticPadTemplate src_template = {\n", "prefixes": [ "libcamera-devel" ] }