Patch Detail
Show a patch.
GET /api/1.1/patches/18032/?format=api
{ "id": 18032, "url": "https://patchwork.libcamera.org/api/1.1/patches/18032/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18032/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221216122939.256534-19-paul.elder@ideasonboard.com>", "date": "2022-12-16T12:29:39", "name": "[libcamera-devel,v9,18/18] lc-compliance: Add test to ensure MinimumRequests is valid", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "db207137974cc7ba3e080c1a17cc7c9395403239", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18032/mbox/", "series": [ { "id": 3675, "url": "https://patchwork.libcamera.org/api/1.1/series/3675/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3675", "date": "2022-12-16T12:29:21", "name": "lc-compliance: Add test to queue more requests than hardware depth", "version": 9, "mbox": "https://patchwork.libcamera.org/series/3675/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18032/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18032/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6DF81C31E9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 16 Dec 2022 12:30:36 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2DE19633A4;\n\tFri, 16 Dec 2022 13:30:36 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D93BA633AF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 16 Dec 2022 13:30:33 +0100 (CET)", "from pyrite.tail37cf.ts.net (h175-177-042-159.catv02.itscom.jp\n\t[175.177.42.159])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 77718A31;\n\tFri, 16 Dec 2022 13:30:32 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1671193836;\n\tbh=/M26qPJ7k6mqHPhoPV+Oh3tT8sQFGR1h1qUekrIScDE=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=hhidQWKhYWoqnYIxe6DXLx3LzNUCxfcacSHxi3QNgaOFUmpsHykNIRVBOA5La3nRP\n\tETxjxLHpbTorgPiCl96OCA3jYEVK5aRaxDJvGFqDU49JaO2qNc0RgKRRk5ERfrPJem\n\tmbG5vRVLq763QgwaX/tdUsrI33QqHwzJl2LpYlcJ9xq0+WSbBYEQPFcoRTITpEc512\n\tt+mE1sBRq3BQaHKW6NM+VXqLpXoZu8rwkA3zOZAadV1qxTV+zOkQ10pSkF8L350bAP\n\tCDdfd6/H2IPMueihgSkCe4vhMonHOkjC7OXLgsKbpB1OM9rMagN+/sSWJ/NjbBIw4A\n\t17795kNce5hWA==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1671193833;\n\tbh=/M26qPJ7k6mqHPhoPV+Oh3tT8sQFGR1h1qUekrIScDE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Yba/TGYuM8fbKgH7JlFFdK9OMv9tpzHF0sFSveucdU5yTB9x+WJFHK/hym3dUbJ7U\n\tSEABzLvsTkfnBEPXDFbDs2lJDJ1QerjX6TWikuB1dVtIva2xkdSkzPT8WKSiDHp5fX\n\tNNTMKA54KfXApJp/mvxk62IEiSM6MwXYGf3uZd6c=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Yba/TGYu\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 16 Dec 2022 21:29:39 +0900", "Message-Id": "<20221216122939.256534-19-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20221216122939.256534-1-paul.elder@ideasonboard.com>", "References": "<20221216122939.256534-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v9 18/18] lc-compliance: Add test to\n\tensure MinimumRequests is valid", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Paul Elder via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Paul Elder <paul.elder@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Nícolas F. R. A. Prado <nfraprado@collabora.com>\n\nAdd a test in lc-compliance to check that the MinimumRequests property\nis set and valid, that is, greater than 0.\n\nSigned-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\nChanges in v9:\n- rebased\n\nChanges in v8:\n- Moved RequiredProperties test to property_test.cpp\n- Moved CameraTests to new test_base.{cpp,h} files\n\nChanges in v7:\n- New\n---\n src/apps/lc-compliance/meson.build | 1 +\n src/apps/lc-compliance/property_test.cpp | 24 ++++++++++++++++++++++++\n src/apps/lc-compliance/test_base.cpp | 10 ++++++++++\n src/apps/lc-compliance/test_base.h | 7 +++++++\n 4 files changed, 42 insertions(+)\n create mode 100644 src/apps/lc-compliance/property_test.cpp", "diff": "diff --git a/src/apps/lc-compliance/meson.build b/src/apps/lc-compliance/meson.build\nindex fae290bb..a10a3cc2 100644\n--- a/src/apps/lc-compliance/meson.build\n+++ b/src/apps/lc-compliance/meson.build\n@@ -14,6 +14,7 @@ lc_compliance_sources = files([\n 'capture_test.cpp',\n 'environment.cpp',\n 'main.cpp',\n+ 'property_test.cpp',\n 'simple_capture.cpp',\n 'test_base.cpp',\n ])\ndiff --git a/src/apps/lc-compliance/property_test.cpp b/src/apps/lc-compliance/property_test.cpp\nnew file mode 100644\nindex 00000000..6a0951b2\n--- /dev/null\n+++ b/src/apps/lc-compliance/property_test.cpp\n@@ -0,0 +1,24 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2021, Collabora Ltd.\n+ *\n+ * property_test.cpp - Test camera properties\n+ */\n+\n+#include <libcamera/libcamera.h>\n+\n+#include <gtest/gtest.h>\n+\n+#include \"test_base.h\"\n+\n+using namespace libcamera;\n+\n+TEST_F(CameraTests, RequiredProperties)\n+{\n+\tconst ControlList &properties = camera_->properties();\n+\n+\tusing namespace properties;\n+\n+\tEXPECT_GT(properties.get(MinimumRequests), 0)\n+\t\t<< \"Camera should have a positive value for MinimumRequests property\";\n+}\ndiff --git a/src/apps/lc-compliance/test_base.cpp b/src/apps/lc-compliance/test_base.cpp\nindex c9957b9e..a5e64c8b 100644\n--- a/src/apps/lc-compliance/test_base.cpp\n+++ b/src/apps/lc-compliance/test_base.cpp\n@@ -26,3 +26,13 @@ void CameraHolder::releaseCamera()\n \tcamera_->release();\n \tcamera_.reset();\n }\n+\n+void CameraTests::SetUp()\n+{\n+\tacquireCamera();\n+}\n+\n+void CameraTests::TearDown()\n+{\n+\treleaseCamera();\n+}\ndiff --git a/src/apps/lc-compliance/test_base.h b/src/apps/lc-compliance/test_base.h\nindex 52347749..8125e1c6 100644\n--- a/src/apps/lc-compliance/test_base.h\n+++ b/src/apps/lc-compliance/test_base.h\n@@ -21,4 +21,11 @@ protected:\n \tstd::shared_ptr<libcamera::Camera> camera_;\n };\n \n+class CameraTests : public ::testing::Test, public CameraHolder\n+{\n+protected:\n+\tvoid SetUp() override;\n+\tvoid TearDown() override;\n+};\n+\n #endif /* __LC_COMPLIANCE_TEST_BASE_H__ */\n", "prefixes": [ "libcamera-devel", "v9", "18/18" ] }