Patch Detail
Show a patch.
GET /api/1.1/patches/18031/?format=api
{ "id": 18031, "url": "https://patchwork.libcamera.org/api/1.1/patches/18031/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18031/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221216122939.256534-18-paul.elder@ideasonboard.com>", "date": "2022-12-16T12:29:38", "name": "[libcamera-devel,v9,17/18] lc-compliance: Check that requests complete successfully", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "af4aaf8833cbf5ed4da2bc688908623ec57e100a", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18031/mbox/", "series": [ { "id": 3675, "url": "https://patchwork.libcamera.org/api/1.1/series/3675/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3675", "date": "2022-12-16T12:29:21", "name": "lc-compliance: Add test to queue more requests than hardware depth", "version": 9, "mbox": "https://patchwork.libcamera.org/series/3675/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18031/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18031/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F117BC31E9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 16 Dec 2022 12:30:33 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ABEEA633B2;\n\tFri, 16 Dec 2022 13:30:33 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 25C1063360\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 16 Dec 2022 13:30:32 +0100 (CET)", "from pyrite.tail37cf.ts.net (h175-177-042-159.catv02.itscom.jp\n\t[175.177.42.159])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B391C128D;\n\tFri, 16 Dec 2022 13:30:30 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1671193833;\n\tbh=mf9lLD2HWERLMm1bvaPiXYY+T6Bud9wv1LwIPxTz7ag=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=ynYB5TmvdGasThu/YHb5ib11+82QUx2DVUipuuVKpLpHbsYEgAZ6vOcDEmt0Q2j0R\n\tVWvY2swdCliP+HYTOPmMb7HdEG9tDYcK4ib+IUFqXXZUgVZKYVGwcsJ8ohm2XyB/bf\n\tdW4aGWsFtxi+zKcFoXE4Fh1fIFxv45rQnoWceKWPxWAyM+i0u2G3AgH2bInobLT9P6\n\tUk4+QIZoVl4wT5GDza6Usa7zrtS+7VgGtqukYyuqcRX4M/7HDFCiYW3aAXorlT3Mxa\n\tTuwqmNnro2VvL7GaGQafgHpOfIi/dM/wMm6wRBQV8cXX7n/hWaRyPla5xcB/i5LJCg\n\tL7qEZwKnTEeWg==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1671193831;\n\tbh=mf9lLD2HWERLMm1bvaPiXYY+T6Bud9wv1LwIPxTz7ag=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=p/O7DIst/tq5cAAfS+tiLcSX6wOFEUsHkqR9Hjhg0X6B3kA935KyNayEBBeUYCOBo\n\tkfbmwX4ZjJ/WtqsVXnltYFlTOzjjHMMONWsQwGP2hN5wAlu9g0o6c0Oo1DZxFBp/LS\n\tP7yS7OkoCPxbFmvZnvQb41E4NZXAdDuF1s9x7DHs=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"p/O7DIst\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 16 Dec 2022 21:29:38 +0900", "Message-Id": "<20221216122939.256534-18-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20221216122939.256534-1-paul.elder@ideasonboard.com>", "References": "<20221216122939.256534-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v9 17/18] lc-compliance: Check that\n\trequests complete successfully", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Paul Elder via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Paul Elder <paul.elder@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Nícolas F. R. A. Prado <nfraprado@collabora.com>\n\nWhen a request fails to queue it is completed but with its status set to\nRequestCancelled. Add a check in the requestComplete callback to make\nsure that the request was completed successfully.\n\nFor the SimpleCaptureUnbalanced test we need to do this check only if\nthe capture isn't over yet, otherwise the few extra requests that get\ncancelled at the end, which is the normal behavior, will make the test\nfail.\n\nSigned-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\nChanges in v9:\n- rebased\n\nChanges in v8:\n- Fixed issue in UnbalancedStop test where requests cancelled due to stop() call\n were failing the test\n- Fixed formatting\n\nChanges in v5:\n- New\n---\n src/apps/lc-compliance/simple_capture.cpp | 9 +++++++++\n 1 file changed, 9 insertions(+)", "diff": "diff --git a/src/apps/lc-compliance/simple_capture.cpp b/src/apps/lc-compliance/simple_capture.cpp\nindex a37a98ac..02b00d9a 100644\n--- a/src/apps/lc-compliance/simple_capture.cpp\n+++ b/src/apps/lc-compliance/simple_capture.cpp\n@@ -164,6 +164,9 @@ int SimpleCaptureBalanced::queueRequest(Request *request)\n \n void SimpleCaptureBalanced::requestComplete(Request *request)\n {\n+\tEXPECT_EQ(request->status(), Request::Status::RequestComplete)\n+\t\t<< \"Request didn't complete successfully\";\n+\n \tif (captureCompleted())\n \t\treturn;\n \n@@ -201,6 +204,9 @@ void SimpleCaptureUnbalanced::requestComplete(Request *request)\n \tif (captureCompleted())\n \t\treturn;\n \n+\tEXPECT_EQ(request->status(), Request::Status::RequestComplete)\n+\t\t<< \"Request didn't complete successfully\";\n+\n \trequest->reuse(Request::ReuseBuffers);\n \tif (camera_->queueRequest(request))\n \t\tloop_->exit(-EINVAL);\n@@ -232,5 +238,8 @@ void SimpleCaptureOverflow::capture()\n \n void SimpleCaptureOverflow::requestComplete([[maybe_unused]] Request *request)\n {\n+\tEXPECT_EQ(request->status(), Request::Status::RequestComplete)\n+\t\t<< \"Request didn't complete successfully\";\n+\n \tcaptureCompleted();\n }\n", "prefixes": [ "libcamera-devel", "v9", "17/18" ] }