Patch Detail
Show a patch.
GET /api/1.1/patches/17981/?format=api
{ "id": 17981, "url": "https://patchwork.libcamera.org/api/1.1/patches/17981/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17981/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221212150256.69004-2-umang.jain@ideasonboard.com>", "date": "2022-12-12T15:02:55", "name": "[libcamera-devel,1/2] ipa: Move kMaxFrameContexts to mojom interface", "commit_ref": null, "pull_url": null, "state": "deferred", "archived": false, "hash": "919b345ec7c52800d3c959e71989d276420df573", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/1.1/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17981/mbox/", "series": [ { "id": 3667, "url": "https://patchwork.libcamera.org/api/1.1/series/3667/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3667", "date": "2022-12-12T15:02:54", "name": "pipeline-handler: Consider in-flight max requests", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3667/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17981/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17981/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 63413BDE6B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 12 Dec 2022 15:03:10 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 22D1D63361;\n\tMon, 12 Dec 2022 16:03:10 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A22CB63361\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 12 Dec 2022 16:03:08 +0100 (CET)", "from umang.jainideasonboard.com (unknown\n\t[IPv6:2401:4900:1f3e:7d24:3f0:3e81:fb16:ab4d])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 38FB46CF;\n\tMon, 12 Dec 2022 16:03:06 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1670857390;\n\tbh=YWPWwqQkHBcUXVJShx6TFB02q7dRvu1h8sWW3ltEzD0=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=bsVwbRAcswi6FuiBBDZt9VLHyxRfBrXzPNH0SjyPEFrzdW/qFqC7lKHOLqFatwY9f\n\tHXLiiRmSINmvMQ+4YPRMv9yJiTSg2wq6/dTMfFnmHFMew9IfE4AblbYn5BaSxn88FE\n\tL3zJVcrSfxQLxZdu4GVZczwREawYRnCbMG9UX277hhfLXFwmkqjflPlicIEUjOWu1y\n\t6OgFpVwYHskx1/MH1AOkDYlkmWE3eQxZVSmOwf0naCZuD/MVrWV4ROqyNLGYG0PTp/\n\thTz9KIEdMquP1VB4NoGIUnYH8Vu8M2rq+TReQYy8UDp8j7280cEjZLnKh3l09/J6nz\n\tT2WOLpIPnLqHA==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1670857388;\n\tbh=YWPWwqQkHBcUXVJShx6TFB02q7dRvu1h8sWW3ltEzD0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=SM9u1sQqV3N2l7Pao6Af3949b3MqXPkDtYotvC7WcheOAf7eAkZNeMWtM6zjvFv0Q\n\tPU86HKsDJRiz3ghDubkorBfJ6L1XHFFqeAv3SYo794hgyhR+10mQimHN4CADePlSOF\n\tPLgoN4j6ReOu7kF4u9tOOts1i8SXp6dLlS+yomhA=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"SM9u1sQq\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 12 Dec 2022 20:32:55 +0530", "Message-Id": "<20221212150256.69004-2-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.38.1", "In-Reply-To": "<20221212150256.69004-1-umang.jain@ideasonboard.com>", "References": "<20221212150256.69004-1-umang.jain@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/2] ipa: Move kMaxFrameContexts to mojom\n\tinterface", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Umang Jain via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Umang Jain <umang.jain@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Move kMaxFrameContexts to the mojom interface. This will prepare the\npipeline handler class to manage queuing of requests to the IPA.\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n include/libcamera/ipa/ipu3.mojom | 3 +++\n include/libcamera/ipa/rkisp1.mojom | 3 +++\n src/ipa/ipu3/ipu3.cpp | 3 ---\n src/ipa/rkisp1/rkisp1.cpp | 3 ---\n 4 files changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/include/libcamera/ipa/ipu3.mojom b/include/libcamera/ipa/ipu3.mojom\nindex d1b1c6b8..b1ecd57f 100644\n--- a/include/libcamera/ipa/ipu3.mojom\n+++ b/include/libcamera/ipa/ipu3.mojom\n@@ -8,6 +8,9 @@ module ipa.ipu3;\n \n import \"include/libcamera/ipa/core.mojom\";\n \n+/* Maximum number of frame contexts to be held */\n+const uint32 kMaxFrameContexts = 16;\n+\n struct IPAConfigInfo {\n \tlibcamera.IPACameraSensorInfo sensorInfo;\n \tlibcamera.ControlInfoMap sensorControls;\ndiff --git a/include/libcamera/ipa/rkisp1.mojom b/include/libcamera/ipa/rkisp1.mojom\nindex 1009e970..62c59fbd 100644\n--- a/include/libcamera/ipa/rkisp1.mojom\n+++ b/include/libcamera/ipa/rkisp1.mojom\n@@ -8,6 +8,9 @@ module ipa.rkisp1;\n \n import \"include/libcamera/ipa/core.mojom\";\n \n+/* Maximum number of frame contexts to be held */\n+const uint32 kMaxFrameContexts = 16;\n+\n struct IPAConfigInfo {\n \tlibcamera.IPACameraSensorInfo sensorInfo;\n \tlibcamera.ControlInfoMap sensorControls;\ndiff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex 08ee6eb3..1cfae8fe 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -55,9 +55,6 @@ static constexpr uint32_t kMinCellSizeLog2 = 3;\n /* log2 of the maximum grid cell width and height, in pixels */\n static constexpr uint32_t kMaxCellSizeLog2 = 6;\n \n-/* Maximum number of frame contexts to be held */\n-static constexpr uint32_t kMaxFrameContexts = 16;\n-\n namespace libcamera {\n \n LOG_DEFINE_CATEGORY(IPAIPU3)\ndiff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 6544c925..509be2d3 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -41,9 +41,6 @@ using namespace std::literals::chrono_literals;\n \n namespace ipa::rkisp1 {\n \n-/* Maximum number of frame contexts to be held */\n-static constexpr uint32_t kMaxFrameContexts = 16;\n-\n class IPARkISP1 : public IPARkISP1Interface, public Module\n {\n public:\n", "prefixes": [ "libcamera-devel", "1/2" ] }