Patch Detail
Show a patch.
GET /api/1.1/patches/17962/?format=api
{ "id": 17962, "url": "https://patchwork.libcamera.org/api/1.1/patches/17962/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17962/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221209081937.598303-4-paul.elder@ideasonboard.com>", "date": "2022-12-09T08:19:36", "name": "[libcamera-devel,3/4] tracepoints: request: Add tracepoint for addBuffer", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "fc50f2fc1ecd00136310975299d62bf9af3c91a8", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17962/mbox/", "series": [ { "id": 3662, "url": "https://patchwork.libcamera.org/api/1.1/series/3662/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3662", "date": "2022-12-09T08:19:33", "name": "tracepoints: request: Improve request tracepoints", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3662/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17962/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17962/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AF21FBDE6B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 9 Dec 2022 08:20:03 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 649676335B;\n\tFri, 9 Dec 2022 09:20:03 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1DF946334A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 9 Dec 2022 09:20:01 +0100 (CET)", "from pyrite.tail37cf.ts.net (h175-177-042-159.catv02.itscom.jp\n\t[175.177.42.159])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D31BC480;\n\tFri, 9 Dec 2022 09:19:59 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1670574003;\n\tbh=oe20rhZFpl3g9AudSQQO5z2bf+MKxwrdmpj0h+WVhLI=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=OMPStD3LyqsXIu8yKc0I+FupMoQtraaqVX7OozGfrQB7aLFa/8dKIIXfhGESNhkZL\n\tMkaFn1ECGUYCvhpdUQNIjT84nUTTlPew5yhSyHVbRX/EzDiK8GbZEQPww19PZfLVQ8\n\tr/qtSjbwl67SsUuioPmt2DZO2km9Ka3oE/uYByB5RHEHuaJITWkQd8Y7waknl6wKcK\n\teRAVaoquG6wAe0WQasVlmIyukSLRDi6Wn3W+Xqh7pLZMyTtZKAHelYmuEhoHsjLX+Z\n\tcTEgVFtFGTKLo0gw83VaXFPmbN2j9sYZC0QhYZsjHzUIqQ74XcydzVREnC0uF/exHn\n\tdtf0edH3X42hg==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1670574000;\n\tbh=oe20rhZFpl3g9AudSQQO5z2bf+MKxwrdmpj0h+WVhLI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ulVNaE1WfWIz1xpCB4d/IeEzPgcMzOMILZIWamZ+kGrLPQYUaoLkAjtDE674aC4x5\n\tEteTPLNse6TSanixzE2f5OQuMdo0mx+R3yjt4xVURDlfGuLEPRFzRASJ5goqozLgeR\n\t5ovx8yJo8FOYWwA71zzOjcuO1bxZXP7n6hD4Kkbs=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ulVNaE1W\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 9 Dec 2022 17:19:36 +0900", "Message-Id": "<20221209081937.598303-4-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20221209081937.598303-1-paul.elder@ideasonboard.com>", "References": "<20221209081937.598303-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 3/4] tracepoints: request: Add tracepoint\n\tfor addBuffer", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Paul Elder via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Paul Elder <paul.elder@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a tracepoint event request_add_buffer for tracing\nRequest::addBuffer().\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n include/libcamera/internal/tracepoints/request.tp | 10 ++++++++++\n src/libcamera/request.cpp | 2 ++\n 2 files changed, 12 insertions(+)", "diff": "diff --git a/include/libcamera/internal/tracepoints/request.tp b/include/libcamera/internal/tracepoints/request.tp\nindex 8e7cab5e..29aa3745 100644\n--- a/include/libcamera/internal/tracepoints/request.tp\n+++ b/include/libcamera/internal/tracepoints/request.tp\n@@ -108,6 +108,16 @@ TRACEPOINT_EVENT_INSTANCE(\n \t)\n )\n \n+TRACEPOINT_EVENT_INSTANCE(\n+\tlibcamera,\n+\trequest_with_buffer,\n+\trequest_add_buffer,\n+\tTP_ARGS(\n+\t\tlibcamera::Request::Private *, req,\n+\t\tlibcamera::FrameBuffer *, buf\n+\t)\n+)\n+\n TRACEPOINT_EVENT_INSTANCE(\n \tlibcamera,\n \trequest_with_buffer,\ndiff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex b9fb17d6..ecefba0b 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -462,6 +462,8 @@ void Request::reuse(ReuseFlag flags)\n int Request::addBuffer(const Stream *stream, FrameBuffer *buffer,\n \t\t std::unique_ptr<Fence> fence)\n {\n+\tLIBCAMERA_TRACEPOINT(request_add_buffer, _d(), buffer);\n+\n \tif (!stream) {\n \t\tLOG(Request, Error) << \"Invalid stream reference\";\n \t\treturn -EINVAL;\n", "prefixes": [ "libcamera-devel", "3/4" ] }