Patch Detail
Show a patch.
GET /api/1.1/patches/17923/?format=api
{ "id": 17923, "url": "https://patchwork.libcamera.org/api/1.1/patches/17923/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17923/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221201092733.2042078-2-chenghaoyang@google.com>", "date": "2022-12-01T09:27:28", "name": "[libcamera-devel,v7,1/6] Allow inheritance of FrameBuffer", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "1824248175cc997dd16eac279826e130593ec312", "submitter": { "id": 117, "url": "https://patchwork.libcamera.org/api/1.1/people/117/?format=api", "name": "Cheng-Hao Yang", "email": "chenghaoyang@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17923/mbox/", "series": [ { "id": 3652, "url": "https://patchwork.libcamera.org/api/1.1/series/3652/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3652", "date": "2022-12-01T09:27:27", "name": "Add CrOS JEA implementation", "version": 7, "mbox": "https://patchwork.libcamera.org/series/3652/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17923/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17923/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 253D5BDE6B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 1 Dec 2022 09:27:47 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D376463343;\n\tThu, 1 Dec 2022 10:27:46 +0100 (CET)", "from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com\n\t[IPv6:2607:f8b0:4864:20::42d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 09A6C63335\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 1 Dec 2022 10:27:44 +0100 (CET)", "by mail-pf1-x42d.google.com with SMTP id 140so1324653pfz.6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 01 Dec 2022 01:27:43 -0800 (PST)", "from chenghaoyang-low.c.googlers.com.com\n\t(46.165.189.35.bc.googleusercontent.com. [35.189.165.46])\n\tby smtp.gmail.com with ESMTPSA id\n\tz9-20020a1709027e8900b00186b8752a78sm3108050pla.80.2022.12.01.01.27.41\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 01 Dec 2022 01:27:41 -0800 (PST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1669886866;\n\tbh=aRrFmXPG74P5jR3qMonxndloJ1Z2J/TPA6FbyfrdHlo=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=DIhPTOHl64nvrJPLUvRwyu2dd6737OtPcU+YANoNHD5vVzJ/8hm9fw6s4lWdl97Vo\n\tB2pJjNIiM2l5UMdz82BSccaAxbkAN78/Lz8lYW6H2a6DKP/k2opAfRQnAfhANo2854\n\txeZ5xteKB8KwTDJhB1QMLD+HQGVXCWvlasYXTLGgHwnI3pfgUwCRJigo1miJbCjJ5R\n\tS/zyizF+fiBHNHtsUvnwuL2BT0yEkY1AhVzFJK5iqE4zc3LZNAwqjbZR3utm5nxb6u\n\tSL9QAO8USzOUAJwpWLJtpht9UO/tx8Kf4oVzslkhYDzqTTrNJpou17XK+2ZoBnwUNP\n\thFX/PkzOzfZCw==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=5ODVHMsyA8hsFxgiWC634xNltO+LzlfKNEkD4YkrXuI=;\n\tb=a1ZAAbekUe7Yq3EyeK3z2q3fiQjQa2Qf4MscgwAy9X1hJReJyk4+F9CkoCRKxvOEGZ\n\tNBjjLQxHDYeBET5cHK6wRUmA7GdXQcrgWRVUOfr9SYTW11x6kheHAy6DgMYI8EIOk70f\n\t6tntV4ZLxNz76YJOasH0+PvuXeZQvcZBXowuQ=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=chromium.org\n\theader.i=@chromium.org header.b=\"a1ZAAbek\"; \n\tdkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=5ODVHMsyA8hsFxgiWC634xNltO+LzlfKNEkD4YkrXuI=;\n\tb=j4i6aTrd2dZNz/3+94xAnA49hyQLT6N8V/zIs3InooH8z4n5yVXgv2QlFY2WCRKyNK\n\tQMvF6HOSZYU1GTzY7epBgTLZGbUL1ruN6wmC54bj8NNm/UDNSGC1nItyM8momRgmXQiq\n\tCjwlWqUBXQxX1km3Q70uB1sqqzduEmfWpJf6g+5XAmxx84dwciiVr9PtBavnDK7xIgMR\n\t8xCF4o9KL06IIvf4SJsLSUmR3i7d5lBmspu8NaKqIwg0CIVqf1QUuYwX7j3ED2YMXnbB\n\tm++KOPGx34300/BICYUKN+NicIKdsqOXCLsBoNxt9mDnAGWQwqEG7SJQUgfzVLeSrXBR\n\tHBbg==", "X-Gm-Message-State": "ANoB5pm7msA5T9/a1ux1XCn5m/5zL8PSg3Ryo8OfkMaRh/jAqA3MA25m\n\tQyfYu3ehvTNRqPsFIfcRL7+w9TAEmcyUjg==", "X-Google-Smtp-Source": "AA0mqf58e9hRjN3kq6aCoankmLTfJMpCD6P86T++UlyzrLQRaDG6WLBUpSkiRkHIGuJYJEbSGK2A3Q==", "X-Received": "by 2002:a63:d751:0:b0:46f:f87c:fb1a with SMTP id\n\tw17-20020a63d751000000b0046ff87cfb1amr42794515pgi.214.1669886862230; \n\tThu, 01 Dec 2022 01:27:42 -0800 (PST)", "X-Google-Original-From": "Harvey Yang <chenghaoyang@google.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 1 Dec 2022 09:27:28 +0000", "Message-Id": "<20221201092733.2042078-2-chenghaoyang@google.com>", "X-Mailer": "git-send-email 2.38.1.584.g0f3c55d4c2-goog", "In-Reply-To": "<20221201092733.2042078-1-chenghaoyang@google.com>", "References": "<20221201092733.2042078-1-chenghaoyang@google.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v7 1/6] Allow inheritance of FrameBuffer", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Harvey Yang via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Harvey Yang <chenghaoyang@chromium.org>", "Cc": "Harvey Yang <chenghaoyang@chromium.org>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Harvey Yang <chenghaoyang@chromium.org>\n\nTo add buffer_handle_t access in android, this patch allows inheritance\nof FrameBuffer to add a derived class in android.\n\nSigned-off-by: Harvey Yang <chenghaoyang@chromium.org>\n---\n include/libcamera/framebuffer.h | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/framebuffer.h b/include/libcamera/framebuffer.h\nindex 69553999..61244829 100644\n--- a/include/libcamera/framebuffer.h\n+++ b/include/libcamera/framebuffer.h\n@@ -46,7 +46,7 @@ private:\n \tstd::vector<Plane> planes_;\n };\n \n-class FrameBuffer final : public Extensible\n+class FrameBuffer : public Extensible\n {\n \tLIBCAMERA_DECLARE_PRIVATE()\n \n@@ -60,6 +60,7 @@ public:\n \n \tFrameBuffer(const std::vector<Plane> &planes, unsigned int cookie = 0);\n \tFrameBuffer(std::unique_ptr<Private> d);\n+\tvirtual ~FrameBuffer() {}\n \n \tconst std::vector<Plane> &planes() const;\n \tRequest *request() const;\n", "prefixes": [ "libcamera-devel", "v7", "1/6" ] }