Patch Detail
Show a patch.
GET /api/1.1/patches/17919/?format=api
{ "id": 17919, "url": "https://patchwork.libcamera.org/api/1.1/patches/17919/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17919/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221130105253.12497-1-naush@raspberrypi.com>", "date": "2022-11-30T10:52:53", "name": "[libcamera-devel] ipa: raspberrypi: Fix bug in IPA frame drop logic", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f1ac36e668ef0660120711ef0949597749941e89", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17919/mbox/", "series": [ { "id": 3649, "url": "https://patchwork.libcamera.org/api/1.1/series/3649/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3649", "date": "2022-11-30T10:52:53", "name": "[libcamera-devel] ipa: raspberrypi: Fix bug in IPA frame drop logic", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3649/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17919/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17919/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 29B35BDE6B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 30 Nov 2022 10:53:00 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 73EE36333F;\n\tWed, 30 Nov 2022 11:52:59 +0100 (CET)", "from mail-wr1-x430.google.com (mail-wr1-x430.google.com\n\t[IPv6:2a00:1450:4864:20::430])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 05B4560483\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 30 Nov 2022 11:52:58 +0100 (CET)", "by mail-wr1-x430.google.com with SMTP id bx10so14365577wrb.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 30 Nov 2022 02:52:57 -0800 (PST)", "from naush-laptop.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tbi18-20020a05600c3d9200b003c65c9a36dfsm1412679wmb.48.2022.11.30.02.52.56\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 30 Nov 2022 02:52:56 -0800 (PST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1669805579;\n\tbh=P7gJjTuPpc/uZENO0gNZecQr40pxS2kPMNPwmThHuhs=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=fnAnc/HgMn47Y+dwDSlfcrJTSI1gIZOHckPciVbM/eAmyT1NPPzELtSmHHcg7TvTR\n\td9NpdZLnxIJl5ALhhhbeMxZ4942H81L2ywnOGi8/R73xFCSqJBgt141F6Nl54xisby\n\tnlK4mUppa1rIkcvp27zIdEtVKOd5l+SnudYL7DuPhbRypFPnkRLrNWpuH+flkuR9SE\n\tSORu59xYO9lB35st//3LXlNn5xFdHVEctu4bMQR0T+ynwR+b23eOyjm6HG+2p45yGu\n\tmXECBvdtUE1sQbI3amkTqaj2Viuxiz1GJxutE6+kssppHwXEoTYm9wh/ZPd+vro2sV\n\tD/6+28QprJfuw==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=g7Us5HiP74CZmoDuLqE6ezXblr7oQSvrvtvEwNdiyy8=;\n\tb=cw2YedJrG8PXX+DWxF4YoUV1Oh/YwA5df9fVLRIGawumfXkAJnqAybpMoFdo1XrGKB\n\t8KxaVVYTiHZhuQlzlrESsmOXv4peu8QKTGfFnVzLKZwZkrsRc0PzjLFcmRbJkbHN1+EO\n\tzzmhN7T9UgUHSs90KqDszqmEkICKEea8xOBMK5G9+GIIOgurZQCoIdqDu9k+9B4+OaLO\n\t6kYihW5QZoL5BTHf5DAIr+MbV/t2+QlF7KvDH9Jh5KTP+33HJB70YXT3a/staeoDwf5h\n\th2+Deu8ub5irQoIxtCmMvDVZuXePts0xZcW1oa+1Yu/FGZHGQ7kURPh52efCTqJ02gIB\n\tqoGA==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"cw2YedJr\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=g7Us5HiP74CZmoDuLqE6ezXblr7oQSvrvtvEwNdiyy8=;\n\tb=TaUChhr497wdUuOey/IajMMM0J/8Mw6bgxx/VY41nYK4ho62PJSymy1zatTPYybFTU\n\tTZ0a+BJHV1t9aWi28VcehRbHUp9JA0oI7K6tmHSe4+g5u13H2oMQIbgm7QzI7ck/mXqc\n\tv/oNLN3s0Fw/N6aRzJKCp4udeVvYPxUts+veLX8CAeJaOoQgNv5ylFzeg7wFQqqeC25g\n\tRr0zBYyju2BXlvP6ePdBpMpx+O0qzntTH4BYGiqmhIAG30LaQO2tsg8t3MLQsrP4DSJ3\n\t1tcq/SPW23ZYhd8yVpk9oEbBRVqWqYL/DlJHeb9YYDitEPZ7HRefXmhmhNKKRmAl42sh\n\tJsFw==", "X-Gm-Message-State": "ANoB5plt2NH40aqERj5djZEax8ei9bMEAjkv4Fq2o3Awve3qPydlp0xf\n\tBu3PlodlewdWRUpg1w1VDgJ+XSGxPrKqkw==", "X-Google-Smtp-Source": "AA0mqf5P7a4BdJaSdDhL6MF5X8U+geTz143Jp9ej8wh7cqNVKLFL5bC+eCmPGHFJ/CuJBTsLu1TDTw==", "X-Received": "by 2002:adf:f981:0:b0:242:8c1:601 with SMTP id\n\tf1-20020adff981000000b0024208c10601mr15329144wrr.339.1669805577334; \n\tWed, 30 Nov 2022 02:52:57 -0800 (PST)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 30 Nov 2022 10:52:53 +0000", "Message-Id": "<20221130105253.12497-1-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] ipa: raspberrypi: Fix bug in IPA frame\n\tdrop logic", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Naushir Patuck via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Naushir Patuck <naush@raspberrypi.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Fix a bug in the IPA frame dropping (for rate control) logic, where the\nmetadata for the current context was copied from itself (i.e. a no-op), instead\nof being copied from the previous context.\n\nThis bug does not occur in normal conditions, only when running with a low\nexposure time and unconstrained framerate, which happens in a particular\npicamera2 test.\n\nFixes: 546154b13433 (\"pipeline: ipa: raspberrypi: Use IPA cookies\")\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/ipa/raspberrypi/raspberrypi.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\nindex 0f914f841e54..c0e7540bcd2e 100644\n--- a/src/ipa/raspberrypi/raspberrypi.cpp\n+++ b/src/ipa/raspberrypi/raspberrypi.cpp\n@@ -1062,7 +1062,7 @@ void IPARPi::prepareISP(const ISPConfig &data)\n \t\t * in helper_->Prepare().\n \t\t */\n \t\tRPiController::Metadata &lastMetadata =\n-\t\t\trpiMetadata_[ipaContext ? ipaContext : rpiMetadata_.size()];\n+\t\t\trpiMetadata_[ipaContext ? ipaContext - 1 : rpiMetadata_.size()];\n \t\trpiMetadata.mergeCopy(lastMetadata);\n \t\tprocessPending_ = false;\n \t\treturn;\n", "prefixes": [ "libcamera-devel" ] }