Patch Detail
Show a patch.
GET /api/1.1/patches/179/?format=api
{ "id": 179, "url": "https://patchwork.libcamera.org/api/1.1/patches/179/?format=api", "web_url": "https://patchwork.libcamera.org/patch/179/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190108144621.10546-1-laurent.pinchart@ideasonboard.com>", "date": "2019-01-08T14:46:21", "name": "[libcamera-devel] libcamera: device_enumerator: Fix memory leak in error path", "commit_ref": "824ed85553cf65ba879b03e326c8647619d7ede1", "pull_url": null, "state": "accepted", "archived": false, "hash": "a85d50827c7191f183cf712c41004569afb58715", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/179/mbox/", "series": [ { "id": 59, "url": "https://patchwork.libcamera.org/api/1.1/series/59/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=59", "date": "2019-01-08T14:46:21", "name": "[libcamera-devel] libcamera: device_enumerator: Fix memory leak in error path", "version": 1, "mbox": "https://patchwork.libcamera.org/series/59/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/179/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/179/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A92EE60B2E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 8 Jan 2019 15:45:16 +0100 (CET)", "from avalon.bb.dnainternet.fi\n\t(dfj612ybrt5fhg77mgycy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:2e86:4862:ef6a:2804])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 246B3586\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 8 Jan 2019 15:45:16 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1546958716;\n\tbh=1VXAPpRUEant/goqATXdnurosvpn6lLr8rJrQghbfmU=;\n\th=From:To:Subject:Date:From;\n\tb=ihAmfWtVe7hZdyIEyBJRLM09m1Fr3b2AmEpgetWhqJ5CCmAXhJIqSDhHjVXqLCf8z\n\t3WXa7jN//G/E+r2YsfO/vhDBASqTwpIvVyHUm7LbB5jpQEAcp5VEoq3fQw69waFZpy\n\tshTWjv340+59zxmM/lmQlrxfGxLkv3nYgpyhR5mU=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 8 Jan 2019 16:46:21 +0200", "Message-Id": "<20190108144621.10546-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.19.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: device_enumerator: Fix memory\n\tleak in error path", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 08 Jan 2019 14:45:16 -0000" }, "content": "The DeviceEnumerator::create() function allocates a\nDeviceEnumeratorUdev and fails to delete it in the error path, causing a\nmemory leak. Fix it.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/device_enumerator.cpp | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp\nindex f1d016db64a0..0d18e75525af 100644\n--- a/src/libcamera/device_enumerator.cpp\n+++ b/src/libcamera/device_enumerator.cpp\n@@ -140,6 +140,8 @@ DeviceEnumerator *DeviceEnumerator::create()\n \tif (!enumerator->init())\n \t\treturn enumerator;\n \n+\tdelete enumerator;\n+\n \t/*\n \t * Either udev is not available or udev initialization failed. Fall back\n \t * on the sysfs enumerator.\n", "prefixes": [ "libcamera-devel" ] }