Patch Detail
Show a patch.
GET /api/1.1/patches/17873/?format=api
{ "id": 17873, "url": "https://patchwork.libcamera.org/api/1.1/patches/17873/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17873/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221124113550.2182342-8-paul.elder@ideasonboard.com>", "date": "2022-11-24T11:35:45", "name": "[libcamera-devel,v4,07/12] utils: libtuning: parsers: Add raspberrypi parser", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "22c185a376e7e221d3cd681b9f0bdf7457ee26df", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17873/mbox/", "series": [ { "id": 3636, "url": "https://patchwork.libcamera.org/api/1.1/series/3636/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3636", "date": "2022-11-24T11:35:38", "name": "utils: tuning: Add a new tuning infrastructure", "version": 4, "mbox": "https://patchwork.libcamera.org/series/3636/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17873/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17873/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9A9A0BDE6B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 24 Nov 2022 11:36:17 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5CB106331A;\n\tThu, 24 Nov 2022 12:36:17 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DDEA06331C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 24 Nov 2022 12:36:14 +0100 (CET)", "from pyrite.tail37cf.ts.net (h175-177-042-159.catv02.itscom.jp\n\t[175.177.42.159])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5AFE1BC0;\n\tThu, 24 Nov 2022 12:36:13 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1669289777;\n\tbh=9o/V3AcCFQQCjFd7DyXHh3v+yATuP0jJdvr8p2re2wE=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=EpWfrbgLRJIs3tXqcZKzhUkA//hULHWLO7A+wEK0RCiJaVw8Aj8G9GynzFLO3WTRg\n\t0emnsBzvzPySZsr4EOQRyq1Q2ZomIxBptL7kePLA/7ZUqprvnu40aYbpd9AggRFwS/\n\toFRNLEFcuDmnHVLZV5tLUoX7FeLxWLBqhQm4g5IsYexVwtgM3ETarVpJvMu2wGuxhs\n\tBS6FhN0Y1eGZJyrRXH1aMzraRXOhwVX0Fqq1/U7oBESBokXbKm18vHiFRu+9h6Nmd3\n\tfmyl1fqclruwb6ZVWHy8cPFaA12RsE4ro556xkvNbAE92p3/RY5h/Zwj8aGDHka9Dg\n\t5HjcoTGbdCghA==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1669289774;\n\tbh=9o/V3AcCFQQCjFd7DyXHh3v+yATuP0jJdvr8p2re2wE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=bnYXQ8NC9joMcHGrXKlNkHKDunjmwz1qIeY8I5llwsMvWmxxjxGCqNYHNzmwSOLKP\n\tbxc63AEmd9a00TGXe+AGzeOK9E4Ly1LLHAmdrs8+pSR6h/qUuwrO3enqCyikjW9bRw\n\t4yDAaCZ4No2wTooYK0ao/EGYdH7CzW8kxHyXKbo8=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"bnYXQ8NC\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 24 Nov 2022 20:35:45 +0900", "Message-Id": "<20221124113550.2182342-8-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20221124113550.2182342-1-paul.elder@ideasonboard.com>", "References": "<20221124113550.2182342-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 07/12] utils: libtuning: parsers: Add\n\traspberrypi parser", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Paul Elder via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Paul Elder <paul.elder@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a parser to libtuning for parsing configuration files that are the\nsame format as raspberrypi's ctt's configuration files.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n---\nChanges in v3:\n- style fixes\n- add file description\n- remove indirection from fake polymorphism\n\nChanges in v2:\n- fix python errors\n- fix style\n- add SPDX and copyright\n- don't put black level in the processed config, as raspberrypi ctt's\n config format uses -1 as a magical value to tell ctt to use the value\n from the image, but in our Image loading function it already does, and\n uses this config value to override it if its present\n- Don't validate module config in parser, instead libtuning will do it;\n parser just converts the key from string to module instance\n---\n utils/tuning/libtuning/parsers/__init__.py | 5 +\n .../libtuning/parsers/raspberrypi_parser.py | 93 +++++++++++++++++++\n 2 files changed, 98 insertions(+)\n create mode 100644 utils/tuning/libtuning/parsers/raspberrypi_parser.py", "diff": "diff --git a/utils/tuning/libtuning/parsers/__init__.py b/utils/tuning/libtuning/parsers/__init__.py\nindex e69de29b..9d20d2fc 100644\n--- a/utils/tuning/libtuning/parsers/__init__.py\n+++ b/utils/tuning/libtuning/parsers/__init__.py\n@@ -0,0 +1,5 @@\n+# SPDX-License-Identifier: GPL-2.0-or-later\n+#\n+# Copyright (C) 2022, Paul Elder <paul.elder@ideasonboard.com>\n+\n+from libtuning.parsers.raspberrypi_parser import RaspberryPiParser\ndiff --git a/utils/tuning/libtuning/parsers/raspberrypi_parser.py b/utils/tuning/libtuning/parsers/raspberrypi_parser.py\nnew file mode 100644\nindex 00000000..d26586ba\n--- /dev/null\n+++ b/utils/tuning/libtuning/parsers/raspberrypi_parser.py\n@@ -0,0 +1,93 @@\n+# SPDX-License-Identifier: GPL-2.0-or-later\n+#\n+# Copyright (C) 2022, Paul Elder <paul.elder@ideasonboard.com>\n+#\n+# raspberrypi_parser.py - Parser for Raspberry Pi config file format\n+\n+from .parser import Parser\n+\n+import json\n+import numbers\n+\n+import libtuning.utils as utils\n+\n+\n+class RaspberryPiParser(Parser):\n+ def __init__(self):\n+ super().__init__()\n+\n+ # The string in the 'disable' and 'plot' lists are formatted as\n+ # 'rpi.{module_name}'.\n+ # @brief Enumerate, as a module, @a listt if its value exists in @a dictt\n+ # and it is the name of a valid module in @a modules\n+ def _enumerate_rpi_modules(self, listt, dictt, modules):\n+ for x in listt:\n+ name = x.replace('rpi.', '')\n+ if name not in dictt:\n+ continue\n+ module = utils.get_module_by_typename(modules, name)\n+ if module is not None:\n+ yield module\n+\n+ def _valid_macbeth_option(self, value):\n+ if not isinstance(value, dict):\n+ return False\n+\n+ if list(value.keys()) != ['small', 'show']:\n+ return False\n+\n+ for val in value.values():\n+ if not isinstance(val, numbers.Number):\n+ return False\n+\n+ return True\n+\n+ def parse(self, config_file: str, modules: list) -> (dict, list):\n+ with open(config_file, 'r') as config_json:\n+ config = json.load(config_json)\n+\n+ disable = []\n+ for module in self._enumerate_rpi_modules(config['disable'], config, modules):\n+ disable.append(module)\n+ # Remove the disabled module's config too\n+ config.pop(module.name)\n+ config.pop('disable')\n+\n+ # The raspberrypi config format has 'plot' map to a list of module\n+ # names which should be plotted. libtuning has each module contain the\n+ # plot information in itself so do this conversion.\n+\n+ for module in self._enumerate_rpi_modules(config['plot'], config, modules):\n+ # It's fine to set the value of a potentially disabled module, as\n+ # the object still exists at this point\n+ module.appendValue('debug', 'plot')\n+ config.pop('plot')\n+\n+ # Convert the keys from module name to module instance\n+\n+ new_config = {}\n+\n+ for module_name in config:\n+ module = utils.get_module_by_type_name(modules, module_name)\n+ if module is not None:\n+ new_config[module] = config[module_name]\n+\n+ new_config['general'] = {}\n+\n+ if 'blacklevel' in config:\n+ if not isinstance(config['blacklevel'], numbers.Number):\n+ raise TypeError('Config \"blacklevel\" must be a number')\n+ # Raspberry Pi's ctt config has magic blacklevel value -1 to mean\n+ # \"get it from the image metadata\". Since we already do that in\n+ # Image, don't save it to the config here.\n+ if config['blacklevel'] >= 0:\n+ new_config['general']['blacklevel'] = config['blacklevel']\n+\n+ if 'macbeth' in config:\n+ if not self._valid_macbeth_option(config['macbeth']):\n+ raise TypeError('Config \"macbeth\" must be a dict: {\"small\": number, \"show\": number}')\n+ new_config['general']['macbeth'] = config['macbeth']\n+ else:\n+ new_config['general']['macbeth'] = {'small': 0, 'show': 0}\n+\n+ return new_config, disable\n", "prefixes": [ "libcamera-devel", "v4", "07/12" ] }