Patch Detail
Show a patch.
GET /api/1.1/patches/17756/?format=api
{ "id": 17756, "url": "https://patchwork.libcamera.org/api/1.1/patches/17756/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17756/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221103132041.64644-5-umang.jain@ideasonboard.com>", "date": "2022-11-03T13:20:40", "name": "[libcamera-devel,v3,4/5] v4l2: v4l2_camera_proxy: Apply clang thread safety annotation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "9e308694b374d94700b61e436b84db9c8fd10f8d", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/1.1/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": { "id": 12, "url": "https://patchwork.libcamera.org/api/1.1/users/12/?format=api", "username": "uajain", "first_name": "Umang", "last_name": "Jain", "email": "umang.jain@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/17756/mbox/", "series": [ { "id": 3596, "url": "https://patchwork.libcamera.org/api/1.1/series/3596/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3596", "date": "2022-11-03T13:20:36", "name": "Apply clang thread safety annotation libcamera-core and v4l2", "version": 3, "mbox": "https://patchwork.libcamera.org/series/3596/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17756/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17756/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3DBB9C3286\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 3 Nov 2022 13:21:03 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AFF8B6308A;\n\tThu, 3 Nov 2022 14:21:02 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4871563079\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 3 Nov 2022 14:21:01 +0100 (CET)", "from umang.jainideasonboard.com (unknown [103.251.226.107])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4BF4E4B2;\n\tThu, 3 Nov 2022 14:20:59 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1667481662;\n\tbh=ETmrG/1EA4MoKNRz52ny2k1ELjOzHpDB/vd5CTFpzfA=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=Ru1OA9hY4vRHIU5g+clzlRbiLWJzebX9eQBFQ+pennK86mw6EWziosrcFGYj5olPJ\n\tBUgEf70grFNLEF+KPonKHx/nOY/wqn2XDnv5h+vgMvO7VCiHRywV/uvBGdBlGOVJp6\n\tD7dd8Xx2KkKfa1ipVpZ7Q62OnfWbipOwpUGuCHhZ31aEa3b3g4iS4dDiqVpimO/VW9\n\t1UnhlNWvDRKgeNSfcMG6PnTCvqykHGR1LMHsE0LXFDVtWqp6lJ48iW0wFansXjZcYO\n\tNNrh3XKLS/Klo7VFA2Ut8wD0yzMN6DiVgkW7F7sQdcH0FcdUc02mPm1uKeO9v6rQlR\n\tI8O8NDKzwq7vw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1667481661;\n\tbh=ETmrG/1EA4MoKNRz52ny2k1ELjOzHpDB/vd5CTFpzfA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=kVqHIfUKdmIhuOkmWNuMzvpgadax9wEz4gt8Y5+zOS0SXoep+dggLim9hjsIkLUmw\n\tCiexBRzpWMAGSLbPAz2sxQZlV/SSI4w+kUbsP3hqW3oNeb/URms4eTGQU3d+seTBQi\n\tT2jfYNvBoGt4BrEOuF6ukBOn9XT7KkKkT4UjUwWw=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"kVqHIfUK\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 3 Nov 2022 18:50:40 +0530", "Message-Id": "<20221103132041.64644-5-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.37.3", "In-Reply-To": "<20221103132041.64644-1-umang.jain@ideasonboard.com>", "References": "<20221103132041.64644-1-umang.jain@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 4/5] v4l2: v4l2_camera_proxy: Apply\n\tclang thread safety annotation", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Umang Jain via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Umang Jain <umang.jain@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Hirokazu Honda <hiroh@chromium.org>\n\nThis annotates member functions of V4L2CameraProxy by clang\nthread safety annotations.\n\nSigned-off-by: Hirokazu Honda <hiroh@chromium.org>\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/v4l2/v4l2_camera_proxy.h | 12 +++++++-----\n 1 file changed, 7 insertions(+), 5 deletions(-)", "diff": "diff --git a/src/v4l2/v4l2_camera_proxy.h b/src/v4l2/v4l2_camera_proxy.h\nindex 76ca2d8a..8a0195e1 100644\n--- a/src/v4l2/v4l2_camera_proxy.h\n+++ b/src/v4l2/v4l2_camera_proxy.h\n@@ -27,13 +27,15 @@ class V4L2CameraProxy\n public:\n \tV4L2CameraProxy(unsigned int index, std::shared_ptr<libcamera::Camera> camera);\n \n-\tint open(V4L2CameraFile *file);\n-\tvoid close(V4L2CameraFile *file);\n+\tint open(V4L2CameraFile *file) LIBCAMERA_TSA_EXCLUDES(proxyMutex_);\n+\tvoid close(V4L2CameraFile *file) LIBCAMERA_TSA_EXCLUDES(proxyMutex_);\n \tvoid *mmap(V4L2CameraFile *file, void *addr, size_t length, int prot,\n-\t\t int flags, off64_t offset);\n-\tint munmap(V4L2CameraFile *file, void *addr, size_t length);\n+\t\t int flags, off64_t offset) LIBCAMERA_TSA_EXCLUDES(proxyMutex_);\n+\tint munmap(V4L2CameraFile *file, void *addr, size_t length)\n+\t\tLIBCAMERA_TSA_EXCLUDES(proxyMutex_);\n \n-\tint ioctl(V4L2CameraFile *file, unsigned long request, void *arg);\n+\tint ioctl(V4L2CameraFile *file, unsigned long request, void *arg)\n+\t\tLIBCAMERA_TSA_EXCLUDES(proxyMutex_);\n \n private:\n \tbool validateBufferType(uint32_t type);\n", "prefixes": [ "libcamera-devel", "v3", "4/5" ] }