Patch Detail
Show a patch.
GET /api/1.1/patches/17696/?format=api
{ "id": 17696, "url": "https://patchwork.libcamera.org/api/1.1/patches/17696/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17696/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221027055515.321791-8-nicholas@rothemail.net>", "date": "2022-10-27T05:55:12", "name": "[libcamera-devel,07/10] libcamera: make libdl optional when provided", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "2824cd2c43efbe4028db7916dffbe688716e947d", "submitter": { "id": 97, "url": "https://patchwork.libcamera.org/api/1.1/people/97/?format=api", "name": "Nicolas Dufresne via libcamera-devel", "email": "libcamera-devel@lists.libcamera.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17696/mbox/", "series": [ { "id": 3579, "url": "https://patchwork.libcamera.org/api/1.1/series/3579/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3579", "date": "2022-10-27T05:55:08", "name": "[libcamera-devel,01/10] ipa: workaround libcxx duration limitation", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3579/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17696/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17696/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F0138C3287\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 27 Oct 2022 05:55:32 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7AA0562F7F;\n\tThu, 27 Oct 2022 07:55:32 +0200 (CEST)", "from mail-oa1-x36.google.com (mail-oa1-x36.google.com\n\t[IPv6:2001:4860:4864:20::36])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 58EAB62F7A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 27 Oct 2022 07:55:26 +0200 (CEST)", "by mail-oa1-x36.google.com with SMTP id\n\t586e51a60fabf-13c569e5ff5so290885fac.6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 26 Oct 2022 22:55:26 -0700 (PDT)", "from nroth-pc.attlocal.net\n\t([2600:1700:20:20c0:6406:fc7a:e46d:1666])\n\tby smtp.gmail.com with ESMTPSA id\n\t9-20020a9d0c09000000b00661a05691fasm140021otr.79.2022.10.26.22.55.25\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 26 Oct 2022 22:55:25 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666850132;\n\tbh=DdOeO4Y73eQfxf8oqth1QoKEXEDG56YIYNMB+7UXQco=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=p4K5bkJ3qOPZdfKov3d34VDQOGLeryi96islWnbt6tV3XCDirhWzqUFX+ZL4VIMgu\n\tczQD80/wLaapqUAce1XlL0wY5g7nVDz1F+zPLOVDQ0RZcpgPrhCD7+/nhg9hCGhHrg\n\tUQi41FQzEdZqGb1YymQz82cnIcdc4m4NUEIndKOg9ds3qrPtIPuKW/qYfc3yf8u0On\n\tV4NGvAeE4iKJHaS7ZyIup45CDvDDXUlS+qNVZj/0sApKUUn0YLmqwzz0TjvZz7ocSb\n\tPlTpc8CBgNbPrpJBTRlhvjTB1PRsR3Kih7yu17r/onAVJAEZEVhda+0+zlQkgCqWmC\n\tYnxFuPDVHXJjw==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=rothemail-net.20210112.gappssmtp.com; s=20210112;\n\th=content-transfer-encoding:mime-version:reply-to:references\n\t:in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject\n\t:date:message-id:reply-to;\n\tbh=53GjDLX02zSG1mRkq78FTX8/GBMkyCcDPMdpbL8fvGw=;\n\tb=U5F6oHtfHHXReLZdD4TsWJHW5qbyHVLnmgnNHNPGrPBDddyX/wbbiSssU1X+E5Z6jz\n\t534OAGsaI/O/iQ/ZouR/rY+CLdOk65NfjjOzZLLreoxZ0F+/PNCV1md8AOslARZxbcv8\n\twv1E+woo0gH/RIPCC6PZ5Rac4DIXxOaUGJkVbEZaAnZ0/A4cBcIvHNtl/MjefcAPg8SS\n\tOnnDLThDXtaMXIp8GrSj9lbTHL5rM+Uf8/EWzFXyr90pubc9zcDl4bF6UnHcDm0bEvqD\n\tY2Aepx7BcX8qBCGOs2LGT573gL500mLbhWVZrE4Pa2yXT/KAs5SFMbqTJKDibaidceOf\n\tp9eQ==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=rothemail-net.20210112.gappssmtp.com\n\theader.i=@rothemail-net.20210112.gappssmtp.com header.b=\"U5F6oHtf\"; \n\tdkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:reply-to:references\n\t:in-reply-to:message-id:date:subject:cc:to:from:x-gm-message-state\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=53GjDLX02zSG1mRkq78FTX8/GBMkyCcDPMdpbL8fvGw=;\n\tb=WqDblqgKM5WUJHgqgkj/P1AM6bt/BpX+m1SKmnaJuVtIg6TUCvW8oGlH9VBKHvVZOk\n\t8i29zSRgAubNHZSAcPefr3sZNEwqSblnBSMlL++PAj9qmvsqwrsXfqDwvoMqdlW+wTXh\n\tHuwV0lFb4BSWYmT5LveTuy9dl9diowIMYbsQb7LhQWw1d3/YibyhX3A1pgdk1o1NGuyq\n\tJ7Wnz34GM3sW1O+JmT+fcJlFrczdcvp4fF2bM9ShfPFlz1SnFBCmne+VPdNmomqg9RxY\n\t07xTl3hhExyuTnF3IXJtHDRgAQ+ndcJ/fHHsC8BvO/DBditXEQ6ikfrkS+to0TS+3aY1\n\tBr7Q==", "X-Gm-Message-State": "ACrzQf2dacf2jzhftnnBT/1EYit7bfbPWm0S1hp1Z7LqcbiZnXkYjo/J\n\tlnMjB8q8hAamQ362Jv+FWHbpFKqysXbxAXBR", "X-Google-Smtp-Source": "AMsMyM4kgUGh/dhSChYgqlKX0nIrhVuzlS0ESvw0Y4h3qaq4kzWZwl5pQaUukg9sT3TENigKdjGSLg==", "X-Received": "by 2002:a05:6870:248a:b0:131:8e5d:1bb4 with SMTP id\n\ts10-20020a056870248a00b001318e5d1bb4mr4342459oaq.261.1666850125636; \n\tWed, 26 Oct 2022 22:55:25 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 27 Oct 2022 00:55:12 -0500", "Message-Id": "<20221027055515.321791-8-nicholas@rothemail.net>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20221027055515.321791-1-nicholas@rothemail.net>", "References": "<libcamera Android Enhancements>\n\t<20221027055515.321791-1-nicholas@rothemail.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 07/10] libcamera: make libdl optional when\n\tprovided", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Nicholas Roth via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "libcamera-devel@lists.libcamera.org", "Cc": "nicholas@rothemail.net", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Nicholas Roth <nicholas@rothemail.net>\n\nCurrently, libdl is always required. Sometimes, the C++ runtime includes\na dynamic loader, which is the case for Android. Additionally, Android\n11 does not have libdl. This fix allows libcamera to build on Android.\n\nSigned-off-by: Nicholas Roth <nicholas@rothemail.net>\n---\n src/libcamera/meson.build | 7 ++++++-\n 1 file changed, 6 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\nindex 5f39d2e2..0494e808 100644\n--- a/src/libcamera/meson.build\n+++ b/src/libcamera/meson.build\n@@ -65,7 +65,12 @@ subdir('ipa')\n subdir('pipeline')\n subdir('proxy')\n \n-libdl = cc.find_library('dl')\n+null_dep = dependency('', required : false)\n+\n+libdl = null_dep\n+if not cc.has_function('dlopen')\n+ libdl = cc.find_library('dl')\n+endif\n libudev = dependency('libudev', required : false)\n libyaml = dependency('yaml-0.1', required : false)\n \n", "prefixes": [ "libcamera-devel", "07/10" ] }