Patch Detail
Show a patch.
GET /api/1.1/patches/17680/?format=api
{ "id": 17680, "url": "https://patchwork.libcamera.org/api/1.1/patches/17680/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17680/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221024055543.116040-6-nicholas@rothemail.net>", "date": "2022-10-24T05:55:37", "name": "[libcamera-devel,05/11] Removes references to std::filesystem, which Android 11's toolchain does not support.", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "202ea52dd7559fcfdfe618ec6f53cb7fc743fa4c", "submitter": { "id": 97, "url": "https://patchwork.libcamera.org/api/1.1/people/97/?format=api", "name": "Nicolas Dufresne via libcamera-devel", "email": "libcamera-devel@lists.libcamera.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17680/mbox/", "series": [ { "id": 3575, "url": "https://patchwork.libcamera.org/api/1.1/series/3575/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3575", "date": "2022-10-24T05:55:33", "name": "[libcamera-devel,01/11] Fixes Bug 156, which breaks libcamera on Android < 12.", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3575/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17680/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17680/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0FED0C3285\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 24 Oct 2022 05:55:59 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AB74462F00;\n\tMon, 24 Oct 2022 07:55:58 +0200 (CEST)", "from mail-oa1-x32.google.com (mail-oa1-x32.google.com\n\t[IPv6:2001:4860:4864:20::32])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9AD2362EF8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 24 Oct 2022 07:55:57 +0200 (CEST)", "by mail-oa1-x32.google.com with SMTP id\n\t586e51a60fabf-132fb4fd495so10735627fac.12\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 23 Oct 2022 22:55:57 -0700 (PDT)", "from nroth-pc.attlocal.net\n\t([2600:1700:20:20c0:7bc3:aed3:676f:10a0])\n\tby smtp.gmail.com with ESMTPSA id\n\tx15-20020a9d628f000000b0066193df8edasm3980278otk.34.2022.10.23.22.55.55\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 23 Oct 2022 22:55:55 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666590958;\n\tbh=ttc2WUU+qWMQtvv8fyyaS8hnpNsn8cRPU3hPTKqBV+M=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=qGE9bKulMvxm7qz2qs6umLPcCMw/vunRtXbAyS9eos4Sw/T+rXKVEEq1EuJ5NZHrr\n\twNPGB5fkAktsZlUHbGAu3ZMGdzTTL/w7n9Y0Q8VYGelQgP5s6ku3dvQE/7qcE9TiE3\n\tXlMS2Da/CrZmrCAkCUHnOfCjL7r9feVSVgTuMxD4XhYf4WZvl8E7g0IEwSkr1wZuWy\n\t8Gwbp+b4CzgDZ6bRD/eKcGTwYquwrpQ6aeTmCmsd0kXdgbpS9WtBoUnCXT27bcgMmn\n\tpfW2eGinN+7rHFYV+1rV7gXqx82HXU/gcAyVP9kg08wVYp+JJMTmvMnRnmiaGfPxAm\n\tbcY8zYboJJFfQ==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=rothemail-net.20210112.gappssmtp.com; s=20210112;\n\th=content-transfer-encoding:mime-version:reply-to:references\n\t:in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject\n\t:date:message-id:reply-to;\n\tbh=52KQAlg+dJJpg0sPJRNZtOs43oa4UM3f4Tmy/yyvJu8=;\n\tb=5uKI8BaExIEZAxAcIkIhW46RNqgyYsOkXefUEYGLj9Mt7zEzD2iETbLDmgHNsaL61S\n\tr9Y0VQzbVsuBYAKLcf8ifIXMochRXBfRQ8iTjxh9/jVBKGSxNxLWqEsXSlP461WT5g7H\n\tWBFZsP2NN64fJZH4cAhpQYP1NYGKF7lW1i20QPTj35F9y1G/8RNR59arYLSHgJfy8vbv\n\tQSfOVkbMaHwwwW+WLNI2HV2xf2iaPndDewxk9nKjDCP7cPbYQhub/4yfGcEy7W7F1n5H\n\tRYfrQG/4yXjK7ETH/lC23Lo90EdAUreig7YyYP25M0MSpw+fciXru/ox4/W3PYf9nkbN\n\t05LA==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=rothemail-net.20210112.gappssmtp.com\n\theader.i=@rothemail-net.20210112.gappssmtp.com header.b=\"5uKI8BaE\"; \n\tdkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:reply-to:references\n\t:in-reply-to:message-id:date:subject:cc:to:from:x-gm-message-state\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=52KQAlg+dJJpg0sPJRNZtOs43oa4UM3f4Tmy/yyvJu8=;\n\tb=x5HAIxy+7UGUlehSzP2DOWMUR3/dUTQoHF3avhTJK5ErBcktEHeLQag2n+/rc6nuWH\n\tA+AQ/19140z5YVSoTis3/NuzOFux6W/apV1q2VpvEA7J3b9sBhcReEGC07o0J+K6PR6b\n\tNSDTlLxXbIAiS7hHwuZetx/8mRHSSbk43p/bmH5UCwNqs5n+oYW0xrKDA5WJt8F5FEH0\n\t2KIhEtEH7FAHxZNzyBmwXzKbCWv9rrJhMqCPuCE9aNob1f0rvvpgMvlriFyCQO818ONn\n\til6U+A9q4fWwcdy7smkCbhIMtEUXDE00mAaKU+I1nuSG1m2pI+VxwU2MbrGQff7s00tA\n\tP15g==", "X-Gm-Message-State": "ACrzQf2j/WmXHewzNbzDNLwaSURC5bf8cLJ2EGosGFmn77fl30Iyszuv\n\txcZkaVEEtUGvDnXuzpEBcvom6k5L0g24I8Ya", "X-Google-Smtp-Source": "AMsMyM5owKyCXnwZ8f6+kcek8TmMhklpuyjJdvnoEK9/FSvnDPQl4x97InvkIZyBRVLxygly0oTabw==", "X-Received": "by 2002:a05:6870:b027:b0:136:662d:7cf5 with SMTP id\n\ty39-20020a056870b02700b00136662d7cf5mr37171528oae.110.1666590955940; \n\tSun, 23 Oct 2022 22:55:55 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 24 Oct 2022 00:55:37 -0500", "Message-Id": "<20221024055543.116040-6-nicholas@rothemail.net>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20221024055543.116040-1-nicholas@rothemail.net>", "References": "<20221024055543.116040-1-nicholas@rothemail.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 05/11] Removes references to\n\tstd::filesystem, which Android 11's toolchain does not support.", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Nicholas Roth via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "libcamera-devel@lists.libcamera.org", "Cc": "nicholas@rothemail.net", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Nicholas Roth <nicholas@rothemail.net>\n\n---\n src/android/camera_hal_config.cpp | 9 +--------\n 1 file changed, 1 insertion(+), 8 deletions(-)", "diff": "diff --git a/src/android/camera_hal_config.cpp b/src/android/camera_hal_config.cpp\nindex bacfe4b9..c06c993d 100644\n--- a/src/android/camera_hal_config.cpp\n+++ b/src/android/camera_hal_config.cpp\n@@ -6,7 +6,6 @@\n */\n #include \"camera_hal_config.h\"\n \n-#include <filesystem>\n #include <stdlib.h>\n #include <string>\n \n@@ -160,13 +159,7 @@ CameraHalConfig::CameraHalConfig()\n */\n int CameraHalConfig::parseConfigurationFile()\n {\n-\tstd::filesystem::path filePath = LIBCAMERA_SYSCONF_DIR;\n-\tfilePath /= \"camera_hal.yaml\";\n-\tif (!std::filesystem::is_regular_file(filePath)) {\n-\t\tLOG(HALConfig, Debug)\n-\t\t\t<< \"Configuration file: \\\"\" << filePath << \"\\\" not found\";\n-\t\treturn -ENOENT;\n-\t}\n+\tstd::string filePath = LIBCAMERA_SYSCONF_DIR \"/camera_hal.yaml\";\n \n \tFile file(filePath);\n \tif (!file.open(File::OpenModeFlag::ReadOnly)) {\n", "prefixes": [ "libcamera-devel", "05/11" ] }