Patch Detail
Show a patch.
GET /api/1.1/patches/1767/?format=api
{ "id": 1767, "url": "https://patchwork.libcamera.org/api/1.1/patches/1767/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1767/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190809150459.14421-6-kieran.bingham@ideasonboard.com>", "date": "2019-08-09T15:04:58", "name": "[libcamera-devel,v2,5/6] test: v4l2_device: Remove unused function", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "65a16f3813825f30cd424902400781044b4ad03f", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1767/mbox/", "series": [ { "id": 451, "url": "https://patchwork.libcamera.org/api/1.1/series/451/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=451", "date": "2019-08-09T15:04:53", "name": "V4L2 M2M Support (+RPi PoC)", "version": 2, "mbox": "https://patchwork.libcamera.org/series/451/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1767/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1767/checks/", "tags": {}, "headers": { "Return-Path": "<kieran.bingham@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C11FB6162C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 9 Aug 2019 17:05:05 +0200 (CEST)", "from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5A24152A;\n\tFri, 9 Aug 2019 17:05:05 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1565363105;\n\tbh=2X6LOkjV1oeQqjzvsACZexyPj/58gJBG80N7pcPJOVs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ILcxTnVMM4HIsDpJ/+gRBZNQIIZJ7OBEb/5UEssIsSmO9kQfrRgOY4dtwFsW0IMF9\n\trFzjenmuiqEZWZ8EaXobQtt0R2hxgj5C3z7Pyi+u/fBYz+xTgavpNG01k78K27LOWK\n\tdpoirRACQHkldfOZs+lEYlpHDVMcKlI91J6bYANk=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "LibCamera Devel <libcamera-devel@lists.libcamera.org>", "Date": "Fri, 9 Aug 2019 16:04:58 +0100", "Message-Id": "<20190809150459.14421-6-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190809150459.14421-1-kieran.bingham@ideasonboard.com>", "References": "<20190809150459.14421-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 5/6] test: v4l2_device: Remove unused\n\tfunction", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 09 Aug 2019 15:05:06 -0000" }, "content": "The 'exists()' call is not used within the code base.\nRemove it.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n test/v4l2_videodevice/v4l2_videodevice_test.cpp | 11 -----------\n 1 file changed, 11 deletions(-)", "diff": "diff --git a/test/v4l2_videodevice/v4l2_videodevice_test.cpp b/test/v4l2_videodevice/v4l2_videodevice_test.cpp\nindex b26d06ad4519..b4f4ae672580 100644\n--- a/test/v4l2_videodevice/v4l2_videodevice_test.cpp\n+++ b/test/v4l2_videodevice/v4l2_videodevice_test.cpp\n@@ -6,7 +6,6 @@\n */\n \n #include <iostream>\n-#include <sys/stat.h>\n \n #include \"v4l2_videodevice_test.h\"\n \n@@ -16,16 +15,6 @@\n using namespace std;\n using namespace libcamera;\n \n-bool exists(const std::string &path)\n-{\n-\tstruct stat sb;\n-\n-\tif (stat(path.c_str(), &sb) == 0)\n-\t\treturn true;\n-\n-\treturn false;\n-}\n-\n int V4L2VideoDeviceTest::init()\n {\n \tenumerator_ = DeviceEnumerator::create();\n", "prefixes": [ "libcamera-devel", "v2", "5/6" ] }