Patch Detail
Show a patch.
GET /api/1.1/patches/17646/?format=api
{ "id": 17646, "url": "https://patchwork.libcamera.org/api/1.1/patches/17646/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17646/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221019231537.26880-3-laurent.pinchart@ideasonboard.com>", "date": "2022-10-19T23:15:33", "name": "[libcamera-devel,v1,2/6] qcam: Simplify dependency handling for libtiff", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "42a3f34e56800ee702c653568b57886fb10fcfc8", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17646/mbox/", "series": [ { "id": 3571, "url": "https://patchwork.libcamera.org/api/1.1/series/3571/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3571", "date": "2022-10-19T23:15:31", "name": "apps: Avoid duplicate compilation of common code", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3571/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17646/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17646/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 12F9DC0DA4\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 19 Oct 2022 23:16:10 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B9D6062E71;\n\tThu, 20 Oct 2022 01:16:09 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7D4B962E6E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 20 Oct 2022 01:16:06 +0200 (CEST)", "from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0B4BF570\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 20 Oct 2022 01:16:05 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666221369;\n\tbh=lE+WqI5w4josPytAHH2TvdMCzvVO/4yTMximU3OglRE=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=QYDDOLa/oQNeqyB3iibY8ZxVMDLDDVxTLd6eazVuJY6mYoo3G+Pd2UPd/9yOZ5gwb\n\tOG3D0TTdOFDc7Lzda5ePS3CgeCDtFYFMokXxOJrq+8zPD/J07I9EvY+YrUUF5XFZAE\n\tTyH8puGC3HqHaoHRY80Lx+QxvpPKgfeWqGCdLcZgObLH7/xTPUyWUJAjy8QPjmGMID\n\tT7KsygG5t3LC8VhYufnb4/Dr25vdBgAidIYmvMqFxIfQio1e1UDMPsfAJjIukk4FSv\n\tdqKFyp49txW9nNenCd4SmaQ/89CCx3S7aFcCSDK8cAyow/AolLUTj7H9oi9X0Df4f1\n\trTS6im1im/kaw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1666221366;\n\tbh=lE+WqI5w4josPytAHH2TvdMCzvVO/4yTMximU3OglRE=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=MGO39oFNDg//0uqayUCT/W51C6Ejtsw0SLfgkMjONr3sB0sHNvtEEFOShaF3ZrirK\n\t1hBDBZu9uw7cIuShS3XOkj1F42HRxj3Zf1jY4kPH1JotqeSn8UcvdwmsiWmSTteG4e\n\tTbAAUtYTMjPJbNMVaDX849binglB6TAYMeNz7qEs=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"MGO39oFN\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 20 Oct 2022 02:15:33 +0300", "Message-Id": "<20221019231537.26880-3-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.37.3", "In-Reply-To": "<20221019231537.26880-1-laurent.pinchart@ideasonboard.com>", "References": "<20221019231537.26880-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v1 2/6] qcam: Simplify dependency handling\n\tfor libtiff", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "There's no need to conditionally add tiff_dep to the list of qcam\ndependency, as a not found dependency() is ignored when listed in the\nexecutable dependencies argument.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/qcam/meson.build | 14 ++++++--------\n 1 file changed, 6 insertions(+), 8 deletions(-)", "diff": "diff --git a/src/qcam/meson.build b/src/qcam/meson.build\nindex 9f5759ff0786..d5916d0df532 100644\n--- a/src/qcam/meson.build\n+++ b/src/qcam/meson.build\n@@ -36,18 +36,11 @@ qcam_resources = files([\n 'assets/feathericons/feathericons.qrc',\n ])\n \n-qcam_deps = [\n- libatomic,\n- libcamera_public,\n- qt5_dep,\n-]\n-\n qt5_cpp_args = ['-DQT_NO_KEYWORDS']\n \n tiff_dep = dependency('libtiff-4', required : false)\n if tiff_dep.found()\n qt5_cpp_args += ['-DHAVE_TIFF']\n- qcam_deps += [tiff_dep]\n qcam_sources += files([\n '../cam/dng_writer.cpp',\n ])\n@@ -81,5 +74,10 @@ resources = qt5.preprocess(moc_headers: qcam_moc_headers,\n \n qcam = executable('qcam', qcam_sources, resources,\n install : true,\n- dependencies : qcam_deps,\n+ dependencies : [\n+ libatomic,\n+ libcamera_public,\n+ qt5_dep,\n+ tiff_dep,\n+ ],\n cpp_args : qt5_cpp_args)\n", "prefixes": [ "libcamera-devel", "v1", "2/6" ] }