Patch Detail
Show a patch.
GET /api/1.1/patches/17637/?format=api
{ "id": 17637, "url": "https://patchwork.libcamera.org/api/1.1/patches/17637/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17637/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221019110434.17767-5-laurent.pinchart@ideasonboard.com>", "date": "2022-10-19T11:04:34", "name": "[libcamera-devel,v1,4/4] ipa: rkisp1: Downgrade sensor controls range message to Debug", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ae9bc29d2edf3d217838bee8fdccd8ebd2fc2c36", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17637/mbox/", "series": [ { "id": 3567, "url": "https://patchwork.libcamera.org/api/1.1/series/3567/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3567", "date": "2022-10-19T11:04:30", "name": "ipa: Fill metadata in individual algorithms", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3567/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17637/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17637/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1A033C327C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 19 Oct 2022 11:05:06 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A1FC962E54;\n\tWed, 19 Oct 2022 13:05:05 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 99F1862E4F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 19 Oct 2022 13:05:03 +0200 (CEST)", "from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 051EE5A4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 19 Oct 2022 13:05:02 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666177505;\n\tbh=w/uO32TPgyrtOMKEmrhtHB3yy+UoiiaVEGSrKbYpN9c=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=OjPbb6kp8oJl7cxXdnQPzZqyAmDbXpKH4oQXyTOuQ2ClVrLoV5uAeaiQA/JLAM3ZA\n\tOXN1nEBVXecBOPKN195izHgpgOpH07bhvicEhD7gvxQzMdJNh0vAww145P9lC7/O1V\n\tJSR2IzNxPWQwDXLY4+LrFF5lnkU7I9S0Ab3mSwUcppDiVMnBCR0YCL4rCDNdJZNpJZ\n\tOaZ2vM6S/9qwQc47J5MGl75SFeMd3GPEESokRP+wvPDjF6iFpAmCJa45t+JsO05Wi7\n\trIw46nMqgRBkis1l5E9aG3kJ/X6JDu2bJV0WuQCSD30IenzqUkvyL3Z/nsDsZbuQ0H\n\ttdj6mwj3yNVow==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1666177503;\n\tbh=w/uO32TPgyrtOMKEmrhtHB3yy+UoiiaVEGSrKbYpN9c=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=ebBJMrT+WLyct+igdHBDusSl/ENFcHqhXLj2DTAtGlzM2h4QR1kY1Wn4t+mlTWIpb\n\tFPjVyXQiXyBwJL4UbMrMI7hy/VTD67sBUv/A+lrnRCOb6nwomt2L6+P/N/2T0DIKRZ\n\tHDWCuRy7SPkfYSu4PPOZhD4OnMvX+6LdTEdybnyI=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ebBJMrT+\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 19 Oct 2022 14:04:34 +0300", "Message-Id": "<20221019110434.17767-5-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.37.3", "In-Reply-To": "<20221019110434.17767-1-laurent.pinchart@ideasonboard.com>", "References": "<20221019110434.17767-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v1 4/4] ipa: rkisp1: Downgrade sensor\n\tcontrols range message to Debug", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "There's no need to print the exposure and gain control ranges as an Info\nmessage. Downgrade it to Debug. While at it, print the ranges using the\n\"[min, max]\" syntax.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/rkisp1/rkisp1.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex bef5211d5c34..7dd340cf50af 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -232,9 +232,9 @@ int IPARkISP1::configure([[maybe_unused]] const IPACameraSensorInfo &info,\n \tint32_t minGain = itGain->second.min().get<int32_t>();\n \tint32_t maxGain = itGain->second.max().get<int32_t>();\n \n-\tLOG(IPARkISP1, Info)\n-\t\t<< \"Exposure: \" << minExposure << \"-\" << maxExposure\n-\t\t<< \" Gain: \" << minGain << \"-\" << maxGain;\n+\tLOG(IPARkISP1, Debug)\n+\t\t<< \"Exposure: [\" << minExposure << \", \" << maxExposure\n+\t\t<< \"], gain: [\" << minGain << \", \" << maxGain << \"]\";\n \n \t/* Clear the IPA context before the streaming session. */\n \tcontext_.configuration = {};\n", "prefixes": [ "libcamera-devel", "v1", "4/4" ] }