Patch Detail
Show a patch.
GET /api/1.1/patches/17636/?format=api
{ "id": 17636, "url": "https://patchwork.libcamera.org/api/1.1/patches/17636/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17636/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221019110434.17767-4-laurent.pinchart@ideasonboard.com>", "date": "2022-10-19T11:04:33", "name": "[libcamera-devel,v1,3/4] ipa: rkisp1: Fill AGC and AWB metadata", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f52585aafffc23062771cb80dd597cc8bba14e90", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17636/mbox/", "series": [ { "id": 3567, "url": "https://patchwork.libcamera.org/api/1.1/series/3567/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3567", "date": "2022-10-19T11:04:30", "name": "ipa: Fill metadata in individual algorithms", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3567/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17636/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17636/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 927E9C3285\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 19 Oct 2022 11:05:05 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3628262E5C;\n\tWed, 19 Oct 2022 13:05:05 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4586662E4D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 19 Oct 2022 13:05:02 +0200 (CEST)", "from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D1894903\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 19 Oct 2022 13:05:01 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666177505;\n\tbh=ksLRF+d+U1IaqKh+ZvDg/oD+8BpMphLwSqknnYgGhKw=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=UOG/5I2KMaDb4i56WHdC4smHlFHOCt0TYKrNIKBBbOjH5QNWUqHMU4QNdcklwTw2w\n\tG4/TagzVnpPRIi2mav3yt7IKGX/gkjCEeZph0bwknlUxgQk8/wR4dukb2RvbcRQxg0\n\tM/ONZBhGbYY5A87Fw0vK72ac4xI2g1Kg9IAg9RL01+wBzrEeDHZ3uL3vmBSoPLkdWW\n\trqb3V5KAvtV9lCwl8x+oZIiymiQFnIm2wfLw20xF6edDYliPQ3j+hW+gslcYYy17IX\n\t056hTUxdT9yCOTS9V2GRbfz+bTrz45AiCOCJUEBW2bKT5NuLo1LULmekXTEJzR1+Wq\n\thxXqbk/eRY7qw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1666177502;\n\tbh=ksLRF+d+U1IaqKh+ZvDg/oD+8BpMphLwSqknnYgGhKw=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=i419UL1WAlyUO/mgejSyDKLm8hfyiYK/MQiij+mpRQuIXkpeVq4W/8HtgbvoAd1v5\n\tfcr8vzDLC1wD07mqCHW0g6SKTgBnTQVLeVsJ+jI77n9EhbKkyJi25onBT+oNZQrYrj\n\t5dlQYQHzWHf4DhkUYczKhK1zSK7mGII5HOuLJ1Kg=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"i419UL1W\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 19 Oct 2022 14:04:33 +0300", "Message-Id": "<20221019110434.17767-4-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.37.3", "In-Reply-To": "<20221019110434.17767-1-laurent.pinchart@ideasonboard.com>", "References": "<20221019110434.17767-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v1 3/4] ipa: rkisp1: Fill AGC and AWB\n\tmetadata", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Fill the frame metadata in the AGC and AWB algorithm's prepare()\nfunction. Additional metadata for other algorithms will be addressed\nlater.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/rkisp1/algorithms/agc.cpp | 9 ++++++++-\n src/ipa/rkisp1/algorithms/awb.cpp | 8 +++++++-\n 2 files changed, 15 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\nindex 9de11a2a3bca..a909d8aa59ea 100644\n--- a/src/ipa/rkisp1/algorithms/agc.cpp\n+++ b/src/ipa/rkisp1/algorithms/agc.cpp\n@@ -16,6 +16,8 @@\n \n #include <libcamera/ipa/core_ipa_interface.h>\n \n+#include <libcamera/control_ids.h>\n+\n #include \"libipa/histogram.h\"\n \n /**\n@@ -289,7 +291,7 @@ double Agc::measureBrightness(const rkisp1_cif_isp_hist_stat *hist) const\n */\n void Agc::process(IPAContext &context, [[maybe_unused]] const uint32_t frame,\n \t\t IPAFrameContext &frameContext,\n-\t\t [[maybe_unused]] ControlList &metadata,\n+\t\t ControlList &metadata,\n \t\t const rkisp1_stat_buffer *stats)\n {\n \t/*\n@@ -333,6 +335,11 @@ void Agc::process(IPAContext &context, [[maybe_unused]] const uint32_t frame,\n \n \tcomputeExposure(context, frameContext, yGain, iqMeanGain);\n \tframeCount_++;\n+\n+\tutils::Duration exposureTime = context.configuration.sensor.lineDuration\n+\t\t\t\t * frameContext.sensor.exposure;\n+\tmetadata.set(controls::AnalogueGain, frameContext.sensor.gain);\n+\tmetadata.set(controls::ExposureTime, exposureTime.get<std::micro>());\n }\n \n /**\ndiff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\nindex 9b97db7d5c5a..93888a8e7412 100644\n--- a/src/ipa/rkisp1/algorithms/awb.cpp\n+++ b/src/ipa/rkisp1/algorithms/awb.cpp\n@@ -208,7 +208,7 @@ void Awb::queueRequest(IPAContext &context,\n void Awb::process(IPAContext &context,\n \t\t [[maybe_unused]] const uint32_t frame,\n \t\t IPAFrameContext &frameContext,\n-\t\t [[maybe_unused]] ControlList &metadata,\n+\t\t ControlList &metadata,\n \t\t const rkisp1_stat_buffer *stats)\n {\n \tconst rkisp1_cif_isp_stat *params = &stats->params;\n@@ -307,6 +307,12 @@ void Awb::process(IPAContext &context,\n \n \tframeContext.awb.temperatureK = activeState.awb.temperatureK;\n \n+\tmetadata.set(controls::AwbEnable, frameContext.awb.autoEnabled);\n+\tmetadata.set(controls::ColourGains, {\n+\t\t\tstatic_cast<float>(frameContext.awb.gains.red),\n+\t\t\tstatic_cast<float>(frameContext.awb.gains.blue)\n+\t\t});\n+\n \tLOG(RkISP1Awb, Debug) << std::showpoint\n \t\t<< \"Means [\" << redMean << \", \" << greenMean << \", \" << blueMean\n \t\t<< \"], gains [\" << activeState.awb.gains.automatic.red << \", \"\n", "prefixes": [ "libcamera-devel", "v1", "3/4" ] }