Patch Detail
Show a patch.
GET /api/1.1/patches/17624/?format=api
{ "id": 17624, "url": "https://patchwork.libcamera.org/api/1.1/patches/17624/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17624/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221018231313.2242268-1-kieran.bingham@ideasonboard.com>", "date": "2022-10-18T23:13:13", "name": "[libcamera-devel,IPU3-IPA] ipu3: ipa: Update to latest IPACameraSensorInfo", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "512e9a15fa3c317246784e12fe5a104be7c0b7a0", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17624/mbox/", "series": [ { "id": 3565, "url": "https://patchwork.libcamera.org/api/1.1/series/3565/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3565", "date": "2022-10-18T23:13:13", "name": "[libcamera-devel,IPU3-IPA] ipu3: ipa: Update to latest IPACameraSensorInfo", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3565/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17624/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17624/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F2DC1BD16B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 18 Oct 2022 23:13:21 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2CB7660C15;\n\tWed, 19 Oct 2022 01:13:21 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E5E5F604DC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 19 Oct 2022 01:13:18 +0200 (CEST)", "from Monstersaurus.ksquared.org.uk.beta.tailscale.net\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 52AFA5A4;\n\tWed, 19 Oct 2022 01:13:18 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666134801;\n\tbh=zbuFwqz2tRAl/0Xzb1SXDQnPkkIZ4trQ+aqRS6kzZtE=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=khJynRo0Si8D3b7todnPP8RGkP9adDZWWpCvPjgryVLwyMmp2vNMsGNdzwjDZ+XvA\n\tM7UmRPmrPX0vd1nPX95gAAPF6M4djNyg7ryDM61fbdInyByRLT/7Yp41VwxAIBma+W\n\t5R7j0pgI3J99mwbtGXhLTRpdpxgvxA0/7SN4xPh8jqdxvAUxhmrvw6mQgj2+ghjVgp\n\tvxPXlXtKXbNK4E34cGDONJLPE95/fVJpoN/2amBsMJZEyXUWjHBf+Yp3c1iLAJf4un\n\tk7elSCjXdYiZnS6ERC971SmDKSkpiN3UYK9PPb/57z4WlX30m6zGSpgXXYTzaHJtM5\n\tyaaXv4zOugx1A==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1666134798;\n\tbh=zbuFwqz2tRAl/0Xzb1SXDQnPkkIZ4trQ+aqRS6kzZtE=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=M7QyRKxBpib9U0jH7+iF7bY9lD4V5/v2rgCjAH3C2xIZ8XLAJGFuUeMg1IsMAfAzL\n\trpWhdCIMrcDNzXsepQ/sQnM3JKKtYJz+haJxPbIWyIfsfYCMC+10aokeG9lWrbtY9M\n\tBU9L078aPsefluB7yjH9aB3IWamtsiQPhyt7m3ak=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"M7QyRKxB\"; dkim-atps=neutral", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Wed, 19 Oct 2022 00:13:13 +0100", "Message-Id": "<20221018231313.2242268-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [IPU3-IPA PATCH] ipu3: ipa: Update to latest\n\tIPACameraSensorInfo", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "In libcamera commit e5fc0132f80d (\"camera_sensor: Add minimum and\nmaximum line length to IPACameraSensorInfo\"), the IPU3 IPA interface is\nupdated to provide both minimum and maximum line lengths, replacing the\nexisting lineLenght field.\n\nUpdate the ipu3-ipa to use IPACameraSensorInfo::minLineLength instead of\nIPACameraSensorInfo::lineLength, as logically we will always want to use\nthe fastest sensor readout by default.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n aiq/aiq_input_parameters.cpp | 2 +-\n ipu3.cpp | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/aiq/aiq_input_parameters.cpp b/aiq/aiq_input_parameters.cpp\nindex 7a6a1fac8a37..1639b61b1831 100644\n--- a/aiq/aiq_input_parameters.cpp\n+++ b/aiq/aiq_input_parameters.cpp\n@@ -79,7 +79,7 @@ void AiqInputParameters::reset()\n int AiqInputParameters::configure(const IPAConfigInfo &configInfo)\n {\n \tsensorDescriptor.pixel_clock_freq_mhz = configInfo.sensorInfo.pixelRate / 1000000;\n-\tsensorDescriptor.pixel_periods_per_line = configInfo.sensorInfo.lineLength;\n+\tsensorDescriptor.pixel_periods_per_line = configInfo.sensorInfo.minLineLength;\n \tsensorDescriptor.line_periods_per_field = configInfo.sensorInfo.minFrameLength;\n \tsensorDescriptor.line_periods_vertical_blanking = 106; /* default */\n \t//INFO: fine integration is not supported by v4l2\ndiff --git a/ipu3.cpp b/ipu3.cpp\nindex 7ecd377346f0..f3c65c7c142d 100644\n--- a/ipu3.cpp\n+++ b/ipu3.cpp\n@@ -118,7 +118,7 @@ void IPAIPU3::updateControls(const IPACameraSensorInfo &sensorInfo,\n \t * exposure min, max and default and convert it from lines to\n \t * microseconds.\n \t */\n-\tdouble lineDuration = sensorInfo.lineLength / (sensorInfo.pixelRate / 1e6);\n+\tdouble lineDuration = sensorInfo.minLineLength / (sensorInfo.pixelRate / 1e6);\n \tconst ControlInfo &v4l2Exposure = sensorControls.find(V4L2_CID_EXPOSURE)->second;\n \tint32_t minExposure = v4l2Exposure.min().get<int32_t>() * lineDuration;\n \tint32_t maxExposure = v4l2Exposure.max().get<int32_t>() * lineDuration;\n", "prefixes": [ "libcamera-devel", "IPU3-IPA" ] }