Patch Detail
Show a patch.
GET /api/1.1/patches/17620/?format=api
{ "id": 17620, "url": "https://patchwork.libcamera.org/api/1.1/patches/17620/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17620/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221018080908.2841339-4-paul.elder@ideasonboard.com>", "date": "2022-10-18T08:09:08", "name": "[libcamera-devel,v2,3/3] cam: dng_writer: Add support for 8-bit raw formats", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ce40a05d207507d3946551ee2263b374d72fb1aa", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17620/mbox/", "series": [ { "id": 3561, "url": "https://patchwork.libcamera.org/api/1.1/series/3561/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3561", "date": "2022-10-18T08:09:05", "name": "cam: Add DNG support", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3561/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17620/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17620/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8EA5FBD16B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 18 Oct 2022 08:09:23 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 46FAD62E1A;\n\tTue, 18 Oct 2022 10:09:23 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2FA1662E19\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 18 Oct 2022 10:09:22 +0200 (CEST)", "from pyrite.rasen.tech (h175-177-042-159.catv02.itscom.jp\n\t[175.177.42.159])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ACE69AF2;\n\tTue, 18 Oct 2022 10:09:20 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666080563;\n\tbh=jiR7pmW81e7tnDg6TeUsJLBOTbHn/E+BmMeey25UKFQ=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=tqDZAJ1YLh3HSvPn6XU6DY6ar9pPmUvqGMXT6iSXHSC4cyhZYkZbvEzoQYRbkbjSB\n\ttaF8+DL7R2epkD10+sZv2t/12H/yTFmF5cDoYsWlrLUZw0dRXTOrTle35Gi0lHw7Fn\n\tp1qb2LRC+7SAGJyg2YRAI0m+eD+n8zGkczoUTQJIOmzgloTfRqgNFtcddLxda7YLJT\n\tP8/zdahUw7SW3SQ5UI/3tj8IKa/G7j395pKOwSq6aovHC9bS2MnbhZjJTChDQvuiC6\n\tRxY6FM7SNIkjd0gODrLoCjWIOlJeH1vBtkmXmKKbU4iXW4xSGNnDNoUudkP+YxBDr2\n\tBjlE51SyvQrrA==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1666080561;\n\tbh=jiR7pmW81e7tnDg6TeUsJLBOTbHn/E+BmMeey25UKFQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=IxlmLXND1+JC7olZPvn+Ugdy1SnlcS8Ki2KBoqM/dx7fuXDgWDpQ8Gt8tesxvNcDW\n\t9VkLdTn5EdIXy7UMI+hAZ/SfNbqJ5IOPNGI+mE2lZtMncHxkE/sUrn3eJXPGrI7QVk\n\tvHXpqtGShV9e/HmECekOHjIVUZnB/nExONhF/ioY=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"IxlmLXND\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 18 Oct 2022 17:09:08 +0900", "Message-Id": "<20221018080908.2841339-4-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20221018080908.2841339-1-paul.elder@ideasonboard.com>", "References": "<20221018080908.2841339-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 3/3] cam: dng_writer: Add support for\n\t8-bit raw formats", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Paul Elder via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Paul Elder <paul.elder@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add support for 8-bit raw formats in DNGWriter.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n---\nChanges in v2:\n- replace copy loop with std::copy\n---\n src/cam/dng_writer.cpp | 32 ++++++++++++++++++++++++++++++++\n 1 file changed, 32 insertions(+)", "diff": "diff --git a/src/cam/dng_writer.cpp b/src/cam/dng_writer.cpp\nindex 6dd7d0f4..c945edce 100644\n--- a/src/cam/dng_writer.cpp\n+++ b/src/cam/dng_writer.cpp\n@@ -126,6 +126,14 @@ struct Matrix3d {\n \tfloat m[9];\n };\n \n+void packScanlineSBGGR8(void *output, const void *input, unsigned int width)\n+{\n+\tconst uint8_t *in = static_cast<const uint8_t *>(input);\n+\tuint8_t *out = static_cast<uint8_t *>(output);\n+\n+\tstd::copy(in, in + width, out);\n+}\n+\n void packScanlineSBGGR10P(void *output, const void *input, unsigned int width)\n {\n \tconst uint8_t *in = static_cast<const uint8_t *>(input);\n@@ -274,6 +282,30 @@ void thumbScanlineIPU3([[maybe_unused]] const FormatInfo &info, void *output,\n }\n \n static const std::map<PixelFormat, FormatInfo> formatInfo = {\n+\t{ formats::SBGGR8, {\n+\t\t.bitsPerSample = 8,\n+\t\t.pattern = { CFAPatternBlue, CFAPatternGreen, CFAPatternGreen, CFAPatternRed },\n+\t\t.packScanline = packScanlineSBGGR8,\n+\t\t.thumbScanline = thumbScanlineSBGGRxxP,\n+\t} },\n+\t{ formats::SGBRG8, {\n+\t\t.bitsPerSample = 8,\n+\t\t.pattern = { CFAPatternGreen, CFAPatternBlue, CFAPatternRed, CFAPatternGreen },\n+\t\t.packScanline = packScanlineSBGGR8,\n+\t\t.thumbScanline = thumbScanlineSBGGRxxP,\n+\t} },\n+\t{ formats::SGRBG8, {\n+\t\t.bitsPerSample = 8,\n+\t\t.pattern = { CFAPatternGreen, CFAPatternRed, CFAPatternBlue, CFAPatternGreen },\n+\t\t.packScanline = packScanlineSBGGR8,\n+\t\t.thumbScanline = thumbScanlineSBGGRxxP,\n+\t} },\n+\t{ formats::SRGGB8, {\n+\t\t.bitsPerSample = 8,\n+\t\t.pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n+\t\t.packScanline = packScanlineSBGGR8,\n+\t\t.thumbScanline = thumbScanlineSBGGRxxP,\n+\t} },\n \t{ formats::SBGGR10_CSI2P, {\n \t\t.bitsPerSample = 10,\n \t\t.pattern = { CFAPatternBlue, CFAPatternGreen, CFAPatternGreen, CFAPatternRed },\n", "prefixes": [ "libcamera-devel", "v2", "3/3" ] }