Patch Detail
Show a patch.
GET /api/1.1/patches/17618/?format=api
{ "id": 17618, "url": "https://patchwork.libcamera.org/api/1.1/patches/17618/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17618/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221018080908.2841339-2-paul.elder@ideasonboard.com>", "date": "2022-10-18T08:09:06", "name": "[libcamera-devel,v2,1/3] qcam, cam: Move DNGWriter from qcam to cam", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "b51e6fff81284046e6e85bb9069d825f18a7c549", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17618/mbox/", "series": [ { "id": 3561, "url": "https://patchwork.libcamera.org/api/1.1/series/3561/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3561", "date": "2022-10-18T08:09:05", "name": "cam: Add DNG support", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3561/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17618/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17618/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7223BBD16B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 18 Oct 2022 08:09:21 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 351D362E15;\n\tTue, 18 Oct 2022 10:09:21 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 221AA62E0A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 18 Oct 2022 10:09:19 +0200 (CEST)", "from pyrite.rasen.tech (h175-177-042-159.catv02.itscom.jp\n\t[175.177.42.159])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 53DF88CC;\n\tTue, 18 Oct 2022 10:09:17 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666080561;\n\tbh=JLIwmHpQIQCHjajdYrsUTAxrw7JtDh6lLXhvj40CkeE=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=c0qsTLWrSL6J5b2JDmCYpJYAJ9C7VaAJNcOTcpYTdpxAnr+jLKhLEXKxVGol+dczg\n\t/iWIfRVMv2UrCzuM34JqY5eOlVjGoP6g82QB7WLO86tmKLEzI0vWk/IUGu6btrXWPH\n\tLikdFCsKyrwyFH5pbj3gOlBEc/WXD8dla+7upH/xWqZI0wkpuo5+r4PTcot88kM7V7\n\ti5c3mPwnOZh3cCEZ1Lo585CeJgaiD4apbMEtHQW3s4OS+WEa2emql/RrDq4/w+v7Lb\n\tZDAhtgbXsN0muYLJwBYune1Ecplg9fiAD+Zqn/Y1uM439yXuwq9wnXykz+8OLRfRwd\n\tKCZW2ZXhKQJ4Q==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1666080558;\n\tbh=JLIwmHpQIQCHjajdYrsUTAxrw7JtDh6lLXhvj40CkeE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=r70t/NNWxRawsPBDj9R7MkicYDk0rL1W0G9r0sy1t3pAjpIjqdXwNravgVhdSZzUg\n\ti7UT1NUjkWnUsDOPf1uHFvcl0I2TZaUSJMCJ7pB8QH0tGnIVmnTr4x5pP2SPZVETle\n\tCeO+b003wMcFW3uKvS23vGPngsu4ls5T58bots2k=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"r70t/NNW\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 18 Oct 2022 17:09:06 +0900", "Message-Id": "<20221018080908.2841339-2-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20221018080908.2841339-1-paul.elder@ideasonboard.com>", "References": "<20221018080908.2841339-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 1/3] qcam,\n\tcam: Move DNGWriter from qcam to cam", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Paul Elder via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Paul Elder <paul.elder@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "To prepare for adding DNG support to cam, move DNGWriter from qcam to\ncam so that we only have inclusions from qcam to cam and not the other\nway around.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n---\nChanges in v2:\n- move libtiff dependency for cam to the next patch\n---\n src/{qcam => cam}/dng_writer.cpp | 0\n src/{qcam => cam}/dng_writer.h | 0\n src/cam/meson.build | 1 +\n src/qcam/main_window.cpp | 2 +-\n src/qcam/meson.build | 2 +-\n 5 files changed, 3 insertions(+), 2 deletions(-)\n rename src/{qcam => cam}/dng_writer.cpp (100%)\n rename src/{qcam => cam}/dng_writer.h (100%)", "diff": "diff --git a/src/qcam/dng_writer.cpp b/src/cam/dng_writer.cpp\nsimilarity index 100%\nrename from src/qcam/dng_writer.cpp\nrename to src/cam/dng_writer.cpp\ndiff --git a/src/qcam/dng_writer.h b/src/cam/dng_writer.h\nsimilarity index 100%\nrename from src/qcam/dng_writer.h\nrename to src/cam/dng_writer.h\ndiff --git a/src/cam/meson.build b/src/cam/meson.build\nindex 8259239f..9c766221 100644\n--- a/src/cam/meson.build\n+++ b/src/cam/meson.build\n@@ -26,6 +26,7 @@ cam_cpp_args = []\n libdrm = dependency('libdrm', required : false)\n libjpeg = dependency('libjpeg', required : false)\n libsdl2 = dependency('SDL2', required : false)\n+libtiff = dependency('libtiff-4', required : false)\n \n if libdrm.found()\n cam_cpp_args += [ '-DHAVE_KMS' ]\ndiff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\nindex e0e5092e..f553ccb0 100644\n--- a/src/qcam/main_window.cpp\n+++ b/src/qcam/main_window.cpp\n@@ -26,10 +26,10 @@\n #include <QToolButton>\n #include <QtDebug>\n \n+#include \"../cam/dng_writer.h\"\n #include \"../cam/image.h\"\n \n #include \"cam_select_dialog.h\"\n-#include \"dng_writer.h\"\n #ifndef QT_NO_OPENGL\n #include \"viewfinder_gl.h\"\n #endif\ndiff --git a/src/qcam/meson.build b/src/qcam/meson.build\nindex 61861ea6..9f5759ff 100644\n--- a/src/qcam/meson.build\n+++ b/src/qcam/meson.build\n@@ -49,7 +49,7 @@ if tiff_dep.found()\n qt5_cpp_args += ['-DHAVE_TIFF']\n qcam_deps += [tiff_dep]\n qcam_sources += files([\n- 'dng_writer.cpp',\n+ '../cam/dng_writer.cpp',\n ])\n endif\n \n", "prefixes": [ "libcamera-devel", "v2", "1/3" ] }