Patch Detail
Show a patch.
GET /api/1.1/patches/17530/?format=api
{ "id": 17530, "url": "https://patchwork.libcamera.org/api/1.1/patches/17530/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17530/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221005154042.7302-1-laurent.pinchart@ideasonboard.com>", "date": "2022-10-05T15:40:42", "name": "[libcamera-devel,v2] test: threads: Fix link failure due to missing dependency", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "294d616ab215f1b6343c48cbae235b82c4750895", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17530/mbox/", "series": [ { "id": 3534, "url": "https://patchwork.libcamera.org/api/1.1/series/3534/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3534", "date": "2022-10-05T15:40:42", "name": "[libcamera-devel,v2] test: threads: Fix link failure due to missing dependency", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3534/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17530/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17530/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1D617C0DA4\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 5 Oct 2022 15:40:49 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5C65862CB1;\n\tWed, 5 Oct 2022 17:40:48 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 892D6601C7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 5 Oct 2022 17:40:46 +0200 (CEST)", "from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D3F24415;\n\tWed, 5 Oct 2022 17:40:45 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664984448;\n\tbh=YnZ6kHfxbrNtbGZ0j+Xyq9uzML3/5k3QhtvjNtva3qs=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=oEPy3Byss8fbpr/hLSVp724OImYAIbrpvbhLSM6IZ4fO77RoFf0m3keO1cZcIR1oM\n\trTtopobnLmqkOSGLMLNzpRNnwiTK3W0fPWI/zsUz1HV+stW+bsW+oCUIl/ykmsFcQm\n\tvWmjAXDmeBvKpvkwB4MVfhHpMWwukW3ppzKjm+zVxNFkLqo0Icw4WvoxVM9nvVBLJ1\n\tin6Gr0HiT9NbWFgUEotZ3/tcTzDnZw+FhzEod0gKL0T1qRVRWkZNFE7eRdDNNZBbmV\n\tZ6IN43ASxBx5JPQnHlsjckSU1B7lebs35f0EBBLfUSzoF5ANoyv/Pp+EuPkuL557HA\n\tqq0d5JOqFTElA==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1664984446;\n\tbh=YnZ6kHfxbrNtbGZ0j+Xyq9uzML3/5k3QhtvjNtva3qs=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=quFfWRLVlaFIgvYWi7mCHuXnL8+7nr0eshQ8VeuCW73UKlsb5E+wKCbsr8oBZU+pj\n\tYjGscN0xffmWR4TgS7o/qbMOQihU5mEcR5j3qJYdVptxZbhE14U7/3rp2LKkCs6vE5\n\tvnWUrBm50OdJo9Cgs27kqK055ApoMLwNsc11dPdw=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"quFfWRLV\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 5 Oct 2022 18:40:42 +0300", "Message-Id": "<20221005154042.7302-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2] test: threads: Fix link failure due to\n\tmissing dependency", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Commit 036d26d6677e (\"test: threads: Test thread cleanup upon abnormal\ntermination\") added calls to functions provided by the pthread library\nin the threads test, but didn't add the corresponding dependency. This\ncaused a link breakage on some platforms:\n\n/usr/bin/ld: test/threads.p/threads.cpp.o: undefined reference to symbol 'pthread_cancel@@GLIBC_2.4'\n/usr/bin/ld: /lib/arm-linux-gnueabihf/libpthread.so.0: error adding symbols: DSO missing from command line\ncollect2: error: ld returned 1 exit status\n\nThe threads test binary needs to be linked with the pthread library. To\nkeep meson.build simple, link all internal tests to pthread\nunconditionally.\n\nFixes: 036d26d6677e (\"test: threads: Test thread cleanup upon abnormal termination\")\nReported-by: Naushir Patuck <naush@raspberrypi.com>\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Naushir Patuck <naush@raspberrypi.com>\nTested-by: Naushir Patuck <naush@raspberrypi.com>\n---\nBy popular request, a simplified version. I personally think it's much\nmore of a quick & dirty solution than v1, which I still prefer over v2.\n---\n src/libcamera/base/meson.build | 2 +-\n src/libcamera/meson.build | 1 +\n test/meson.build | 2 +-\n 3 files changed, 3 insertions(+), 2 deletions(-)\n\n\nbase-commit: 487989eec64aa9f57f39b3bdcf619a5d435efac6", "diff": "diff --git a/src/libcamera/base/meson.build b/src/libcamera/base/meson.build\nindex 3b9d74efe935..7a75914ab2a8 100644\n--- a/src/libcamera/base/meson.build\n+++ b/src/libcamera/base/meson.build\n@@ -38,9 +38,9 @@ if libunwind.found()\n endif\n \n libcamera_base_deps = [\n- dependency('threads'),\n libatomic,\n libdw,\n+ libthreads,\n libunwind,\n ]\n \ndiff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\nindex 63b47b177fd2..7fcbb2ddc9e7 100644\n--- a/src/libcamera/meson.build\n+++ b/src/libcamera/meson.build\n@@ -58,6 +58,7 @@ includes = [\n ]\n \n libatomic = cc.find_library('atomic', required : false)\n+libthreads = dependency('threads')\n \n subdir('base')\n subdir('ipa')\ndiff --git a/test/meson.build b/test/meson.build\nindex 6cc778415dc8..f39f537035be 100644\n--- a/test/meson.build\n+++ b/test/meson.build\n@@ -75,7 +75,7 @@ endforeach\n \n foreach t : internal_tests\n exe = executable(t[0], t[1],\n- dependencies : libcamera_private,\n+ dependencies : [libcamera_private, libthreads],\n link_with : test_libraries,\n include_directories : test_includes_internal)\n \n", "prefixes": [ "libcamera-devel", "v2" ] }