Patch Detail
Show a patch.
GET /api/1.1/patches/17486/?format=api
{ "id": 17486, "url": "https://patchwork.libcamera.org/api/1.1/patches/17486/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17486/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221002003612.13603-5-laurent.pinchart@ideasonboard.com>", "date": "2022-10-02T00:36:12", "name": "[libcamera-devel,4/4] pipeline: rkisp1: Set bytesused before queuing parameters buffer", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "ac68e7764b6741719618c3a0343311469c18e5ba", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17486/mbox/", "series": [ { "id": 3522, "url": "https://patchwork.libcamera.org/api/1.1/series/3522/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3522", "date": "2022-10-02T00:36:08", "name": "libcamera: Fix kernel deprecation warning with output buffers", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3522/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17486/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17486/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0922AC327E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 2 Oct 2022 00:36:22 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 97AC662CBF;\n\tSun, 2 Oct 2022 02:36:21 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 596A062CB7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 2 Oct 2022 02:36:19 +0200 (CEST)", "from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DB2E8517\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 2 Oct 2022 02:36:18 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664670981;\n\tbh=wuvYJnxWqiRujtRNfHqpvwzxadfbuedvqw+B/SOF460=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=j7vmuYGHFHBg0MdvxLE4EieYhSYzpNBK32IyvA+x3zzbDPjNo97fFf3k4z2+zICeG\n\tDaOhS7ZVH5eDI1BnPMVE+CczEY9NdjX0tABr+6u9Z9HGDJDi3si1ql4eUfti/6SszC\n\tXe2M46sINVaoHlQ7aT/xW7hYhCwW2dIuoPrkoRdDwQg97TgRzXCd5ztgB1apPe7lOB\n\tgrlV05o9K8rEIzY/qgnhEASIyE8ldB32S04dQGWaAewEenZ3ze4enU7Vy598NYjDYR\n\tztoHh6FPPOngOG3wUF6Qg00Ng4O+9W0AgiPc4GSX0P+NbAPwaGsN7MqFJsMZ4t2NMx\n\txIiGE/ZayWhVw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1664670979;\n\tbh=wuvYJnxWqiRujtRNfHqpvwzxadfbuedvqw+B/SOF460=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=SZmFRFKyKz74I9D6oWVcIMCdWvaA4WiTLB8sj8/BosHe+s7zFHa39gU3v4Se9KsyX\n\ts+90HSlI4Z1f6iP+nJx2VyTBpNPgJEjPsKkEAD/9RsUmAV+FWh6/lz+MtA15adOhf3\n\t2XumSvtLVUP/oM3oORA6JbA5ZKnzeLFpv32FljeU=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"SZmFRFKy\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 2 Oct 2022 03:36:12 +0300", "Message-Id": "<20221002003612.13603-5-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20221002003612.13603-1-laurent.pinchart@ideasonboard.com>", "References": "<20221002003612.13603-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 4/4] pipeline: rkisp1: Set bytesused\n\tbefore queuing parameters buffer", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The bytesused value for the parameters buffer is initialized to 0 and\nnever set. The V4L2 API specification indicates that, for an output\nvideo device, the driver will set the bytesused value to the size of the\nplane in that case. The videobuf2 framework does so, but considers this\nas deprecated and prints a warning:\n\n[ 54.375534] use of bytesused == 0 is deprecated and will be removed in the future,\n[ 54.388026] use the actual size instead.\n\nFix it by setting bytesused to the correct value before queuing the\nparameters buffer.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 4 ++++\n 1 file changed, 4 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 25fbf9f1a0a9..455ee2a0a711 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -13,6 +13,7 @@\n #include <queue>\n \n #include <linux/media-bus-format.h>\n+#include <linux/rkisp1-config.h>\n \n #include <libcamera/base/log.h>\n #include <libcamera/base/utils.h>\n@@ -32,6 +33,7 @@\n #include \"libcamera/internal/camera_sensor.h\"\n #include \"libcamera/internal/delayed_controls.h\"\n #include \"libcamera/internal/device_enumerator.h\"\n+#include \"libcamera/internal/framebuffer.h\"\n #include \"libcamera/internal/ipa_manager.h\"\n #include \"libcamera/internal/media_device.h\"\n #include \"libcamera/internal/pipeline_handler.h\"\n@@ -362,6 +364,8 @@ void RkISP1CameraData::paramFilled(unsigned int frame)\n \tif (!info)\n \t\treturn;\n \n+\tinfo->paramBuffer->_d()->metadata().planes()[0].bytesused =\n+\t\tsizeof(struct rkisp1_params_cfg);\n \tpipe->param_->queueBuffer(info->paramBuffer);\n \tpipe->stat_->queueBuffer(info->statBuffer);\n \n", "prefixes": [ "libcamera-devel", "4/4" ] }