Patch Detail
Show a patch.
GET /api/1.1/patches/17475/?format=api
{ "id": 17475, "url": "https://patchwork.libcamera.org/api/1.1/patches/17475/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17475/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220930190821.4100474-1-kieran.bingham@ideasonboard.com>", "date": "2022-09-30T19:08:21", "name": "[libcamera-devel] ipa: ipu3: Correct context during configure()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e89421f25d39c63e13826c30c56881777ecfa3cd", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17475/mbox/", "series": [ { "id": 3520, "url": "https://patchwork.libcamera.org/api/1.1/series/3520/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3520", "date": "2022-09-30T19:08:21", "name": "[libcamera-devel] ipa: ipu3: Correct context during configure()", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3520/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17475/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17475/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 68859BD16B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 30 Sep 2022 19:08:30 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 203AC6283F;\n\tFri, 30 Sep 2022 21:08:30 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5CD6761FB1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 30 Sep 2022 21:08:28 +0200 (CEST)", "from Monstersaurus.local\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0508547C;\n\tFri, 30 Sep 2022 21:08:27 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664564910;\n\tbh=EuH9q31nhheLGrG8SQX11sav4/CmZu0h4aKbs21g0mQ=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=ZWJ3793/OIgis1KKpv4ce8z7BrPMvMRS5sTsmWNLElw9by7vXC3/Ilsk0dzQxx7eG\n\tJQU5lvsvvZ7BpBmHNqK+PDZ1fbXKm10oGL7lsu9sMdLfeBjwyO2LjHE/BLrxTfKFqj\n\tEQfup3Ibk0awwB0b4RB3yx99tfmUIND4WCVQ9sxdm84lYBqsSA96eN83nTZjZOw1jp\n\tGjBqRdC+nJITrEjsaHHf57TQ75gEpijdw3Fz61M7/CaKjy7nY7E1wfr4maCpzEPNba\n\taqyxTsuHSEyGfoO7RcwOJpleWPX+sEIiNpxfj2jcMEAePCYSwHpsLajeBRuVjOdxd2\n\tw19S7noqFYbxg==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1664564908;\n\tbh=EuH9q31nhheLGrG8SQX11sav4/CmZu0h4aKbs21g0mQ=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=Ik9k44opsmMXiCu6Hx1S4+bm8ec83OfQ3GjNXK0cezBeuWryTrnGyNg24I7j3V+qE\n\tihhZvOg82lWCrgZdimdg2gc6mf2LPLph746tmuD7m03c+WZ8ESQ7TrDGs5T9EQRHA3\n\tV0wKEActoY1o+VDl3H4y61BM3VpaboSFALRuFXkw=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Ik9k44op\"; dkim-atps=neutral", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Fri, 30 Sep 2022 20:08:21 +0100", "Message-Id": "<20220930190821.4100474-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] ipa: ipu3: Correct context during\n\tconfigure()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The introduction of the FCQueue in the IPU3 inadvertently introduced a\nbug which cleared the initialisation of the session configuration\nimmediately after some parameters had been set.\n\nFurthermore, it cleared and never re-initialised the sensor line\nduration property, which was previously only set during the call to\ninit().\n\nMove the clearing of the contexts from the updateSessionConfiguration()\ncall to the earliest opportunity in configure(), and immediately\nre-initialise the sensor parameters.\n\nBug: https://bugs.libcamera.org/show_bug.cgi?id=151\nFixes: 85c5c47325ab (\"ipa: ipu3: Use the FCQueue\")\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/ipa/ipu3/ipu3.cpp | 13 ++++++++-----\n 1 file changed, 8 insertions(+), 5 deletions(-)", "diff": "diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex d1ea081d595d..7fb62c749fde 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -217,11 +217,6 @@ void IPAIPU3::updateSessionConfiguration(const ControlInfoMap &sensorControls)\n \tint32_t minGain = v4l2Gain.min().get<int32_t>();\n \tint32_t maxGain = v4l2Gain.max().get<int32_t>();\n \n-\t/* Clear the IPA context before the streaming session. */\n-\tcontext_.configuration = {};\n-\tcontext_.activeState = {};\n-\tcontext_.frameContexts.clear();\n-\n \t/*\n \t * When the AGC computes the new exposure values for a frame, it needs\n \t * to know the limits for shutter speed and analogue gain.\n@@ -498,6 +493,14 @@ int IPAIPU3::configure(const IPAConfigInfo &configInfo,\n \n \tlensCtrls_ = configInfo.lensControls;\n \n+\t/* Clear the IPA context for the new streaming session. */\n+\tcontext_.activeState = {};\n+\tcontext_.configuration = {};\n+\tcontext_.frameContexts.clear();\n+\n+\t/* Intialise the sensor configuration */\n+\tcontext_.configuration.sensor.lineDuration = sensorInfo_.lineLength * 1.0s / sensorInfo_.pixelRate;\n+\n \t/*\n \t * Compute the sensor V4L2 controls to be used by the algorithms and\n \t * to be set on the sensor.\n", "prefixes": [ "libcamera-devel" ] }