Patch Detail
Show a patch.
GET /api/1.1/patches/1745/?format=api
{ "id": 1745, "url": "https://patchwork.libcamera.org/api/1.1/patches/1745/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1745/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190808000404.10841-2-niklas.soderlund@ragnatech.se>", "date": "2019-08-08T00:04:01", "name": "[libcamera-devel,v3,1/4] libcamera: pipeline: vimc: Initialize device pointers", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "f57bccc2a6a31485033b33e3589d71233558e25b", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/1.1/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1745/mbox/", "series": [ { "id": 448, "url": "https://patchwork.libcamera.org/api/1.1/series/448/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=448", "date": "2019-08-08T00:04:00", "name": "libcamera: Fix issues with vimc and Linux v5.2", "version": 3, "mbox": "https://patchwork.libcamera.org/series/448/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1745/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1745/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3C07260E31\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 8 Aug 2019 02:04:10 +0200 (CEST)", "from bismarck.berto.se (unknown [145.14.112.32])\n\tby bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid 068f0e8b-b970-11e9-bdc3-005056917a89;\n\tThu, 08 Aug 2019 02:04:01 +0200 (CEST)" ], "X-Halon-ID": "068f0e8b-b970-11e9-bdc3-005056917a89", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 8 Aug 2019 02:04:01 +0200", "Message-Id": "<20190808000404.10841-2-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.22.0", "In-Reply-To": "<20190808000404.10841-1-niklas.soderlund@ragnatech.se>", "References": "<20190808000404.10841-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 1/4] libcamera: pipeline: vimc:\n\tInitialize device pointers", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Thu, 08 Aug 2019 00:04:10 -0000" }, "content": "As the device pointers are deleted in the pipelines destructor it's not\na good idea to have them uninitialized.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/pipeline/vimc.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/vimc.cpp b/src/libcamera/pipeline/vimc.cpp\nindex 61b68a32ea508af8..3d6808222a8a2c5d 100644\n--- a/src/libcamera/pipeline/vimc.cpp\n+++ b/src/libcamera/pipeline/vimc.cpp\n@@ -35,7 +35,7 @@ class VimcCameraData : public CameraData\n {\n public:\n \tVimcCameraData(PipelineHandler *pipe)\n-\t\t: CameraData(pipe)\n+\t\t: CameraData(pipe), video_(nullptr), sensor_(nullptr)\n \t{\n \t}\n \n", "prefixes": [ "libcamera-devel", "v3", "1/4" ] }