Patch Detail
Show a patch.
GET /api/1.1/patches/17422/?format=api
{ "id": 17422, "url": "https://patchwork.libcamera.org/api/1.1/patches/17422/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17422/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220927023642.12341-12-laurent.pinchart@ideasonboard.com>", "date": "2022-09-27T02:36:20", "name": "[libcamera-devel,v5,11/33] ipa: ipu3: Pass controls to algorithm's queueRequest() handler", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "066f0d5c15a7fbe977adb5a706362c7f5fc2b919", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17422/mbox/", "series": [ { "id": 3506, "url": "https://patchwork.libcamera.org/api/1.1/series/3506/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3506", "date": "2022-09-27T02:36:09", "name": "ipa: Frame context queue, IPU3 & RkISP consolidation, and RkISP1 improvements", "version": 5, "mbox": "https://patchwork.libcamera.org/series/3506/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17422/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17422/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BCAD3C327E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 27 Sep 2022 02:37:18 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8802062290;\n\tTue, 27 Sep 2022 04:37:18 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F1CE16228F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 27 Sep 2022 04:37:15 +0200 (CEST)", "from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 76A3A47C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 27 Sep 2022 04:37:15 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664246238;\n\tbh=48ozrf+iyxWSMIBRE+QVZz1G+ZWEjToS+6cGvsIwVbo=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=RbTImtf+T9DMtld7LtC74PgxPuWpBpvzRTjlXRuStJvzOzuKKQevC4YYQ133297uB\n\tni1D2k4umWFcsLdwmYL51LG0BbU8icENCIuo9DF4o0QTnao35U7zcYZd3Bl1jLvMu2\n\tbQOCAIgkSlT5Wnc4XSsQT0DBbRYQ3GRotyKu4Gg9qV0gdDPBwYTy6Cn03yvNjcmicv\n\tmJzhG0rEzVG6+T12YXD+W+oEf+fJr/Ri5UGFfyKdGPdbKUxaTGIkxOSdQ6w+dUtQwe\n\t4+y6Pt84CwGTDqVdcWldcMFbP8ujT4GtWRKn1uj1dGafT6SAzFnM9/Iklc/Xbd110C\n\t8LDjR0HGx2qvg==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1664246235;\n\tbh=48ozrf+iyxWSMIBRE+QVZz1G+ZWEjToS+6cGvsIwVbo=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=eCPOWuNMvMIxMmXtYDmDU9L+byLgOEvDOz9ORFx2Nzh1ey841DySUaFr6KJvc9D3b\n\tEgJMdkwkpZ55crlglmPAmR2lX3BUey02w7qhD0lmBJ2OGtfAse0T71I7hsta5fbyDx\n\tO4Xa/v+Ww5JnaxBFwELV9hynXjs/W0EG8JF3onZw=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"eCPOWuNM\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 27 Sep 2022 05:36:20 +0300", "Message-Id": "<20220927023642.12341-12-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20220927023642.12341-1-laurent.pinchart@ideasonboard.com>", "References": "<20220927023642.12341-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v5 11/33] ipa: ipu3: Pass controls to\n\talgorithm's queueRequest() handler", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Call the Algorithm::queueRequest() function of all algorithms when a\nrequest is queued, to pass the request controls to the algorithms. We\ncan now drop the copy of the control list stored in IPAFrameContext as\nit isn't used anymore.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\nChanges since v4:\n\n- Drop todo comment\n---\n src/ipa/ipu3/ipa_context.cpp | 3 ---\n src/ipa/ipu3/ipa_context.h | 3 ---\n src/ipa/ipu3/ipu3.cpp | 5 ++---\n 3 files changed, 2 insertions(+), 9 deletions(-)", "diff": "diff --git a/src/ipa/ipu3/ipa_context.cpp b/src/ipa/ipu3/ipa_context.cpp\nindex 6904ccbbdf8b..bd71b615365d 100644\n--- a/src/ipa/ipu3/ipa_context.cpp\n+++ b/src/ipa/ipu3/ipa_context.cpp\n@@ -168,9 +168,6 @@ namespace libcamera::ipa::ipu3 {\n * \\struct IPAFrameContext\n * \\brief IPU3-specific FrameContext\n *\n- * \\var IPAFrameContext::frameControls\n- * \\brief Controls sent in by the application while queuing the request\n- *\n * \\var IPAFrameContext::sensor\n * \\brief Effective sensor values that were applied for the frame\n *\ndiff --git a/src/ipa/ipu3/ipa_context.h b/src/ipa/ipu3/ipa_context.h\nindex bfc0196e098a..36099353e9f2 100644\n--- a/src/ipa/ipu3/ipa_context.h\n+++ b/src/ipa/ipu3/ipa_context.h\n@@ -12,7 +12,6 @@\n \n #include <libcamera/base/utils.h>\n \n-#include <libcamera/controls.h>\n #include <libcamera/geometry.h>\n \n #include <libipa/fc_queue.h>\n@@ -78,8 +77,6 @@ struct IPAFrameContext : public FrameContext {\n \t\tuint32_t exposure;\n \t\tdouble gain;\n \t} sensor;\n-\n-\tControlList frameControls;\n };\n \n struct IPAContext {\ndiff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex 96dc2af2cb73..d1ea081d595d 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -663,11 +663,10 @@ void IPAIPU3::processStatsBuffer(const uint32_t frame,\n */\n void IPAIPU3::queueRequest(const uint32_t frame, const ControlList &controls)\n {\n-\t/* \\todo Start processing for 'frame' based on 'controls'. */\n \tIPAFrameContext &frameContext = context_.frameContexts.alloc(frame);\n \n-\t/* \\todo Implement queueRequest to each algorithm. */\n-\tframeContext.frameControls = controls;\n+\tfor (auto const &algo : algorithms())\n+\t\talgo->queueRequest(context_, frame, frameContext, controls);\n }\n \n /**\n", "prefixes": [ "libcamera-devel", "v5", "11/33" ] }