Patch Detail
Show a patch.
GET /api/1.1/patches/17396/?format=api
{ "id": 17396, "url": "https://patchwork.libcamera.org/api/1.1/patches/17396/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17396/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220926093639.29946-1-naush@raspberrypi.com>", "date": "2022-09-26T09:36:39", "name": "[libcamera-devel] ipa: raspberrypi: Limit minimum exposure time for the IMX296", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "5b2ce1981d5fd9799bcecb58aea5bb7fec7721bf", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17396/mbox/", "series": [ { "id": 3502, "url": "https://patchwork.libcamera.org/api/1.1/series/3502/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3502", "date": "2022-09-26T09:36:39", "name": "[libcamera-devel] ipa: raspberrypi: Limit minimum exposure time for the IMX296", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3502/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17396/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17396/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 03761C0DA4\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 26 Sep 2022 09:36:43 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AC3596224E;\n\tMon, 26 Sep 2022 11:36:43 +0200 (CEST)", "from mail-wr1-x429.google.com (mail-wr1-x429.google.com\n\t[IPv6:2a00:1450:4864:20::429])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B26D061F7C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 26 Sep 2022 11:36:42 +0200 (CEST)", "by mail-wr1-x429.google.com with SMTP id s14so9356512wro.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 26 Sep 2022 02:36:42 -0700 (PDT)", "from naush-laptop.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tc8-20020a5d4148000000b0022af865810esm14110705wrq.75.2022.09.26.02.36.41\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 26 Sep 2022 02:36:41 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664185003;\n\tbh=MZgm/27T1rqyPNYqZ9WDFMbHjkEHIHNE3GGHD19laTg=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=m9a45oVhvr7scNK4apwtmpkS3FIJPxniszcTye2dzJh6N0oxWbnxkZQOphrzaCL9y\n\thX4Iox6vkXOGyOWMpDARcdCXyLh1WY3YCQg9kEjNb83FPROD2ouK7U8mPiL16aMjqd\n\tRbgEqENE5f1+ptcUlr/flbG9haNWmvzLXnwMxtUjOP3mHm6UEjXEt5aCt2gdS+sYuY\n\tYWvJ0ingeVzMwbfmzjVPeU/32I6cIRV8H2fMLtysmm9hlT2ua6w1EJNcUWj59yzA4/\n\t0eFAqEriohfyENQyVi2SpWhaAvQuzckpaa9escBzTmO8xb/zDMNz4loTW8jI6wZw1P\n\twcLuUiOgQMuUA==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date;\n\tbh=6Neb+A802aTfBC8/5BcN3yy+EzBUfPtueeijCiSaKnk=;\n\tb=QEzgyTPn27YqNsoLi27gSzlqEZJYZyE6KV0+cSrW1mQ6o5gWNlu75LijBl4SPPnPJl\n\tXPotrS33vAgloPzzOX0z399c8sjT2/JTok69JK8UB+JfdbdD0kNg/ugztwFdVET4OKvJ\n\tavCqZorWFUP+Cof3soVsrpid4AxzEgZ0VAeLtMiJesYKsySxw2v+Q+sai1Qm1xhYWLU3\n\tI8bXwfCRQ+KC75HJGq/sgQ5MbE1fR74NjWurMeCPOcet1m+e9IRyRyq/BMO4pQ/5apJC\n\t5jlmk3ZaafS43qpfScjHcTvrX7TGb5j7AQ6yBowOLwBK14+0ZYrimNRoYTQH+oSEiF/p\n\tqa7A==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"QEzgyTPn\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date;\n\tbh=6Neb+A802aTfBC8/5BcN3yy+EzBUfPtueeijCiSaKnk=;\n\tb=Djrqv/3M+T2CzkXqFdX4e2Wq0q7XaD6UfigXL6W3zJcPFOq+Gm5CgIG3lsSos9SNsJ\n\tz3HiJhy4WeQVQfovHqfsyWAKlBy794ZlxD8BCzn84RW2fMv/HTdHXAw1edHzAXNlpMRM\n\teYRXJxBkEo9bPH2fZu1eH6MnIfzZATnsJVFSKCFfXG+C9+uYWtk+chTaL6+BXuwd3EXI\n\tG4gkWdGXMxyGrsvNYUpK42dnaYpbqepxThRFsQHqwPqYP1vNpIiTV9Vx1zztVm5lOPZn\n\tCYeBYvCq7L0Gp4TramkhbK5g2Wy43hR6ntiCn1RTtoTfplBuQEUL8GnRI3/qTeuknTx9\n\tjPnA==", "X-Gm-Message-State": "ACrzQf0mN5UEksArK14LdFB77ze5zXnXGe/AGnN3fPI1AvXSHf/wSMrB\n\tr0495aHXoKOvZK6lFvQXnW2YdICYP97f7X1a", "X-Google-Smtp-Source": "AMsMyM64P/qNbhwjZgV2TBAC20vQHNEteGmEYSXonCln+ev95rr773adkd7RYXDYq6XQilHR0OR4gQ==", "X-Received": "by 2002:adf:fa12:0:b0:228:62a8:7c79 with SMTP id\n\tm18-20020adffa12000000b0022862a87c79mr12429470wrr.231.1664185002212; \n\tMon, 26 Sep 2022 02:36:42 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 26 Sep 2022 10:36:39 +0100", "Message-Id": "<20220926093639.29946-1-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] ipa: raspberrypi: Limit minimum exposure\n\ttime for the IMX296", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Naushir Patuck via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Naushir Patuck <naush@raspberrypi.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Limit the minimum allowable exposure time to a single line in the IMX296 camera\nhelper. This equates to approximately 30us.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/ipa/raspberrypi/cam_helper_imx296.cpp | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/raspberrypi/cam_helper_imx296.cpp b/src/ipa/raspberrypi/cam_helper_imx296.cpp\nindex 09f828ea6249..66d21e36ecd0 100644\n--- a/src/ipa/raspberrypi/cam_helper_imx296.cpp\n+++ b/src/ipa/raspberrypi/cam_helper_imx296.cpp\n@@ -26,6 +26,7 @@ public:\n \tvoid getDelays(int &exposureDelay, int &gainDelay, int &vblankDelay) const override;\n \n private:\n+\tstatic constexpr uint32_t minExposureLines = 1;\n \tstatic constexpr uint32_t maxGainCode = 239;\n \tstatic constexpr Duration timePerLine = 550.0 / 37.125e6 * 1.0s;\n \n@@ -54,12 +55,12 @@ double CamHelperImx296::gain(uint32_t gainCode) const\n \n uint32_t CamHelperImx296::exposureLines(Duration exposure) const\n {\n-\treturn (exposure - 14.26us) / timePerLine;\n+\treturn std::max<uint32_t>(minExposureLines, (exposure - 14.26us) / timePerLine);\n }\n \n Duration CamHelperImx296::exposure(uint32_t exposureLines) const\n {\n-\treturn exposureLines * timePerLine + 14.26us;\n+\treturn std::max<uint32_t>(minExposureLines, exposureLines) * timePerLine + 14.26us;\n }\n \n void CamHelperImx296::getDelays(int &exposureDelay, int &gainDelay,\n", "prefixes": [ "libcamera-devel" ] }