Patch Detail
Show a patch.
GET /api/1.1/patches/17366/?format=api
{ "id": 17366, "url": "https://patchwork.libcamera.org/api/1.1/patches/17366/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17366/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220914070025.27540-1-matthias.fend@emfend.at>", "date": "2022-09-14T07:00:25", "name": "[libcamera-devel] libcamera: ipa_manager: Fix build without openssl", "commit_ref": "74ab3f778c848b20cbf8fe299170756ff6ebab1a", "pull_url": null, "state": "accepted", "archived": false, "hash": "cfb7c0a1123132119efefc52eee1c69729478a07", "submitter": { "id": 134, "url": "https://patchwork.libcamera.org/api/1.1/people/134/?format=api", "name": "Matthias Fend", "email": "matthias.fend@emfend.at" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17366/mbox/", "series": [ { "id": 3485, "url": "https://patchwork.libcamera.org/api/1.1/series/3485/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3485", "date": "2022-09-14T07:00:25", "name": "[libcamera-devel] libcamera: ipa_manager: Fix build without openssl", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3485/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17366/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17366/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C7E3EC0DA4\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 14 Sep 2022 07:00:36 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C38CE61FA1;\n\tWed, 14 Sep 2022 09:00:35 +0200 (CEST)", "from lx20.hoststar.hosting (lx20.hoststar.hosting [168.119.41.54])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 752896099B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 14 Sep 2022 09:00:33 +0200 (CEST)", "from 194-208-208-245.tele.net ([194.208.208.245]:57025\n\thelo=localhost.localdomain)\n\tby lx20.hoststar.hosting with esmtpsa (TLS1.3) tls\n\tTLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93)\n\t(envelope-from <matthias.fend@emfend.at>) id 1oYMNs-005qT1-HE\n\tfor libcamera-devel@lists.libcamera.org;\n\tWed, 14 Sep 2022 09:00:32 +0200" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1663138836;\n\tbh=9p2AUpiSqQUs6O2QSnxCgkEPo1n2mzVG7iW0KvB8M6E=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=wh9UHrnkaGi3UVlOxZ3xoSHQE4cYR5BJefifmPhc5W6ZcBdip4Yfw1ZlPjWmUdD6k\n\tKPI0VozqZTUoQ+2PhKHfuDH5ZjLw4yzo3D57e2l4xm+NHwzi1gpcxZEYyJvGTFIlVL\n\tQA3oGhSYT1deQXju4nOzIYPceS5F9y2a/fEz8c+KDq7IBL5vErN6syr8hrFsEHOavG\n\tQHjOAsoO63Rb8UutauYEzCgvzYktM9dhNuossxibG8S6opxflQPLCQeY4QMbcspl8C\n\tb7rtDeP1JhzN8RqFQZwqQm6rFV53ZYwVZDabx6UcZfNvMjYcoaqAZbVxVWCIBR0Lyg\n\tGac2EN8zmVAOw==", "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=emfend.at;\n\ts=mail;\n\th=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:To:\n\tFrom:Sender:Reply-To:Cc:Content-Type:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tIn-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=ckZBHS6qSHYpY5dE/B3GHXY9/t0HPXOYALJWwHvYm+I=;\n\tb=efjnEhzmYtcwbl8EqV8Lokshyp\n\to32/bN9YIQWKCK1wqRqkcMBltUkBUo2e0GX+d19uEEsvvc6W3gNdCPsHvkS/q9HfkHhEW1pmqv/+c\n\tui5qBH+dj44ngwKA5BzMVN5PBSPOjOl6n2/CrK02UN3ipGSTJY1EFhoCvlwVqWwmISpI=;" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=emfend.at header.i=@emfend.at\n\theader.b=\"efjnEhzm\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 14 Sep 2022 09:00:25 +0200", "Message-Id": "<20220914070025.27540-1-matthias.fend@emfend.at>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Spam-Score": "", "X-Spam-Bar": "", "X-Spam-Report": "", "Subject": "[libcamera-devel] [PATCH] libcamera: ipa_manager: Fix build without\n\topenssl", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Matthias Fend via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Matthias Fend <matthias.fend@emfend.at>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Since commit bedef55d9500 (\"libcamera: pub_key: Gracefully handle failures\nto load public key'\") the build will fail if openssl is not found on the\nhost system.\nUse the existing HAVE_IPA_PUBKEY define to avoid accessing pubKey_ which\ndoes not exist when building without openssl.\n\nSigned-off-by: Matthias Fend <matthias.fend@emfend.at>\n---\n src/libcamera/ipa_manager.cpp | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp\nindex 2f96a207..030ef43f 100644\n--- a/src/libcamera/ipa_manager.cpp\n+++ b/src/libcamera/ipa_manager.cpp\n@@ -109,8 +109,10 @@ IPAManager::IPAManager()\n \t\tLOG(IPAManager, Fatal)\n \t\t\t<< \"Multiple IPAManager objects are not allowed\";\n \n+#if HAVE_IPA_PUBKEY\n \tif (!pubKey_.isValid())\n \t\tLOG(IPAManager, Warning) << \"Public key not valid\";\n+#endif\n \n \tunsigned int ipaCount = 0;\n \n", "prefixes": [ "libcamera-devel" ] }