Patch Detail
Show a patch.
GET /api/1.1/patches/17337/?format=api
{ "id": 17337, "url": "https://patchwork.libcamera.org/api/1.1/patches/17337/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17337/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220908014200.28728-29-laurent.pinchart@ideasonboard.com>", "date": "2022-09-08T01:41:56", "name": "[libcamera-devel,v4,28/32] ipa: rkisp1: awb: Log means, gains and temperature in debug message", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "e44874a3e7dc73c74bfcd7b12f0c9ae5994de899", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17337/mbox/", "series": [ { "id": 3476, "url": "https://patchwork.libcamera.org/api/1.1/series/3476/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3476", "date": "2022-09-08T01:41:28", "name": "ipa: Frame context queue, IPU3 & RkISP consolidation, and RkISP1 improvements", "version": 4, "mbox": "https://patchwork.libcamera.org/series/3476/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17337/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17337/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 60400C3272\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 8 Sep 2022 01:42:59 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 101A462108;\n\tThu, 8 Sep 2022 03:42:59 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1762A62101\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 8 Sep 2022 03:42:57 +0200 (CEST)", "from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 924DA6CC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 8 Sep 2022 03:42:56 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1662601379;\n\tbh=Eq/b+TndUsp7IzNW5h5xamI3p+PT21otPxoaCrymkIQ=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=Ok5oooLg8T2x5po0qmzw1VIdPAx+FxAr1uEWK4zWpCcRUOcMDGIt5awD6xYseY/Hh\n\tPtGSLzQ4EuCIaeaYqabRAlRQk6JAfiebCYg7SpQEXonj8GToO+LjefqQnKk5pEnuZT\n\tzTwXf2gsjTVxsWbevkWFk7JHzV+YWYQ3D5cpqMYkHM/tB96kCttPQ7ZwQ2ynD0bnuT\n\tnF6hNFjnbO3yc3F1e++W9l47vQsR5ow5+nYJMWSznxa+q2EJ0u8eGpjYXg6QyeShyO\n\tcDNU917kTj6h7Ly2QFv32WNia8fNWYZdAtjeqA5bdv2RHjkiiinaeWzlixS7CyxbSe\n\tOIuZY5X0caI1A==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1662601376;\n\tbh=Eq/b+TndUsp7IzNW5h5xamI3p+PT21otPxoaCrymkIQ=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=DHCZ0m9NXvAboDN8Y/gFd7o1LqAmOLgHTt6/BW+/G+3b0BMn2GBpG4j8akFSivGQh\n\tXKE5S9VdvfLu6PuzGroYe2Ijy13N5c+F6c/2JD+zWpRqmQBOsCwEULeFX6Gh859Wd1\n\tRWs+TaJDAibqoP1elxV+EpT5p+n/grIHlHeibF/I=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"DHCZ0m9N\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 8 Sep 2022 04:41:56 +0300", "Message-Id": "<20220908014200.28728-29-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20220908014200.28728-1-laurent.pinchart@ideasonboard.com>", "References": "<20220908014200.28728-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 28/32] ipa: rkisp1: awb: Log means,\n\tgains and temperature in debug message", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Extend the debug message in Awb::process() to log the means and color\ntemperature in addition to the gains. This is useful for debugging the\nalgorithm behaviour. While at it, set the showpoint flag to print a\nfixed number of digits after the decimal point, making logs more\nreadable.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/rkisp1/algorithms/awb.cpp | 9 +++++++--\n 1 file changed, 7 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\nindex 2ff67ed98221..ed91e9277a16 100644\n--- a/src/ipa/rkisp1/algorithms/awb.cpp\n+++ b/src/ipa/rkisp1/algorithms/awb.cpp\n@@ -9,6 +9,7 @@\n \n #include <algorithm>\n #include <cmath>\n+#include <iomanip>\n \n #include <libcamera/base/log.h>\n \n@@ -271,8 +272,12 @@ void Awb::process(IPAContext &context,\n \tactiveState.awb.gains.automatic.blue = std::clamp(blueGain, 0.0, 1023.0 / 256);\n \tactiveState.awb.gains.automatic.green = 1.0;\n \n-\tLOG(RkISP1Awb, Debug) << \"Gain found for red: \" << activeState.awb.gains.automatic.red\n-\t\t\t << \" and for blue: \" << activeState.awb.gains.automatic.blue;\n+\tLOG(RkISP1Awb, Debug) << std::showpoint\n+\t\t<< \"Means [\" << redMean << \", \" << greenMean << \", \" << blueMean\n+\t\t<< \"], gains [\" << activeState.awb.gains.automatic.red << \", \"\n+\t\t<< activeState.awb.gains.automatic.green << \", \"\n+\t\t<< activeState.awb.gains.automatic.blue << \"], temp \"\n+\t\t<< frameContext.awb.temperatureK << \"K\";\n }\n \n REGISTER_IPA_ALGORITHM(Awb, \"Awb\")\n", "prefixes": [ "libcamera-devel", "v4", "28/32" ] }