Patch Detail
Show a patch.
GET /api/1.1/patches/17320/?format=api
{ "id": 17320, "url": "https://patchwork.libcamera.org/api/1.1/patches/17320/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17320/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220908014200.28728-12-laurent.pinchart@ideasonboard.com>", "date": "2022-09-08T01:41:39", "name": "[libcamera-devel,v4,11/32] ipa: ipu3: Pass controls to algorithm's queueRequest() handler", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "5a735d7cc6899c51df9c9f8c6edb7a10d843142d", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17320/mbox/", "series": [ { "id": 3476, "url": "https://patchwork.libcamera.org/api/1.1/series/3476/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3476", "date": "2022-09-08T01:41:28", "name": "ipa: Frame context queue, IPU3 & RkISP consolidation, and RkISP1 improvements", "version": 4, "mbox": "https://patchwork.libcamera.org/series/3476/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17320/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17320/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1280BC327D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 8 Sep 2022 01:42:35 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BBBC8620C3;\n\tThu, 8 Sep 2022 03:42:34 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 41A91620B8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 8 Sep 2022 03:42:33 +0200 (CEST)", "from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BFAB9888\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 8 Sep 2022 03:42:32 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1662601354;\n\tbh=99rJq+scIF3Wd+NrFT3kX9FI6zV87UX/otE3vmV/Lgc=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=cIaQt+TDVOJJoV+e4j7FEUJLS5cxTyjZiZa/pr/KpLdp7+l9Hu+f6Z06JubrKg3ME\n\tQeWxPvqscIXVelzlgNYhYrwwNZoujWe9Eb9JZ5UsE3iM0g7wpx1iwrIPskLfDLY/sO\n\tt7A4tv6FIso0oBd8jJ+kCBd4B0UNhH91r9HIORRYNUKBDEmgRilGd636a7tpMg9Cw/\n\toVeM5UQmvEKUEd0mhE5H9OBV42zIsEkCBhq+k9ZqjfSYbW79xJIf8Ax1+kZO4LsCGA\n\tykVSFoQPZ6nQldIWKGlCG1Iirjb0+Ebx3Csy+hSO+vg/2Kcpfy23/ZaesHtbk3LOoV\n\trqjPLHCgeQ5og==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1662601353;\n\tbh=99rJq+scIF3Wd+NrFT3kX9FI6zV87UX/otE3vmV/Lgc=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=coUehkspEFMiTkP6W9ZC6yxwsJ0A9khT35r48RLSoJOahnQ3uwUDz8EZObAmoi/iA\n\tNGy88G/J5zJ5ReTAOVHSpGXUgL+PM9CuxaKPD0YAdq6NMdzCinO6Uc+Fxwts0s+m92\n\tlA5rP2GCmAV8oDTZ2exoeQfTUWlwChVHS5bxV6p4=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"coUehksp\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 8 Sep 2022 04:41:39 +0300", "Message-Id": "<20220908014200.28728-12-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20220908014200.28728-1-laurent.pinchart@ideasonboard.com>", "References": "<20220908014200.28728-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 11/32] ipa: ipu3: Pass controls to\n\talgorithm's queueRequest() handler", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The the Algorithm::queueRequest() function of all algorithms when a\nrequest is queue, to pass the request controls to the algorithms. We can\nnow drop the copy of the control list stored in IPAFrameContext as it\nisn't used anymore.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/ipu3/ipa_context.cpp | 3 ---\n src/ipa/ipu3/ipa_context.h | 3 ---\n src/ipa/ipu3/ipu3.cpp | 4 ++--\n 3 files changed, 2 insertions(+), 8 deletions(-)", "diff": "diff --git a/src/ipa/ipu3/ipa_context.cpp b/src/ipa/ipu3/ipa_context.cpp\nindex 6904ccbbdf8b..bd71b615365d 100644\n--- a/src/ipa/ipu3/ipa_context.cpp\n+++ b/src/ipa/ipu3/ipa_context.cpp\n@@ -168,9 +168,6 @@ namespace libcamera::ipa::ipu3 {\n * \\struct IPAFrameContext\n * \\brief IPU3-specific FrameContext\n *\n- * \\var IPAFrameContext::frameControls\n- * \\brief Controls sent in by the application while queuing the request\n- *\n * \\var IPAFrameContext::sensor\n * \\brief Effective sensor values that were applied for the frame\n *\ndiff --git a/src/ipa/ipu3/ipa_context.h b/src/ipa/ipu3/ipa_context.h\nindex bfc0196e098a..36099353e9f2 100644\n--- a/src/ipa/ipu3/ipa_context.h\n+++ b/src/ipa/ipu3/ipa_context.h\n@@ -12,7 +12,6 @@\n \n #include <libcamera/base/utils.h>\n \n-#include <libcamera/controls.h>\n #include <libcamera/geometry.h>\n \n #include <libipa/fc_queue.h>\n@@ -78,8 +77,6 @@ struct IPAFrameContext : public FrameContext {\n \t\tuint32_t exposure;\n \t\tdouble gain;\n \t} sensor;\n-\n-\tControlList frameControls;\n };\n \n struct IPAContext {\ndiff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex 8158ca0883e8..844ab6de03c7 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -666,8 +666,8 @@ void IPAIPU3::queueRequest(const uint32_t frame, const ControlList &controls)\n \t/* \\todo Start processing for 'frame' based on 'controls'. */\n \tIPAFrameContext &frameContext = context_.frameContexts.init(frame);\n \n-\t/* \\todo Implement queueRequest to each algorithm. */\n-\tframeContext.frameControls = controls;\n+\tfor (auto const &algo : algorithms())\n+\t\talgo->queueRequest(context_, frame, frameContext, controls);\n }\n \n /**\n", "prefixes": [ "libcamera-devel", "v4", "11/32" ] }