Patch Detail
Show a patch.
GET /api/1.1/patches/17308/?format=api
{ "id": 17308, "url": "https://patchwork.libcamera.org/api/1.1/patches/17308/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17308/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220907163504.209658-1-utkarsh02t@gmail.com>", "date": "2022-09-07T16:35:04", "name": "[libcamera-devel,1/1] qcam: Fix crash when switching from non existant camera", "commit_ref": "5a9fd9a95cce4ab17c9cf5d9e0c33a008255bedb", "pull_url": null, "state": "accepted", "archived": false, "hash": "4523c10ec339b3f813c88c77341a6154430e49db", "submitter": { "id": 114, "url": "https://patchwork.libcamera.org/api/1.1/people/114/?format=api", "name": "Utkarsh Tiwari", "email": "utkarsh02t@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17308/mbox/", "series": [ { "id": 3475, "url": "https://patchwork.libcamera.org/api/1.1/series/3475/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3475", "date": "2022-09-07T16:35:04", "name": "[libcamera-devel,1/1] qcam: Fix crash when switching from non existant camera", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3475/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17308/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17308/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 59A67C0DA4\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 7 Sep 2022 16:35:29 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6E31462089;\n\tWed, 7 Sep 2022 18:35:28 +0200 (CEST)", "from mail-pf1-x431.google.com (mail-pf1-x431.google.com\n\t[IPv6:2607:f8b0:4864:20::431])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9B9BA62054\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 7 Sep 2022 18:35:26 +0200 (CEST)", "by mail-pf1-x431.google.com with SMTP id z187so15160209pfb.12\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 07 Sep 2022 09:35:26 -0700 (PDT)", "from devut-HP-Laptop-14q-cs0xxx..\n\t([2404:bd00:3:dfe3:188b:9ab7:b142:d552])\n\tby smtp.gmail.com with ESMTPSA id\n\tx63-20020a626342000000b0052c849d0886sm12730439pfb.86.2022.09.07.09.35.22\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 07 Sep 2022 09:35:24 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1662568528;\n\tbh=hQrDcAxVTMqYFLp45Cb5sEcs2HEEP3e3ICX+tlOulaM=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=VaQaPSih6fZ9kgK4QswRpL/0e4SINBLNRNtn013xQLchOKfenfyE8HV9UmJwzPL+o\n\tMZ58Vm4bQoSi0ArzhLsM5eLkZKsktDCPocWHKkOhsdsAi4IVHqhHcNaBehBNY4vmvo\n\trHAfrPx25EOrbmWEedpIlCR6a+m5P6tmoQaisfQ6pRy0lL7v9CPtbOkURZT1htBFBx\n\tg66wsXMvUqykE6dNIQo8FzrBN8Fr1EW0pQCDApJvLdV7UCteLekF3MIQNfhuxhuTq9\n\tKJ1RLaVS+bkogIpbKJpxu6kYYZ/w3ixIT6yAJFp5Fj6TCrgWmEr5jJI0ICIY+wYG0K\n\tDJ3Qp/vKK6SwA==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date;\n\tbh=AUJI/ZIj2Br9El6CjsxhM5HOq3u4Ihq6IzC7/A/abpg=;\n\tb=jgVRTCe3IHQzQOVYqq+XQOszGTxmGaGgO6uctiWkseKeOLbAYK5oMQCBpnrWh6O0rN\n\tYcDbWRG1EEx7a8NhVvpecdJBIMIc/WghwRyG8fkSIwIQxvpj5QVNBlx9IL4jRjxncZ30\n\te3AYojkqdA5PwWmvSkBrIPNGc/DfBq3YO3mPJHZV5KNtlN4hUeK7lV4p3VuMOjd+9+eY\n\tjKYR5N2uTOUpp8/LNuI7SM5Lv5Xndvv23iHfpXbtYrneIQPvbWxmcO3kLpe3i/PBD8s2\n\tndYI67e3sfTEKSYV0RcGoQ4ZxrkwN52AskpZgrhFz6uTx6SZcsoS6ygYdBx5ZZg7PU1L\n\txOkA==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"jgVRTCe3\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date;\n\tbh=AUJI/ZIj2Br9El6CjsxhM5HOq3u4Ihq6IzC7/A/abpg=;\n\tb=XYWK6qvuchEwmPMCfUBjAMi4aqHKefGMelMzyMNyDQuAqE1Jzgww+Q71WCfi18Ysr+\n\tzgWNe5CPWtYOVuDtZmQGiIxNxhD3R8vlyQCjYZMzE8/scYst6DMvTwvqZKR5sik5pZzy\n\tmIUsRl+su2PbV1HiAkN6reVjWc9u8/+A97USMoTD2Yt5MytvqLWp1cDlppsyzHAcIbGH\n\tzUAddBO2DmEkMC2fNL8hyMxOzLWYIR1wcuLWymhkNwfm1QyZgMtS3615rG2pAJraN+Be\n\tHULifkCpD8TgHQHwF6cerJ/BB4jZrPhrmTZ8Pyp92OS6VlmPQmA3bvdCs+YyrD9/i/wV\n\tOSDg==", "X-Gm-Message-State": "ACgBeo3iOuNDWQIXF45/OPkF7pIGb31WiT86oObMRx/dWc47yCkBfmJh\n\tP2dkJ9cQdYkW8T+g6l7RJkiQjza3lzg=", "X-Google-Smtp-Source": "AA6agR6h2oZdzB6R8jI8Wgh9FvqE2HYjSG4rGjg/Hz+9VrQhAi7ee+fdgxOFxxEWWBciwEmO+Ft1LQ==", "X-Received": "by 2002:a65:4202:0:b0:42b:d734:51e2 with SMTP id\n\tc2-20020a654202000000b0042bd73451e2mr4054995pgq.621.1662568524751; \n\tWed, 07 Sep 2022 09:35:24 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 7 Sep 2022 22:05:04 +0530", "Message-Id": "<20220907163504.209658-1-utkarsh02t@gmail.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/1] qcam: Fix crash when switching from\n\tnon existant camera", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Utkarsh Tiwari via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Utkarsh Tiwari <utkarsh02t@gmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When switching to different camera we try to release the camera\npreviously used. But if that camera has been unplugged, then its\ninstance would have been destroyed. Accessing it leads to seg fault.\n\nFix by checking camera_ to see if it exists.\n\nBug: https://bugs.libcamera.org/show_bug.cgi?id=147\nSigned-off-by: Utkarsh Tiwari <utkarsh02t@gmail.com>\n---\n src/qcam/main_window.cpp | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\nindex 6fe36168..e0e5092e 100644\n--- a/src/qcam/main_window.cpp\n+++ b/src/qcam/main_window.cpp\n@@ -284,7 +284,9 @@ void MainWindow::switchCamera()\n \t */\n \tstartStopAction_->setChecked(false);\n \n-\tcamera_->release();\n+\tif (camera_)\n+\t\tcamera_->release();\n+\n \tcamera_ = cam;\n \n \tstartStopAction_->setChecked(true);\n", "prefixes": [ "libcamera-devel", "1/1" ] }