Patch Detail
Show a patch.
GET /api/1.1/patches/17280/?format=api
{ "id": 17280, "url": "https://patchwork.libcamera.org/api/1.1/patches/17280/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17280/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220902141136.1342352-1-m.felsch@pengutronix.de>", "date": "2022-09-02T14:11:36", "name": "[libcamera-devel] qcam: viewfinder_gl: selectColorSpace: fix maybe uninitialized warning", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "dc87ba9fc3c9324d42922b4e4614db965661d4d9", "submitter": { "id": 89, "url": "https://patchwork.libcamera.org/api/1.1/people/89/?format=api", "name": "Marco Felsch", "email": "m.felsch@pengutronix.de" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17280/mbox/", "series": [ { "id": 3460, "url": "https://patchwork.libcamera.org/api/1.1/series/3460/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3460", "date": "2022-09-02T14:11:36", "name": "[libcamera-devel] qcam: viewfinder_gl: selectColorSpace: fix maybe uninitialized warning", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3460/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17280/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17280/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 53273C3272\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 2 Sep 2022 14:11:41 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AD21261F9D;\n\tFri, 2 Sep 2022 16:11:40 +0200 (CEST)", "from metis.ext.pengutronix.de (metis.ext.pengutronix.de\n\t[IPv6:2001:67c:670:201:290:27ff:fe1d:cc33])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6B7CC61F9D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 2 Sep 2022 16:11:39 +0200 (CEST)", "from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2])\n\tby metis.ext.pengutronix.de with esmtps\n\t(TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92)\n\t(envelope-from <mfe@pengutronix.de>)\n\tid 1oU7OU-0006u3-Ta; Fri, 02 Sep 2022 16:11:38 +0200", "from [2a0a:edc0:0:1101:1d::28] (helo=dude02.red.stw.pengutronix.de)\n\tby drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2)\n\t(envelope-from <mfe@pengutronix.de>)\n\tid 1oU7OS-003VS1-6x; Fri, 02 Sep 2022 16:11:38 +0200", "from mfe by dude02.red.stw.pengutronix.de with local (Exim 4.94.2)\n\t(envelope-from <mfe@pengutronix.de>)\n\tid 1oU7OT-005dDj-DF; Fri, 02 Sep 2022 16:11:37 +0200" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1662127900;\n\tbh=yhvASHcMzFwJ4IPw7Im0GztuhHRdYPFfO72hQE0LQfE=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:Cc:From;\n\tb=yGwB3HEbVcN7mrIEzBiZTSAvTOgnnAGH/1ezmTDPANKlTq7+//Fktjp1blBU0s1Zm\n\tW3NZF5otbRVxo0Lx5GP2Q4edPghDYFvZjcHnzKTQwgUYw0Qx3/5AYVb4DwiQuQDBim\n\t4XFlUK/t4fWbh8MNoG79KJolb9i2aY6j4/cmvX7gFLagRYGRaPXMOMsqGgB5Xha/6t\n\tusHePTioLNnymxRNxkbwXB1WMJ76BqA/1xQXibEXDotLDfTrhrgHWJQaVaA8Gh9UAn\n\tXL6gSEFzijqEb+XUxRe/HbajNqqXK13yOQXaUxgYSXi612uAhvIXcImZuJbQ3Sl2mk\n\tI35rwWKS+8JPw==", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 2 Sep 2022 16:11:36 +0200", "Message-Id": "<20220902141136.1342352-1-m.felsch@pengutronix.de>", "X-Mailer": "git-send-email 2.30.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-SA-Exim-Connect-IP": "2a0a:edc0:0:c01:1d::a2", "X-SA-Exim-Mail-From": "mfe@pengutronix.de", "X-SA-Exim-Scanned": "No (on metis.ext.pengutronix.de);\n\tSAEximRunCond expanded to false", "X-PTX-Original-Recipient": "libcamera-devel@lists.libcamera.org", "Subject": "[libcamera-devel] [PATCH] qcam: viewfinder_gl: selectColorSpace:\n\tfix maybe uninitialized warning", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Marco Felsch via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Marco Felsch <m.felsch@pengutronix.de>", "Cc": "mfe@pengutronix.de", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Fix gcc11 warning introduced in commit 251f0534 (\"qcam: viewfinder_gl:\nTake color space into account for YUV rendering\"). Fix it by making the\nfull range as default.\n\nFixes: 251f0534 (\"qcam: viewfinder_gl: Take color space into account for YUV rendering\")\nSigned-off-by: Marco Felsch <m.felsch@pengutronix.de>\n---\n src/qcam/viewfinder_gl.cpp | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/src/qcam/viewfinder_gl.cpp b/src/qcam/viewfinder_gl.cpp\nindex e2aa2470..501c5bae 100644\n--- a/src/qcam/viewfinder_gl.cpp\n+++ b/src/qcam/viewfinder_gl.cpp\n@@ -367,6 +367,7 @@ void ViewFinderGL::selectColorSpace(const libcamera::ColorSpace &colorSpace)\n \tdouble offset;\n \n \tswitch (colorSpace.range) {\n+\tdefault: /* Avoid gcc11 maybe-uninitialized warning */\n \tcase libcamera::ColorSpace::Range::Full:\n \t\toffset = 0.0;\n \t\tbreak;\n", "prefixes": [ "libcamera-devel" ] }