Patch Detail
Show a patch.
GET /api/1.1/patches/17266/?format=api
{ "id": 17266, "url": "https://patchwork.libcamera.org/api/1.1/patches/17266/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17266/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220831054938.21617-3-utkarsh02t@gmail.com>", "date": "2022-08-31T05:49:33", "name": "[libcamera-devel,v9,2/7] qcam: Support Hotplug for Camera Selection Dialog", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d0a4c6f65fa20db11640d0e4ec82b51ed7be76ad", "submitter": { "id": 114, "url": "https://patchwork.libcamera.org/api/1.1/people/114/?format=api", "name": "Utkarsh Tiwari", "email": "utkarsh02t@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17266/mbox/", "series": [ { "id": 3457, "url": "https://patchwork.libcamera.org/api/1.1/series/3457/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3457", "date": "2022-08-31T05:49:31", "name": "Introduce capture scripts to qcam", "version": 9, "mbox": "https://patchwork.libcamera.org/series/3457/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17266/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17266/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AAA67C3272\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 31 Aug 2022 05:49:58 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 75C1961FC6;\n\tWed, 31 Aug 2022 07:49:58 +0200 (CEST)", "from mail-pg1-x530.google.com (mail-pg1-x530.google.com\n\t[IPv6:2607:f8b0:4864:20::530])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E726761F9B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 31 Aug 2022 07:49:56 +0200 (CEST)", "by mail-pg1-x530.google.com with SMTP id q9so12625361pgq.6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 30 Aug 2022 22:49:56 -0700 (PDT)", "from devut-HP-Laptop-14q-cs0xxx.. ([103.36.82.122])\n\tby smtp.gmail.com with ESMTPSA id\n\tq19-20020aa79833000000b00537eacc8fa6sm8307333pfl.40.2022.08.30.22.49.52\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 30 Aug 2022 22:49:55 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1661924998;\n\tbh=g6D5m2WFhbwXTkn/Pct1kjEn4FTBYJsLIw9oQbIJ8Qk=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=orAodYh9twuu66qKripTPqVLTY3fl9WdcbV63mMSmcoORJGezTZ2YRx0Yj5l/Tb5P\n\t5qjBCBL0tTqrD8I/VGrVjDX54OYaUH4+jzMTWAE4+deObRFhfXJZNnD1LBPYQFF20W\n\tZqURAXj3+aXElPeRivyd9UP8cKP5oBY3T3pw9NDjyNIDY9f4bMfOiC8tQ7xhBpPhqD\n\tw8DCIRQ0U82Jb02ZCLjCvYkuWebsPDcaK4LnSHB+LmB2aOZZyfShYIQB/ltgMSdgKg\n\txqTldMtJ15G/1tEu3oNDp0MO0R86mOfa6twXbfJcuCAejODmVBH+GvwJn33dyUakFw\n\tnEe1ea2zlr6Pg==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc;\n\tbh=uJ1eqaShmnTXo3AJN7h1xqQNAn/WbfbO7bzaBnyOrR4=;\n\tb=CDC57I7O1aC0xphtRIMK8o5x2DhTq3RTN+44/4rY3LQGaVx8AsO6FUyRTum8f1NBQE\n\tEnjKOJc6JJZ/2vYrLk1QbR8KyEl1grXz7eReiUCRBpT621zu64kjxdeXmhQwqR94fqHN\n\tQUA8v/EJBYVAsUIAAKj0zP65W3lqJFlgfHNezzGN4ibnjLUhv7RZilrXIV5tiu8T30qL\n\ts/Eh7ZM8Rzc/HaHNoOezSih0PauX9sgjSWA+va+PczBq68ZPDKZF6rvJj9lQb8LjreDR\n\tKZLgglP2fDpd8o5ra1nEE87QObuwjEvswtU6bNvBl9YiFo759ivIbyvHPrz0yJ/FOsBu\n\tYlFg==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"CDC57I7O\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc;\n\tbh=uJ1eqaShmnTXo3AJN7h1xqQNAn/WbfbO7bzaBnyOrR4=;\n\tb=J9PQwel19spnM8Frn165x5IIr6LWOr9UfvpYA6ZJJuNqcGKDoPP62Vc8BrR3ERCKKx\n\tlSO2GaQTh5/J5IfbxlHpAo6p2x0plEOAnU9PeQ8qbAqJj8C/GU96uZdjxAAqiMhWhVHI\n\tTalx8x+8rL14aUhPJWctHXca4H62DcsoZDBsHwIPOnF3FFvvAp8dJzZg4wVBhmbzUnZ7\n\tlA6snlJtK+00X8db7mcm3C9WZkr1j1/iDvTsCawtM9Xt8olFxPk+fIHBxasig6+Ko5gB\n\tyQPbt16c/NeW5H1okkXN5yr3HJqOKgidKPMWj/xpl41NZqAIrzbzSsaHNInEwPZz8MGD\n\tV/JA==", "X-Gm-Message-State": "ACgBeo2xPut46y28i6TfCgxFdH5qrs55rpys01IDeni0rmWEJW6KbgZL\n\t94CL3h+hToaOVmUchdpc0TzG0fjr9zM=", "X-Google-Smtp-Source": "AA6agR6slkzwzNZNaqO8yUabs94tydRNwznL8PJWivtYwgbbEJfKybQwgHJCA5OItMGJ0jAXOjdR9g==", "X-Received": "by 2002:a63:84c2:0:b0:42b:f6bc:69f5 with SMTP id\n\tk185-20020a6384c2000000b0042bf6bc69f5mr12163968pgd.10.1661924995304; \n\tTue, 30 Aug 2022 22:49:55 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 31 Aug 2022 11:19:33 +0530", "Message-Id": "<20220831054938.21617-3-utkarsh02t@gmail.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220831054938.21617-1-utkarsh02t@gmail.com>", "References": "<20220831054938.21617-1-utkarsh02t@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v9 2/7] qcam: Support Hotplug for Camera\n\tSelection Dialog", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Utkarsh Tiwari via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Utkarsh Tiwari <utkarsh02t@gmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Currently if there is HotPlug event when the user is on the Camera\nselection dialog, the QComboBox doesn't update to reflect the change.\n\nAdd support for hotplugging / unplugging cameras.\n\nSigned-off-by: Utkarsh Tiwari <utkarsh02t@gmail.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\nDifference from v8:\n 1. Removed the part about QPointer from commit message, no longer\n needed.\n 2. s/didn't/doesn't commit msg.\n 3. Rename cameraRemoved to removeCamera and cameraAdded to addCamera\n 4. Pass QString to cameraRemoved, cameraAdded instead of libcamera::Camera\n 5. Removed blank line between cameraAdded, cameraRemoved\n 6. Optimize cameraId passing cameraCombo_ , cameraAdded,\n cameraRemoved.\n src/qcam/cam_select_dialog.cpp | 12 ++++++++++++\n src/qcam/cam_select_dialog.h | 5 +++++\n src/qcam/main_window.cpp | 7 +++++--\n 3 files changed, 22 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/qcam/cam_select_dialog.cpp b/src/qcam/cam_select_dialog.cpp\nindex a49d822b..f82930cc 100644\n--- a/src/qcam/cam_select_dialog.cpp\n+++ b/src/qcam/cam_select_dialog.cpp\n@@ -48,3 +48,15 @@ std::string CameraSelectorDialog::getCameraId()\n {\n \treturn cameraIdComboBox_->currentText().toStdString();\n }\n+\n+/* Hotplug / Unplug Support. */\n+void CameraSelectorDialog::addCamera(QString camearaId)\n+{\n+\tcameraIdComboBox_->addItem(camearaId);\n+}\n+\n+void CameraSelectorDialog::removeCamera(QString cameraId)\n+{\n+\tint cameraIndex = cameraIdComboBox_->findText(cameraId);\n+\tcameraIdComboBox_->removeItem(cameraIndex);\n+}\ndiff --git a/src/qcam/cam_select_dialog.h b/src/qcam/cam_select_dialog.h\nindex c31f4f82..bd2dbc1e 100644\n--- a/src/qcam/cam_select_dialog.h\n+++ b/src/qcam/cam_select_dialog.h\n@@ -13,6 +13,7 @@\n #include <libcamera/camera_manager.h>\n \n #include <QDialog>\n+#include <QString>\n \n class QComboBox;\n \n@@ -27,6 +28,10 @@ public:\n \n \tstd::string getCameraId();\n \n+\t/* Hotplug / Unplug Support. */\n+\tvoid addCamera(QString cameraId);\n+\tvoid removeCamera(QString cameraId);\n+\n private:\n \tlibcamera::CameraManager *cm_;\n \ndiff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\nindex 14bcf03e..e8e22d49 100644\n--- a/src/qcam/main_window.cpp\n+++ b/src/qcam/main_window.cpp\n@@ -587,10 +587,12 @@ void MainWindow::stopCapture()\n void MainWindow::processHotplug(HotplugEvent *e)\n {\n \tCamera *camera = e->camera();\n+\tQString cameraId = QString::fromStdString(camera->id());\n \tHotplugEvent::PlugEvent event = e->hotplugEvent();\n \n \tif (event == HotplugEvent::HotPlug) {\n-\t\tcameraCombo_->addItem(QString::fromStdString(camera->id()));\n+\t\tcameraCombo_->addItem(cameraId);\n+\t\tcameraSelectorDialog_->addCamera(cameraId);\n \t} else if (event == HotplugEvent::HotUnplug) {\n \t\t/* Check if the currently-streaming camera is removed. */\n \t\tif (camera == camera_.get()) {\n@@ -600,8 +602,9 @@ void MainWindow::processHotplug(HotplugEvent *e)\n \t\t\tcameraCombo_->setCurrentIndex(0);\n \t\t}\n \n-\t\tint camIndex = cameraCombo_->findText(QString::fromStdString(camera->id()));\n+\t\tint camIndex = cameraCombo_->findText(cameraId);\n \t\tcameraCombo_->removeItem(camIndex);\n+\t\tcameraSelectorDialog_->removeCamera(cameraId);\n \t}\n }\n \n", "prefixes": [ "libcamera-devel", "v9", "2/7" ] }