Patch Detail
Show a patch.
GET /api/1.1/patches/17261/?format=api
{ "id": 17261, "url": "https://patchwork.libcamera.org/api/1.1/patches/17261/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17261/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220830133321.1107312-1-umang.jain@ideasonboard.com>", "date": "2022-08-30T13:33:21", "name": "[libcamera-devel,v2] libcamera: request: Rename Private::reuse() to Private::reset()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "0f68b8c53f2e6a61f6ed3da000b971810413cc2f", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/1.1/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": { "id": 12, "url": "https://patchwork.libcamera.org/api/1.1/users/12/?format=api", "username": "uajain", "first_name": "Umang", "last_name": "Jain", "email": "umang.jain@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/17261/mbox/", "series": [ { "id": 3455, "url": "https://patchwork.libcamera.org/api/1.1/series/3455/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3455", "date": "2022-08-30T13:33:21", "name": "[libcamera-devel,v2] libcamera: request: Rename Private::reuse() to Private::reset()", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3455/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17261/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17261/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2598DC3272\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 30 Aug 2022 13:33:31 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5879F61FBD;\n\tTue, 30 Aug 2022 15:33:30 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A7F4461F9C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 30 Aug 2022 15:33:28 +0200 (CEST)", "from umang.jainideasonboard.com (unknown\n\t[IPv6:2401:4900:1f3f:1548:78ac:4a3:edc3:c28a])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 016A4481;\n\tTue, 30 Aug 2022 15:33:26 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1661866410;\n\tbh=6yopac0kAiHtgCk3iBcjUgr+9VvAfiMSdCi8C+US/PM=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=AWIQKwOpExwygegPU4J18qq+61v84h+z2fUHJgJRabzjd04RIJWU0tMlrSp7mdIq+\n\t1sXItMx3gp/95w7AVOoFLs6/l3ygl+BKXDXycP4CW/G7WCDOf34QWKKR/4yHVYVhIb\n\tBaKZ6IrgvIwaaq+UrFCShKNirBWUgYf7jVkiFKtoygJM1VAB+6REihVXGrONaxgE7M\n\tkBLwUlF5Nb0Ft4NUGtIF41ybPOdbvkaaN3iYsCyEel39ATzEWmNd/NHbH9e5KTMdTg\n\t0WY2S2e+1ZQ7gOtiyRow3vgzPI0ZYuOEMxrAyxJLB0sdhgbOXP5JhrIr31TRkMV7+w\n\t0tLxLcolXw/6g==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1661866408;\n\tbh=6yopac0kAiHtgCk3iBcjUgr+9VvAfiMSdCi8C+US/PM=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=CrL6/LQ9/1NaQarxChrxq0FngcN/b98f/BfPQSdL3SPiync1DZy1NdWEbJkfsV9px\n\tyKE/aMnFXEhUFRnHRk5anM/+wlfRxDV6zSwnZfRbCM9GFdRz4gAN8lkCws1gYhWaTB\n\tyvcWrizRHOuFq0S42xgwjSoKTLzIRXaFQSn0G/6c=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"CrL6/LQ9\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 30 Aug 2022 19:03:21 +0530", "Message-Id": "<20220830133321.1107312-1-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.37.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2] libcamera: request: Rename\n\tPrivate::reuse() to Private::reset()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Umang Jain via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Umang Jain <umang.jain@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The Request::Private::reuse() is different from Request::reuse().\nIt reset the members of Request::Private to default values hence,\nrename it to more appropriate Request::Private::reset().\n\nUpdate the usage and documentation accordingly.\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\nChanges in v2:\n- Overhaul the patch by renaming Private::reuse() to reset()\n\nv1: [PATCH] libcamera: request: Fix doxygen warning\n---\n include/libcamera/internal/request.h | 2 +-\n src/libcamera/request.cpp | 9 ++++++---\n 2 files changed, 7 insertions(+), 4 deletions(-)", "diff": "diff --git a/include/libcamera/internal/request.h b/include/libcamera/internal/request.h\nindex 9dadd6c6..8c92a27a 100644\n--- a/include/libcamera/internal/request.h\n+++ b/include/libcamera/internal/request.h\n@@ -37,7 +37,7 @@ public:\n \tbool completeBuffer(FrameBuffer *buffer);\n \tvoid complete();\n \tvoid cancel();\n-\tvoid reuse();\n+\tvoid reset();\n \n \tvoid prepare(std::chrono::milliseconds timeout = 0ms);\n \tSignal<> prepared;\ndiff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex d2af1d22..949c556f 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -158,9 +158,12 @@ void Request::Private::cancel()\n }\n \n /**\n- * \\copydoc Request::reuse()\n+ * \\brief Reset the request internal data to default values\n+ *\n+ * After calling this function, all request internal data will have default\n+ * values as if the Request::Private instance had just been constructed.\n */\n-void Request::Private::reuse()\n+void Request::Private::reset()\n {\n \tsequence_ = 0;\n \tcancelled_ = false;\n@@ -380,7 +383,7 @@ void Request::reuse(ReuseFlag flags)\n {\n \tLIBCAMERA_TRACEPOINT(request_reuse, this);\n \n-\t_d()->reuse();\n+\t_d()->reset();\n \n \tif (flags & ReuseBuffers) {\n \t\tfor (auto pair : bufferMap_) {\n", "prefixes": [ "libcamera-devel", "v2" ] }