Patch Detail
Show a patch.
GET /api/1.1/patches/17245/?format=api
{ "id": 17245, "url": "https://patchwork.libcamera.org/api/1.1/patches/17245/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17245/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220829233017.2699444-6-paul.elder@ideasonboard.com>", "date": "2022-08-29T23:30:15", "name": "[libcamera-devel,v4,5/7] test: generated_serializer: Test Flags that is struct member", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "54fdf61f4b900b4477f730092a0daadb240a9f64", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17245/mbox/", "series": [ { "id": 3450, "url": "https://patchwork.libcamera.org/api/1.1/series/3450/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3450", "date": "2022-08-29T23:30:10", "name": "utils: ipc: Add support for enums and Flags", "version": 4, "mbox": "https://patchwork.libcamera.org/series/3450/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17245/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17245/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8CE17C327D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 29 Aug 2022 23:30:36 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 383F161FD5;\n\tTue, 30 Aug 2022 01:30:36 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1FC1661FCC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 30 Aug 2022 01:30:33 +0200 (CEST)", "from pyrite.mediacom.info (unknown\n\t[IPv6:2604:2d80:ad8a:9000:1bf9:855b:22de:3645])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C268D481;\n\tTue, 30 Aug 2022 01:30:31 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1661815836;\n\tbh=OPX9tVTE9tfS/uyxhwQfAiMdzY4kRBOzOH8oS2aB4vk=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=xO8s4/G9fgd3oumOGN9sRRwaTK/5lkX+qdKd+o0N0vJj6T2/uHUNcZ8BJOHXx0eEK\n\tSNWurNI0hmB7X7aJdIstBzO3xfvephL14d56e9qBn2A0o91OZWu0NrG69lg1MvEmGY\n\txdpKVBI0+fK3sJmtpFzwBUwLLYRm6OT7N5u1ZJzwCJ5JDzynO7VuRCo2SqFyMhGJ4i\n\tjg3GWPziguE3GyhlV3vrvToMJM6fLDWYvFZ88YqnzTumkI/RN2XW1W9ZhezG5hfNPo\n\tzn6n38LT/k6TvGLQN8enOqoiCbbepL4Oq/j9K/YdcRmYcjS6ei9POuY4WwSkmLro2x\n\tJwOjfZkkMyMDw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1661815832;\n\tbh=OPX9tVTE9tfS/uyxhwQfAiMdzY4kRBOzOH8oS2aB4vk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=nw5i3qD7AbnZd1dt8oXgfuY4CMgWz4uulDJwFQ616YLoD+d+FTDMljHjaRolKqG95\n\tkHC3FdbpjOlhPJc7MQZTVMgJSokZOR5q+AKuTns8OdIjmRopbvHhnIwvVto+iI6PNf\n\tnPDHV8Iy01mJazqieMn6tK7yMK+LQYLcnbCOkKwY=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"nw5i3qD7\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 29 Aug 2022 18:30:15 -0500", "Message-Id": "<20220829233017.2699444-6-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20220829233017.2699444-1-paul.elder@ideasonboard.com>", "References": "<20220829233017.2699444-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 5/7] test: generated_serializer: Test\n\tFlags that is struct member", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Paul Elder via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Paul Elder <paul.elder@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a Flags field to the test struct to test\nserialization/deserialization of Flags that are struct members.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n---\nNo change in v4\n\nChanges in v3:\n- add [scopedEnum] to enum ErrorFlags\n- s/[Flags]/[flags]/\n\nChanges in v2:\n- use new attribute-based mojom definition for Flags\n---\n .../generated_serializer_test.cpp | 19 +++++++++++++++++++\n .../include/libcamera/ipa/test.mojom | 8 ++++++++\n 2 files changed, 27 insertions(+)", "diff": "diff --git a/test/serialization/generated_serializer/generated_serializer_test.cpp b/test/serialization/generated_serializer/generated_serializer_test.cpp\nindex a4639a80..a2d71d62 100644\n--- a/test/serialization/generated_serializer/generated_serializer_test.cpp\n+++ b/test/serialization/generated_serializer/generated_serializer_test.cpp\n@@ -53,6 +53,11 @@ if (struct1.field != struct2.field) {\t\t\t\t\\\n \t\tt.i = 58527;\n \t\tt.c = ipa::test::IPAOperationInit;\n \n+\t\tFlags<ipa::test::ErrorFlags> flags;\n+\t\tflags |= ipa::test::ErrorFlags::Error1;\n+\t\tflags |= ipa::test::ErrorFlags::Error2;\n+\t\tt.f = flags;\n+\n \t\tstd::vector<uint8_t> serialized;\n \n \t\tstd::tie(serialized, ignore) =\n@@ -72,6 +77,10 @@ if (struct1.field != struct2.field) {\t\t\t\t\\\n \t\tTEST_FIELD_EQUALITY(t, u, i);\n \t\tTEST_FIELD_EQUALITY(t, u, c);\n \n+\t\tif (t.f != u.f) {\n+\t\t\tcerr << \"Flags f field incorrect\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n \n \t\t/* Test vector of generated structs */\n \t\tstd::vector<ipa::test::TestStruct> v = { t, u };\n@@ -96,12 +105,22 @@ if (struct1.field != struct2.field) {\t\t\t\t\\\n \t\tTEST_FIELD_EQUALITY(v[0], w[0], i);\n \t\tTEST_FIELD_EQUALITY(v[0], w[0], c);\n \n+\t\tif (v[0].f != w[0].f) {\n+\t\t\tcerr << \"Flags f field incorrect\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n \t\tTEST_FIELD_EQUALITY(v[1], w[1], s1);\n \t\tTEST_FIELD_EQUALITY(v[1], w[1], s2);\n \t\tTEST_FIELD_EQUALITY(v[1], w[1], s3);\n \t\tTEST_FIELD_EQUALITY(v[1], w[1], i);\n \t\tTEST_FIELD_EQUALITY(v[1], w[1], c);\n \n+\t\tif (v[1].f != w[1].f) {\n+\t\t\tcerr << \"Flags f field incorrect\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n \t\treturn TestPass;\n \t}\n \ndiff --git a/test/serialization/generated_serializer/include/libcamera/ipa/test.mojom b/test/serialization/generated_serializer/include/libcamera/ipa/test.mojom\nindex 73081b40..a988c996 100644\n--- a/test/serialization/generated_serializer/include/libcamera/ipa/test.mojom\n+++ b/test/serialization/generated_serializer/include/libcamera/ipa/test.mojom\n@@ -9,6 +9,13 @@ enum IPAOperationCode {\n \tIPAOperationStop,\n };\n \n+[scopedEnum] enum ErrorFlags {\n+\tError1 = 0x1,\n+\tError2 = 0x2,\n+\tError3 = 0x4,\n+\tError4 = 0x8,\n+};\n+\n struct IPASettings {};\n \n struct TestStruct {\n@@ -19,6 +26,7 @@ struct TestStruct {\n \tint32 i;\n \tstring s3;\n \tIPAOperationCode c;\n+\t[flags] ErrorFlags f;\n };\n \n interface IPATestInterface {\n", "prefixes": [ "libcamera-devel", "v4", "5/7" ] }