Patch Detail
Show a patch.
GET /api/1.1/patches/17238/?format=api
{ "id": 17238, "url": "https://patchwork.libcamera.org/api/1.1/patches/17238/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17238/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220829185849.1884517-3-marvin.schmidt1987@gmail.com>", "date": "2022-08-29T18:58:48", "name": "[libcamera-devel,2/3] ipa: ipu3: Remove redundant call of std::string::c_str()", "commit_ref": "252561e77f3cfc2b2792a389a03f4f6722b09803", "pull_url": null, "state": "accepted", "archived": false, "hash": "27bb0e6706146be1b7072ca0ad1dba229038911f", "submitter": { "id": 51, "url": "https://patchwork.libcamera.org/api/1.1/people/51/?format=api", "name": "Marvin Schmidt", "email": "marvin.schmidt1987@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17238/mbox/", "series": [ { "id": 3449, "url": "https://patchwork.libcamera.org/api/1.1/series/3449/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3449", "date": "2022-08-29T18:58:46", "name": "Remove redundant calls to std::string::c_str()", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3449/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17238/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17238/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 13EBEC327D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 29 Aug 2022 18:59:07 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BDDD361FC9;\n\tMon, 29 Aug 2022 20:59:06 +0200 (CEST)", "from mail-ed1-x530.google.com (mail-ed1-x530.google.com\n\t[IPv6:2a00:1450:4864:20::530])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 13F4261FC3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 29 Aug 2022 20:59:03 +0200 (CEST)", "by mail-ed1-x530.google.com with SMTP id z41so3941094ede.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 29 Aug 2022 11:59:03 -0700 (PDT)", "from pythagoras.local\n\t(dynamic-077-003-143-111.77.3.pool.telefonica.de. [77.3.143.111])\n\tby smtp.gmail.com with ESMTPSA id\n\t17-20020a170906211100b006fef0c7072esm4828136ejt.144.2022.08.29.11.59.01\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 29 Aug 2022 11:59:01 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1661799546;\n\tbh=Jos+LhCNs18cwF+Un9F40PUKpM8/yLawM1pih7TPZus=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=wwXIMNr9Eu1shmC7VEIik5XOTPAaJBLTOjGSTYzcpoZApulczaHn+M1JEkRihWmV9\n\tZw9qMHTAyIK8Uv83z0DgI0+P4vbKNfDz86HiUA0wJ4TC0u1kbG5MA+9cG+E4wBJ4UE\n\trlEYWmrfqKPCj9ONOxiRcgVJU+LQVRbvzbXC1qeb0FRHU2B/G7K68d/LiM9GvnCkok\n\tCqO7hV+UkCD8si9ui9vT3VTw3Tkc33lm6TTbhTcpAwTb/XzAh2oVI6/pwKNTyId8q4\n\tPWrYFk3GJEwBA7elGBn3omzKupBjf+9RuYBgvPz85i9gRrrnS4caK1Zn4urgmxVM/U\n\tXSmAywIhBrbBg==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc;\n\tbh=2OlmZP7JRnr9HHxNIH683hvLfcTV3E+NkjsSXmg0f3Q=;\n\tb=bOqUaBLlt+XdCMmCqw5KdfHZIo+Dg2Y6dHGPT6AeSb8FEUdTGs8nKoXZKBlYlw/iHW\n\t8iDThDxHdESJDBDIuIbLaDpE9NEqHzOEIDbwJwy4rkO1SoWpDx9gWIYhi3GmWK3Rx7mI\n\t8GSmKtMc4nwf4U0YzoZs72OZlWobwWVJjmN2DMtXqwnjJZlGWGZFmjr73As/mp/+WoDt\n\tYnJExY/FqHeb3oQcWiOQ3HKeXBsjkRsMyhXxZBTkdVZuseypykDQu9QgI8aTfsPoRhgN\n\trRKlb9cgLCcmgw6/7lLbv17cf8VREyCNm9hc7vgJQ2Q+dAv1RpvPMTFP/AqpmPAY+as/\n\t6QGw==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"bOqUaBLl\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc;\n\tbh=2OlmZP7JRnr9HHxNIH683hvLfcTV3E+NkjsSXmg0f3Q=;\n\tb=yLBpf//9cSHlB9KLtRTnOOJrv0gcyrdxO9JeiEjW05DFDIVg9xd3ETlziidYpRsn2B\n\tP6GbhxE+SKVF7jaouIBkxMFNgS2+OBwMkpquh54RTNzYJ/AhxgWnByGE3VxtJNd14mpp\n\tE1LTuEGhdeEPotCG5mx3LlVBwM8e1MyUVcBPIOWBQXcCtHST19HHMDWIWg1m+sxwQy5k\n\t3z9u9Moune96GNj1q3ihVjPnTSKcUHMsB/cSFd6xbKg+WvdU6fozxVdQcK6jTF1oyZev\n\twrA27YfKzjzpzDxVF3iUP3mqDlr2S5OrvRx1WxIuZTIkAE4eiRXqtwdm+0reW4HYVm4p\n\tm1wA==", "X-Gm-Message-State": "ACgBeo0AEhVyG1xPImLC42NaLgkM/E3i9fBZHpwmbKzQzo907rK0fA92\n\tZvviZ1uScBalZ97iKS8y0p45pWcWqok=", "X-Google-Smtp-Source": "AA6agR52BLNCvQR92rNV4oe3NeW1pU6VxZhaVBHx0waVNdvEuoDK+ODuHlkCvA8dZMutYEY3fpoBnw==", "X-Received": "by 2002:a05:6402:290d:b0:448:32f5:1e7 with SMTP id\n\tee13-20020a056402290d00b0044832f501e7mr8779461edb.50.1661799542383; \n\tMon, 29 Aug 2022 11:59:02 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 29 Aug 2022 20:58:48 +0200", "Message-Id": "<20220829185849.1884517-3-marvin.schmidt1987@gmail.com>", "X-Mailer": "git-send-email 2.37.2", "In-Reply-To": "<20220829185849.1884517-1-marvin.schmidt1987@gmail.com>", "References": "<20220829185849.1884517-1-marvin.schmidt1987@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 2/3] ipa: ipu3: Remove redundant call of\n\tstd::string::c_str()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Marvin Schmidt via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Marvin Schmidt <marvin.schmidt1987@gmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The constructor of libcamera::File takes a const reference to a std::string\nand clang-tidy's readability-redundant-string-cstr check warns about it:\n\n> ../src/ipa/ipu3/ipu3.cpp:330:12: warning: redundant call to 'c_str' [readability-redundant-string-cstr]\n> File file(settings.configurationFile.c_str());\n> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n> settings.configurationFile\n\nSigned-off-by: Marvin Schmidt <marvin.schmidt1987@gmail.com>\n---\n src/ipa/ipu3/ipu3.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex e37b2fa0..e3c1e816 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -327,7 +327,7 @@ int IPAIPU3::init(const IPASettings &settings,\n \tcontext_.configuration.sensor.lineDuration = sensorInfo.lineLength * 1.0s / sensorInfo.pixelRate;\n \n \t/* Load the tuning data file. */\n-\tFile file(settings.configurationFile.c_str());\n+\tFile file(settings.configurationFile);\n \tif (!file.open(File::OpenModeFlag::ReadOnly)) {\n \t\tint ret = file.error();\n \t\tLOG(IPAIPU3, Error)\n", "prefixes": [ "libcamera-devel", "2/3" ] }