Patch Detail
Show a patch.
GET /api/1.1/patches/17223/?format=api
{ "id": 17223, "url": "https://patchwork.libcamera.org/api/1.1/patches/17223/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17223/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220829100414.28404-2-laurent.pinchart@ideasonboard.com>", "date": "2022-08-29T10:04:12", "name": "[libcamera-devel,1/3] pipeline: uvcvideo: Add color space support", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "18de7e38400472d2cb6da7dd04e64a63a0cd3392", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17223/mbox/", "series": [ { "id": 3445, "url": "https://patchwork.libcamera.org/api/1.1/series/3445/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3445", "date": "2022-08-29T10:04:11", "name": "Misc color space plumbing improvements", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3445/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17223/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17223/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6C617C3272\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 29 Aug 2022 10:04:28 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2327661FC4;\n\tMon, 29 Aug 2022 12:04:28 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B3ED761FBC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 29 Aug 2022 12:04:25 +0200 (CEST)", "from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3F3DFA1D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 29 Aug 2022 12:04:25 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1661767468;\n\tbh=HXSEU9XbPmNwni/4BnhJsezUu0yOUCWcVZhGYF5g/1E=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=tn+rgAYxOz0b5qbKLK6lkjbAcRuLV7nxdT2u1I4eFfzemO6g4WFYerE5eG01xjMxI\n\tsO/gN3uDj8DUFyzPNUbnRLQExnUWlDQ6dKvRFIxb9105xybHongEPH9wz4SqpRPE0f\n\tfAY9qEhd+1ui5598/UjvEgQhDaBSm3AZFYJYmS2vods6dYiASDbtatTy8BeqHVek9Z\n\tP9V/rYlmwmVpX80s9FbxFiJN3PP8Ehpunoa5tNFbeO8/9Tp5JT5jAs2nunOmr28Ely\n\t6jBeTVHE6ANXqxM0tLOd5/fDdGSu8evLIxbYU5fioWkaneJGyLZVpV2uexdVL9lMFT\n\ta83mk9adAuFCA==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1661767465;\n\tbh=HXSEU9XbPmNwni/4BnhJsezUu0yOUCWcVZhGYF5g/1E=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=EZRjMoA92AZHU6SH1ZsuyHwurq1eZlC+qIupamT99jAMOiGktlkR6sdsgRuzGly/a\n\tvhJOMduFNChwk89Faxl1rd8NUqpbT6DBQveC81AoGJY2k9dWgkhL7Kuv8Is3DqdBD4\n\tyn4p5jmD3bMpBVch2eKbCdBoVnxj+HZ3oDBZM59A=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"EZRjMoA9\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 29 Aug 2022 13:04:12 +0300", "Message-Id": "<20220829100414.28404-2-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20220829100414.28404-1-laurent.pinchart@ideasonboard.com>", "References": "<20220829100414.28404-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/3] pipeline: uvcvideo: Add color space\n\tsupport", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add support for color space to the uvcvideo pipeline handler. UVC\ndevices have a fixed color space per format, so only the validate()\nfunction needs to be extended to retrieve the color space from the\nkernel. There is no need to pass the value back to the driver in\nconfigure().\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\nindex 9cbf126aea57..2ae640a31f68 100644\n--- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n+++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n@@ -159,6 +159,11 @@ CameraConfiguration::Status UVCCameraConfiguration::validate()\n \tcfg.stride = format.planes[0].bpl;\n \tcfg.frameSize = format.planes[0].size;\n \n+\tif (cfg.colorSpace != format.colorSpace) {\n+\t\tcfg.colorSpace = format.colorSpace;\n+\t\tstatus = Adjusted;\n+\t}\n+\n \treturn status;\n }\n \n", "prefixes": [ "libcamera-devel", "1/3" ] }