Patch Detail
Show a patch.
GET /api/1.1/patches/17215/?format=api
{ "id": 17215, "url": "https://patchwork.libcamera.org/api/1.1/patches/17215/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17215/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220826173426.633461-1-Rauch.Christian@gmx.de>", "date": "2022-08-26T17:34:26", "name": "[libcamera-devel] libcamera: control: initialise control info to ControlTypeNone by default", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "18e92f143aea1159abf2e7c858d419d0c08fd2dc", "submitter": { "id": 111, "url": "https://patchwork.libcamera.org/api/1.1/people/111/?format=api", "name": "Christian Rauch", "email": "Rauch.Christian@gmx.de" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17215/mbox/", "series": [ { "id": 3440, "url": "https://patchwork.libcamera.org/api/1.1/series/3440/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3440", "date": "2022-08-26T17:34:26", "name": "[libcamera-devel] libcamera: control: initialise control info to ControlTypeNone by default", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3440/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17215/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17215/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CDEA5C3272\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 26 Aug 2022 17:34:30 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9B6C361FBB;\n\tFri, 26 Aug 2022 19:34:30 +0200 (CEST)", "from mout.gmx.net (mout.gmx.net [212.227.15.18])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9367361FA2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 26 Aug 2022 19:34:28 +0200 (CEST)", "from voyager ([88.152.184.103]) by mail.gmx.net (mrgmx005\n\t[212.227.17.190]) with ESMTPSA (Nemesis) id 1MFsUv-1oe45L0Fzz-00HMFn;\n\tFri, 26 Aug 2022 19:34:28 +0200" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1661535270;\n\tbh=tIaonYy4IBbM0ubtpXEfksF3Htg5EcUEV2iQclBuypU=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=OiZMOfx7uRGxcESKI4PxQuxYivSJSr4DiyNTLkx14Lo0xKjparc9P1jNEOS9jAyH3\n\tkI7atcgiNZXCftR6xFUT7NpavHyf40MHwmN2FwAWeFsNw7nUVpNLYBWSu9tPOuCd7q\n\t+kLpadmiITDihf/NiiG2u3zESTFTC2OdDmJpztAs8u2vT1LUcblvFhwfCZsGtEs2XS\n\tUWRu7gTi/lxAOcg+FwVZPvjrjmpuWr3AqnlJRwsdTGHS0LEpxWqpUK3DJRHj934uK/\n\teSdbdSOsPUrGM7uww273cLSIUWbgSdsHlB04XN5lbOArGrZCSbq5Z9cJEJVDyJyVoS\n\tehVHrPcY8EGYw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;\n\ts=badeba3b8450; t=1661535268;\n\tbh=tIaonYy4IBbM0ubtpXEfksF3Htg5EcUEV2iQclBuypU=;\n\th=X-UI-Sender-Class:From:To:Cc:Subject:Date;\n\tb=CchNbTOnE0oRylwixKeMvEB/7118TvzB3QPitM9djGv5CvscRjgkiR/Vw0ANQFd7L\n\t1kJATTJVbAnfhEZiybJy8Laqq9r1fYnvW36b3o+asV8rbVGsd8A/0fZ83RQmjPnCZt\n\tClVFjZiS+IoAt7RVcKNhaXVtYuBuYiBWVyP7iJ18=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=gmx.net header.i=@gmx.net\n\theader.b=\"CchNbTOn\"; dkim-atps=neutral", "X-UI-Sender-Class": "01bb95c1-4bf8-414a-932a-4f6e2808ef9c", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 26 Aug 2022 19:34:26 +0200", "Message-Id": "<20220826173426.633461-1-Rauch.Christian@gmx.de>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "quoted-printable", "X-Provags-ID": "V03:K1:FXo0H5VVmz19r/vu7EwLvRnBKeZIMFcKnxGSwXoEEEuEYCDR1up\n\tEUWGZEtcp2iM5m2rWgk3TcdD3TwTuPDR7X2FREzqRwT/BpW152Ej7czeOoWaVC2J0F5rLGb\n\tNiX+xxQmFTo7U816S5SA3E/xEF5RIrhMB0EDLaN5HwkBlWSZP3pFvKAxzdz5bZuu8lQn3fu\n\tvF/JwMCIY+OqITTP4gpHw==", "X-Spam-Flag": "NO", "X-UI-Out-Filterresults": "notjunk:1; V03:K0:deZ5BzyUbL0=:XwjoL+6jOlqSUqRNbYupQB\n\tMdphj2bNwMoMhJbSLXO17jiRj79Mapw77jdDYi87rmfLbUEKWck2TRdX7SQnfW1v5+zPiSZk2\n\trYwhlUMi2tLQ6S1PmhR837E3MYqsQ8ozhzZASHhqgK8M0Vq+po5Bn8FBd9oyq8GGb7k4KNbiL\n\tOb9nUB5GMSjIST9irm72fixb0LpY/osq9I3vFQqE/QXfjy2MxazqnsMPZITWqHpR4cvxSvIZI\n\tEfwokuBzTMOtbuMwcJuhYBl3885k2R+xAmI3zmYX8NM/W/Ab20f2Bl16Rkhczd9ji/CjbXOib\n\tFzDwh3KNz06nG3EfhKY6nC7WThFV2ClO9VxF+CjRAmLNOaZt56nogc3F/oLFYKQLSzqI93d8d\n\tz+LbvT+fykcr6mldNKJcS8ROrjDPozPqE9kpm6KPjFoGAo4HjxiwlPzdtuLjkDcLKOwGrJMf8\n\tsS4P9Ou5OCsWcWRA0ellrjKz/MoW/0OPxsbt1+P9cZ8DuG7Gz9F5QJHkJLnHn4f3LNqM9/7De\n\tA46WofQHe51g2vkEMzkZ+FruCAtrJFcyAg4RAQNAiY2SuqGleafyJ02hJpMFkchncTHT8vFj9\n\tO/ty3uFtM/FyhDLcEQzq7VjQXnn/7ywpwo24dbG+epoqqS49b2r8CUdVYQA9XNblTa1HNOVy1\n\tGSixA7NW2bbzump0QIaSqQ1ioT5ByGqQx+JzZVnSvp6H6BVoa4QMr8FnsRy4GNrf1qwv9q63E\n\tmbS0DHrvQT5MPEH2hMEUETogxkrEuIoyTHVD6r8wwCN5Lo685UFGxGchJVp94EwPOb62RtfFc\n\tj599PnZQw8nRKJnZEyWo0Ryv0+XvwGwwk6xMRCRLN4pu6y7pHMy/I8ym65J+eie5GcbH8afD1\n\tPR8+dunM17YF/v+Ks9nIp0WG87u2kiKbpUr9n1UqmQW0Z+4ID0vw2bDi3efKMNzcmsN9YHc25\n\t/RTF/RUDALs3r0LTIFt4T+eQEMFO+H+v8zKBkkMzfuqcuPXueASZq02MPhrFVZ3TF/ojO+C20\n\taWIBZ90gdvlJLe4UCq27xAZbYUo955cVGBXFNAgdHqGvEOFSGpLk26Uqsx8cYGgSG+6SB3xl4\n\thOe96eEX9QmvXgRnODWc6Qz2Wl7+qetz597YMhg+IyMUsJntsPbRi0mEg==", "Subject": "[libcamera-devel] [PATCH] libcamera: control: initialise control\n\tinfo to ControlTypeNone by default", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Christian Rauch via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Christian Rauch <Rauch.Christian@gmx.de>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The default ControlInfo constructor allows to partially initialised the\nmin/max/def values. Uninitialised values are assigned to 0 by default. This\nimplicit initialisation makes it impossible to distinguish between and\nuninitialised and an explicitly 0-initialised ControlValue.\n\nDefault construct the ControlValue in the ControlInfo default contructor to\nexplicitly represent uninitialised values by the ControlTypeNone type.\n\nSigned-off-by: Christian Rauch <Rauch.Christian@gmx.de>\n---\n include/libcamera/controls.h | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\n--\n2.34.1", "diff": "diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\nindex ebc168fc..38d0a3e8 100644\n--- a/include/libcamera/controls.h\n+++ b/include/libcamera/controls.h\n@@ -268,9 +268,9 @@ private:\n class ControlInfo\n {\n public:\n-\texplicit ControlInfo(const ControlValue &min = 0,\n-\t\t\t const ControlValue &max = 0,\n-\t\t\t const ControlValue &def = 0);\n+\texplicit ControlInfo(const ControlValue &min = {},\n+\t\t\t const ControlValue &max = {},\n+\t\t\t const ControlValue &def = {});\n \texplicit ControlInfo(Span<const ControlValue> values,\n \t\t\t const ControlValue &def = {});\n \texplicit ControlInfo(std::set<bool> values, bool def);\n", "prefixes": [ "libcamera-devel" ] }