Patch Detail
Show a patch.
GET /api/1.1/patches/17207/?format=api
{ "id": 17207, "url": "https://patchwork.libcamera.org/api/1.1/patches/17207/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17207/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220826154419.4099372-2-paul.elder@ideasonboard.com>", "date": "2022-08-26T15:44:13", "name": "[libcamera-devel,v3,1/7] test: generated_serializer: Test enum that is struct member", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "937edd6121e561723907231f20a9f2fc6589f043", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17207/mbox/", "series": [ { "id": 3438, "url": "https://patchwork.libcamera.org/api/1.1/series/3438/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3438", "date": "2022-08-26T15:44:12", "name": "utils: ipc: Add support for enums and Flags", "version": 3, "mbox": "https://patchwork.libcamera.org/series/3438/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17207/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17207/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C9712C0DA4\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 26 Aug 2022 15:44:35 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7F33D61FC8;\n\tFri, 26 Aug 2022 17:44:35 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5D3F161FBB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 26 Aug 2022 17:44:31 +0200 (CEST)", "from pyrite.mediacom.info (unknown\n\t[IPv6:2604:2d80:ad8a:9000:1bf9:855b:22de:3645])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DCCFE3F1;\n\tFri, 26 Aug 2022 17:44:29 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1661528675;\n\tbh=vWdOx//zLDaQIWBu9M75u2XVZc87j7dCUeLyt2XafUI=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=y8hyU8zFFjdBLZDDr3Gyj49eJTZRl5I7FsaqMv41iKVaSU/B1kOwUDH8VRwjQeYed\n\tfhE8sm72eVAWHPf23OueBzorCcPKkniUkP/pmK0QqW4KyVIIYv88BnEgjK88poirKf\n\tyr7CpF41PckxQ25pGCisH+hM94/FKCIzhqCe/UwB5KTK60Ryih2jqW9mJY/93VI7Vk\n\tNLgjly4/m2ozgJbsu8ti4UaEcmxp+rDyWvuSFQyyxATUUdSy1xzklYazcMwGwnDoeO\n\tLepks7r2yCjDOuHEUsDQ0vxy4ZscRnEJE9Y3mdmVEQVtY3wV7Qm7wyBqTcfa8caq0X\n\trbtE/3AEJ7QNg==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1661528671;\n\tbh=vWdOx//zLDaQIWBu9M75u2XVZc87j7dCUeLyt2XafUI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=bZgtJHpbgGVFQ4noqK14fLtd46TaPyvTjGpCbmUKOfLwJq7sW6SegRM29hlh3Sos6\n\tB5TAcqKaHlvKZAKYfLfn6V1VVQODv1AKMS6nFXGTrBIPbiOX8rBVJy66vPkL13Thgb\n\tSfJq/QEx7LZBez0A7CYBsU3J0T3X/2iiVn/hVyZk=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"bZgtJHpb\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 26 Aug 2022 10:44:13 -0500", "Message-Id": "<20220826154419.4099372-2-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20220826154419.4099372-1-paul.elder@ideasonboard.com>", "References": "<20220826154419.4099372-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 1/7] test: generated_serializer: Test\n\tenum that is struct member", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Paul Elder via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Paul Elder <paul.elder@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add an enum field to the test struct member to test\nserialization/deserialization of enums that are struct members.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n---\nNo change in v3\n\nNo change in v2\n---\n .../generated_serializer/generated_serializer_test.cpp | 4 ++++\n .../generated_serializer/include/libcamera/ipa/test.mojom | 1 +\n 2 files changed, 5 insertions(+)", "diff": "diff --git a/test/serialization/generated_serializer/generated_serializer_test.cpp b/test/serialization/generated_serializer/generated_serializer_test.cpp\nindex 698c81d6..a4639a80 100644\n--- a/test/serialization/generated_serializer/generated_serializer_test.cpp\n+++ b/test/serialization/generated_serializer/generated_serializer_test.cpp\n@@ -51,6 +51,7 @@ if (struct1.field != struct2.field) {\t\t\t\t\\\n \t\tt.s2 = \"goodbye\";\n \t\tt.s3 = \"lorem ipsum\";\n \t\tt.i = 58527;\n+\t\tt.c = ipa::test::IPAOperationInit;\n \n \t\tstd::vector<uint8_t> serialized;\n \n@@ -69,6 +70,7 @@ if (struct1.field != struct2.field) {\t\t\t\t\\\n \t\tTEST_FIELD_EQUALITY(t, u, s2);\n \t\tTEST_FIELD_EQUALITY(t, u, s3);\n \t\tTEST_FIELD_EQUALITY(t, u, i);\n+\t\tTEST_FIELD_EQUALITY(t, u, c);\n \n \n \t\t/* Test vector of generated structs */\n@@ -92,11 +94,13 @@ if (struct1.field != struct2.field) {\t\t\t\t\\\n \t\tTEST_FIELD_EQUALITY(v[0], w[0], s2);\n \t\tTEST_FIELD_EQUALITY(v[0], w[0], s3);\n \t\tTEST_FIELD_EQUALITY(v[0], w[0], i);\n+\t\tTEST_FIELD_EQUALITY(v[0], w[0], c);\n \n \t\tTEST_FIELD_EQUALITY(v[1], w[1], s1);\n \t\tTEST_FIELD_EQUALITY(v[1], w[1], s2);\n \t\tTEST_FIELD_EQUALITY(v[1], w[1], s3);\n \t\tTEST_FIELD_EQUALITY(v[1], w[1], i);\n+\t\tTEST_FIELD_EQUALITY(v[1], w[1], c);\n \n \t\treturn TestPass;\n \t}\ndiff --git a/test/serialization/generated_serializer/include/libcamera/ipa/test.mojom b/test/serialization/generated_serializer/include/libcamera/ipa/test.mojom\nindex 5f200885..73081b40 100644\n--- a/test/serialization/generated_serializer/include/libcamera/ipa/test.mojom\n+++ b/test/serialization/generated_serializer/include/libcamera/ipa/test.mojom\n@@ -18,6 +18,7 @@ struct TestStruct {\n \tstring s2;\n \tint32 i;\n \tstring s3;\n+\tIPAOperationCode c;\n };\n \n interface IPATestInterface {\n", "prefixes": [ "libcamera-devel", "v3", "1/7" ] }