Patch Detail
Show a patch.
GET /api/1.1/patches/17193/?format=api
{ "id": 17193, "url": "https://patchwork.libcamera.org/api/1.1/patches/17193/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17193/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220823183856.17944-1-laurent.pinchart@ideasonboard.com>", "date": "2022-08-23T18:38:56", "name": "[libcamera-devel] gstreamer: Add support for additional RGB formats", "commit_ref": "868ab2287da2def1cc6414c27d9e26fd1547f353", "pull_url": null, "state": "accepted", "archived": false, "hash": "8caf2c0ef7bc9eb9243dd3e5f53f58adc53ee794", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17193/mbox/", "series": [ { "id": 3433, "url": "https://patchwork.libcamera.org/api/1.1/series/3433/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3433", "date": "2022-08-23T18:38:56", "name": "[libcamera-devel] gstreamer: Add support for additional RGB formats", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3433/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17193/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17193/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B1BAFC0DA4\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 23 Aug 2022 18:39:04 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EC66761FA1;\n\tTue, 23 Aug 2022 20:39:03 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F05D3603E3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 23 Aug 2022 20:39:01 +0200 (CEST)", "from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4D2DB2B3;\n\tTue, 23 Aug 2022 20:39:01 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1661279944;\n\tbh=gMU24uuc7uQh3QLcRHI5Obz0dkYDzQjviiAivRChlBI=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=UDj15M6J1FEbA7sFhV4OFGtqKuH9MeuqnV+l578ZUDNAbXUI11E5jXW45bAV/7nwd\n\tdMVBTOHVBkYGI9lkENAsNGrXATBXefxU1WCOjIIht+CFJ+cY9j++e+nS7kEB3kFG7b\n\t5jnPb3FFgQUdAyYbmyFv7ou5BE6yN/CDJeJNN1QM8YeaY9JocGGAs6hKl7mc3QEgI8\n\ts6H71XPQUpog/ihCjYQ981wBM1eyiCrXutrs8pnlyzZv3s2w/KK9BOT+WDGLjDsZjp\n\te52q/Rf39YSS+fo12I/ZEXGa7hSaennG9yixYEfxqji6rsu2t6fMSdI6VzfU+aSSqN\n\tPugJJMEMlWvOQ==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1661279941;\n\tbh=gMU24uuc7uQh3QLcRHI5Obz0dkYDzQjviiAivRChlBI=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=MhOrPHiQ0T3Ykb2j4ffyRzmzbmPB4GX6Yemv5B5083qlDPpwuM4DTa5ve6+6LvCtw\n\ttr/xJsJ0UB9yU9U+HXtkFnQU5FjUMdBHm/KhenY6LfbtVPIK537gJxS/peb6cpCwrL\n\t/+5BtqGAHMu0TphG7KRuaaCDQqj5XggmlK3chljI=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"MhOrPHiQ\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 23 Aug 2022 21:38:56 +0300", "Message-Id": "<20220823183856.17944-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] gstreamer: Add support for additional RGB\n\tformats", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "libcamerasrc only supports three RGB formats. Adding the other RGB\nformats supported by libcamera is trivial, do so.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\nI haven't tested this yet as I don't have a board hooked up that can\ncapture these formats. If someone can test it with an OV5640 sensor on\nan i.MX8MP, that would be great, otherwise I'll get to it in the not too\ndistant future.\n---\n src/gstreamer/gstlibcamera-utils.cpp | 14 +++++++++++++-\n 1 file changed, 13 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\nindex c97c0d438de2..5a21a391c698 100644\n--- a/src/gstreamer/gstlibcamera-utils.cpp\n+++ b/src/gstreamer/gstlibcamera-utils.cpp\n@@ -19,9 +19,21 @@ static struct {\n \t/* Compressed */\n \t{ GST_VIDEO_FORMAT_ENCODED, formats::MJPEG },\n \n-\t/* RGB */\n+\t/* RGB16 */\n+\t{ GST_VIDEO_FORMAT_RGB16, formats::RGB565 },\n+\n+\t/* RGB24 */\n \t{ GST_VIDEO_FORMAT_RGB, formats::BGR888 },\n \t{ GST_VIDEO_FORMAT_BGR, formats::RGB888 },\n+\n+\t/* RGB32 */\n+\t{ GST_VIDEO_FORMAT_BGRx, formats::XRGB8888 },\n+\t{ GST_VIDEO_FORMAT_RGBx, formats::XBGR8888 },\n+\t{ GST_VIDEO_FORMAT_xBGR, formats::RGBX8888 },\n+\t{ GST_VIDEO_FORMAT_xRGB, formats::BGRX8888 },\n+\t{ GST_VIDEO_FORMAT_BGRA, formats::ARGB8888 },\n+\t{ GST_VIDEO_FORMAT_RGBA, formats::ABGR8888 },\n+\t{ GST_VIDEO_FORMAT_ABGR, formats::RGBA8888 },\n \t{ GST_VIDEO_FORMAT_ARGB, formats::BGRA8888 },\n \n \t/* YUV Semiplanar */\n", "prefixes": [ "libcamera-devel" ] }