Patch Detail
Show a patch.
GET /api/1.1/patches/1719/?format=api
{ "id": 1719, "url": "https://patchwork.libcamera.org/api/1.1/patches/1719/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1719/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<8ad5a0874203dacfd488fe6827e3feab14dc959c.1564513804.git.helen.koike@collabora.com>", "date": "2019-07-30T19:10:07", "name": "[libcamera-devel,v2] libcamera: pipeline: RKISP1 configure isp output pad", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "167a67051ad287af50b721d156aa99ad2c2c7388", "submitter": { "id": 20, "url": "https://patchwork.libcamera.org/api/1.1/people/20/?format=api", "name": "Helen Koike", "email": "helen.koike@collabora.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1719/mbox/", "series": [ { "id": 442, "url": "https://patchwork.libcamera.org/api/1.1/series/442/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=442", "date": "2019-07-30T19:10:07", "name": "[libcamera-devel,v2] libcamera: pipeline: RKISP1 configure isp output pad", "version": 2, "mbox": "https://patchwork.libcamera.org/series/442/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1719/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1719/checks/", "tags": {}, "headers": { "Return-Path": "<helen.koike@collabora.com>", "Received": [ "from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3F91860E3A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 30 Jul 2019 21:11:11 +0200 (CEST)", "from floko.floko.floko (unknown\n\t[IPv6:2804:431:c7f1:ce2f:ec1:e6e6:2e9f:e76e])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits))\n\t(No client certificate requested) (Authenticated sender: koike)\n\tby bhuna.collabora.co.uk (Postfix) with ESMTPSA id 62D0928B8A4;\n\tTue, 30 Jul 2019 20:11:09 +0100 (BST)" ], "From": "Helen Koike <helen.koike@collabora.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "laurent.pinchart@ideasonboard.com, kernel@collabora.com,\n\tHelen Koike <helen.koike@collabora.com>", "Date": "Tue, 30 Jul 2019 16:10:07 -0300", "Message-Id": "<8ad5a0874203dacfd488fe6827e3feab14dc959c.1564513804.git.helen.koike@collabora.com>", "X-Mailer": "git-send-email 2.22.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2] libcamera: pipeline: RKISP1 configure\n\tisp output pad", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 30 Jul 2019 19:11:11 -0000" }, "content": "ISP output pad should be set to YUYV8_2X8 for non-bayer output format.\nBayer formats are not listed in RkISP1CameraConfiguration::validate(),\nonly non-bayer are listed, so we can set YUYV8_2X8 directly.\nThis need to be changed if we add support for bayer output with\nlibcamera.\n\nSigned-off-by: Helen Koike <helen.koike@collabora.com>\n\n---\n\nHi,\n\nI'm re-sending this patch standalone as Laurent suggested.\n\nThanks\nHelen\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 14 ++++++++++++++\n 1 file changed, 14 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex efa9604..bc7cb3f 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -286,6 +286,8 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n \tif (ret < 0)\n \t\treturn ret;\n \n+\tLOG(RkISP1, Debug) << \"Configuring ISP input pad with \" << format.toString();\n+\n \tret = dphy_->getFormat(1, &format);\n \tif (ret < 0)\n \t\treturn ret;\n@@ -294,6 +296,18 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n \tif (ret < 0)\n \t\treturn ret;\n \n+\tLOG(RkISP1, Debug) << \"ISP input pad configured with \" << format.toString();\n+\n+\t/* YUYV8_2X8 is required in ISP pad 1 for non-bayer output */\n+\tformat.mbus_code = MEDIA_BUS_FMT_YUYV8_2X8;\n+\tLOG(RkISP1, Debug) << \"Configuring ISP output pad with \" << format.toString();\n+\n+\tret = isp_->setFormat(2, &format);\n+\tif (ret < 0)\n+\t\treturn ret;\n+\n+\tLOG(RkISP1, Debug) << \"ISP output pad configured with \" << format.toString();\n+\n \tV4L2DeviceFormat outputFormat = {};\n \toutputFormat.fourcc = cfg.pixelFormat;\n \toutputFormat.size = cfg.size;\n", "prefixes": [ "libcamera-devel", "v2" ] }