Patch Detail
Show a patch.
GET /api/1.1/patches/17188/?format=api
{ "id": 17188, "url": "https://patchwork.libcamera.org/api/1.1/patches/17188/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17188/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220823174314.14881-3-laurent.pinchart@ideasonboard.com>", "date": "2022-08-23T17:43:10", "name": "[libcamera-devel,2/6] libcamera: color_space: Reorder members in the same order as the header", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "45f0cc6b0f7e0f7c87764d5eb8bea65358295dd3", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17188/mbox/", "series": [ { "id": 3432, "url": "https://patchwork.libcamera.org/api/1.1/series/3432/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3432", "date": "2022-08-23T17:43:08", "name": "libcamera: Add support for color spaces to rkisp1 pipeline handler", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3432/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17188/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17188/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5FC27C327D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 23 Aug 2022 17:43:26 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BF31561FC8;\n\tTue, 23 Aug 2022 19:43:25 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 12D4B61FA1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 23 Aug 2022 19:43:23 +0200 (CEST)", "from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 931EB2B3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 23 Aug 2022 19:43:22 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1661276605;\n\tbh=Oh0AzzCP/2ZLxH8JAjx6bwvDB0Ud+PZUBvRC08ZUfg8=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=VXY6j/JaSnp9XqU7w+gLcdjaj33VYRi8mJt4Ph9U26fqFZ185voFciTOpqKhldZ51\n\tM+I6bySUaZl5dvbLp0E7M9SU7N9KtVvf2qN1DA149iKltIyKFPKjlgCyl6cRgA0PDR\n\tYGu3eTItWoieM8KAtk7tIOtaectif0le2tOaQug7mZ2TDsIWXLpFY2YLD555pW6qsH\n\t8DTdIQ3wiaLHyHI71tDDd0U/h7MkOIPxHXYbWdIPapV+sSn9BUR2MVJoBhl1g47Jm0\n\tkV0s6qJt/nU1I1HZrwSUcC8VNL2ctd2aLCrthYSg3qLxzDqc7LsfBeO7O6fsaa+iMP\n\tCgcHeEYBjvwfQ==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1661276602;\n\tbh=Oh0AzzCP/2ZLxH8JAjx6bwvDB0Ud+PZUBvRC08ZUfg8=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=gqyx01s8VqDUpiFGtFmXdfWDpEFyaoADs22whBILV3euswbFVTrBf+x6YzkkSyk3/\n\t0gfRm4AxQ0wFKiH9zY45MHxIo4qDNlNCdYTKspN9E0HB+KbdJfY0NQ6iqMlP0vcv7q\n\tO1P7ti7dZ0i3DAZluL1LCfbyPMBTyR6j3tn6YvHw=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"gqyx01s8\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 23 Aug 2022 20:43:10 +0300", "Message-Id": "<20220823174314.14881-3-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20220823174314.14881-1-laurent.pinchart@ideasonboard.com>", "References": "<20220823174314.14881-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 2/6] libcamera: color_space: Reorder\n\tmembers in the same order as the header", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Sort the members of the ColorSpace class in color_space.cpp to match the\ncolor_space.h order. No functional change intended.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/color_space.cpp | 168 +++++++++++++++++-----------------\n 1 file changed, 84 insertions(+), 84 deletions(-)", "diff": "diff --git a/src/libcamera/color_space.cpp b/src/libcamera/color_space.cpp\nindex f0d6109ac4fb..1b2dd2404452 100644\n--- a/src/libcamera/color_space.cpp\n+++ b/src/libcamera/color_space.cpp\n@@ -124,6 +124,90 @@ namespace libcamera {\n * \\param[in] r The range of the pixel values in this color space\n */\n \n+/**\n+ * \\brief A constant representing a raw color space (from a sensor)\n+ */\n+const ColorSpace ColorSpace::Raw = {\n+\tPrimaries::Raw,\n+\tTransferFunction::Linear,\n+\tYcbcrEncoding::None,\n+\tRange::Full\n+};\n+\n+/**\n+ * \\brief A constant representing the sRGB color space\n+ *\n+ * This is identical to the sYCC color space except that the Y'CbCr\n+ * range is limited rather than full.\n+ */\n+const ColorSpace ColorSpace::Srgb = {\n+\tPrimaries::Rec709,\n+\tTransferFunction::Srgb,\n+\tYcbcrEncoding::Rec601,\n+\tRange::Limited\n+};\n+\n+/**\n+ * \\brief A constant representing the sYCC color space, typically used for\n+ * encoding JPEG images\n+ */\n+const ColorSpace ColorSpace::Sycc = {\n+\tPrimaries::Rec709,\n+\tTransferFunction::Srgb,\n+\tYcbcrEncoding::Rec601,\n+\tRange::Full\n+};\n+\n+/**\n+ * \\brief A constant representing the SMPTE170M color space\n+ */\n+const ColorSpace ColorSpace::Smpte170m = {\n+\tPrimaries::Smpte170m,\n+\tTransferFunction::Rec709,\n+\tYcbcrEncoding::Rec601,\n+\tRange::Limited\n+};\n+\n+/**\n+ * \\brief A constant representing the Rec.709 color space\n+ */\n+const ColorSpace ColorSpace::Rec709 = {\n+\tPrimaries::Rec709,\n+\tTransferFunction::Rec709,\n+\tYcbcrEncoding::Rec709,\n+\tRange::Limited\n+};\n+\n+/**\n+ * \\brief A constant representing the Rec.2020 color space\n+ */\n+const ColorSpace ColorSpace::Rec2020 = {\n+\tPrimaries::Rec2020,\n+\tTransferFunction::Rec709,\n+\tYcbcrEncoding::Rec2020,\n+\tRange::Limited\n+};\n+\n+/**\n+ * \\var ColorSpace::primaries\n+ * \\brief The color primaries of this color space\n+ */\n+\n+/**\n+ * \\var ColorSpace::transferFunction\n+ * \\brief The transfer function used by this color space\n+ */\n+\n+/**\n+ * \\var ColorSpace::ycbcrEncoding\n+ * \\brief The Y'CbCr encoding used by this color space\n+ */\n+\n+/**\n+ * \\var ColorSpace::range\n+ * \\brief The pixel range used with by color space\n+ */\n+\n /**\n * \\brief Assemble and return a readable string representation of the\n * ColorSpace\n@@ -219,90 +303,6 @@ std::string ColorSpace::toString(const std::optional<ColorSpace> &colorSpace)\n \treturn colorSpace->toString();\n }\n \n-/**\n- * \\var ColorSpace::primaries\n- * \\brief The color primaries of this color space\n- */\n-\n-/**\n- * \\var ColorSpace::transferFunction\n- * \\brief The transfer function used by this color space\n- */\n-\n-/**\n- * \\var ColorSpace::ycbcrEncoding\n- * \\brief The Y'CbCr encoding used by this color space\n- */\n-\n-/**\n- * \\var ColorSpace::range\n- * \\brief The pixel range used with by color space\n- */\n-\n-/**\n- * \\brief A constant representing a raw color space (from a sensor)\n- */\n-const ColorSpace ColorSpace::Raw = {\n-\tPrimaries::Raw,\n-\tTransferFunction::Linear,\n-\tYcbcrEncoding::None,\n-\tRange::Full\n-};\n-\n-/**\n- * \\brief A constant representing the sRGB color space\n- *\n- * This is identical to the sYCC color space except that the Y'CbCr\n- * range is limited rather than full.\n- */\n-const ColorSpace ColorSpace::Srgb = {\n-\tPrimaries::Rec709,\n-\tTransferFunction::Srgb,\n-\tYcbcrEncoding::Rec601,\n-\tRange::Limited\n-};\n-\n-/**\n- * \\brief A constant representing the sYCC color space, typically used for\n- * encoding JPEG images\n- */\n-const ColorSpace ColorSpace::Sycc = {\n-\tPrimaries::Rec709,\n-\tTransferFunction::Srgb,\n-\tYcbcrEncoding::Rec601,\n-\tRange::Full\n-};\n-\n-/**\n- * \\brief A constant representing the SMPTE170M color space\n- */\n-const ColorSpace ColorSpace::Smpte170m = {\n-\tPrimaries::Smpte170m,\n-\tTransferFunction::Rec709,\n-\tYcbcrEncoding::Rec601,\n-\tRange::Limited\n-};\n-\n-/**\n- * \\brief A constant representing the Rec.709 color space\n- */\n-const ColorSpace ColorSpace::Rec709 = {\n-\tPrimaries::Rec709,\n-\tTransferFunction::Rec709,\n-\tYcbcrEncoding::Rec709,\n-\tRange::Limited\n-};\n-\n-/**\n- * \\brief A constant representing the Rec.2020 color space\n- */\n-const ColorSpace ColorSpace::Rec2020 = {\n-\tPrimaries::Rec2020,\n-\tTransferFunction::Rec709,\n-\tYcbcrEncoding::Rec2020,\n-\tRange::Limited\n-};\n-\n /**\n * \\brief Compare color spaces for equality\n * \\return True if the two color spaces are identical, false otherwise\n", "prefixes": [ "libcamera-devel", "2/6" ] }