Patch Detail
Show a patch.
GET /api/1.1/patches/17183/?format=api
{ "id": 17183, "url": "https://patchwork.libcamera.org/api/1.1/patches/17183/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17183/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220821124343.487963-1-Rauch.Christian@gmx.de>", "date": "2022-08-21T12:43:42", "name": "[libcamera-devel,1/2] libcamera: control: define an explicit default ControlInfo constructor", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "cd0dee8023044c9ee25344d75aabeaa70d3f86c3", "submitter": { "id": 111, "url": "https://patchwork.libcamera.org/api/1.1/people/111/?format=api", "name": "Christian Rauch", "email": "Rauch.Christian@gmx.de" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17183/mbox/", "series": [ { "id": 3430, "url": "https://patchwork.libcamera.org/api/1.1/series/3430/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3430", "date": "2022-08-21T12:43:42", "name": "[libcamera-devel,1/2] libcamera: control: define an explicit default ControlInfo constructor", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3430/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17183/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17183/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E4237BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 21 Aug 2022 12:43:48 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 050D961FC2;\n\tSun, 21 Aug 2022 14:43:48 +0200 (CEST)", "from mout.gmx.net (mout.gmx.net [212.227.17.21])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4773C61FA3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 21 Aug 2022 14:43:46 +0200 (CEST)", "from voyager ([88.152.184.103]) by mail.gmx.net (mrgmx104\n\t[212.227.17.168]) with ESMTPSA (Nemesis) id 1MdefJ-1ozMAa2oJl-00Zc5v;\n\tSun, 21 Aug 2022 14:43:45 +0200" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1661085828;\n\tbh=+tjUIMzXbvgeuJV1Tdn9soBvfDWaqJWL5l8LabZxWuY=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=a4me6kOlIw1rKzNsMyD5pbVyvPHHQAPLl89PNtXFCMRtKnNzdMFt6TTqB2cbOrFax\n\ttGakb0d1RXZrWsuSWCJ+PT+ekUrRTyvE4Azcthmb17b4kEOzntrCbY3pceZjf1xBWE\n\temp/TyT/Hcw6fKf+/hJgO4EjrDLB/M2N7EBmLSuJzmrYcB/iIrxJquTkbT+52h/lFV\n\tdDnobik9eusm1RIkR0Cr4xA/CAtm9wGyS5Bvs3K04J4ZEKmglzrusa4Qnke1bAhA7b\n\tQiESwae8G3sN6m6R9uoSOswJTZCBJAOEieFujwED3edM8vq/izcqV060EXkbzkatb0\n\tXcTBcb8soYnUg==", "v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;\n\ts=badeba3b8450; t=1661085825;\n\tbh=+tjUIMzXbvgeuJV1Tdn9soBvfDWaqJWL5l8LabZxWuY=;\n\th=X-UI-Sender-Class:From:To:Cc:Subject:Date;\n\tb=CeDLgsfRj05N9mtkna0OWSKlSgoIFPIzydCP4nOHOA/9HmQrNk3VmeDtS03WlNs0P\n\tizUjLkW0Fgg8wwD1onXib//mEL7fa98QbWyHlw4QVI4C2BYVGBQCEGcufK1BjHUoo3\n\tndZMqhMA7eqgIw6g+elTyUv1fuUU6DiszIJ45Fr8=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=gmx.net header.i=@gmx.net\n\theader.b=\"CeDLgsfR\"; dkim-atps=neutral", "X-UI-Sender-Class": "01bb95c1-4bf8-414a-932a-4f6e2808ef9c", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 21 Aug 2022 14:43:42 +0200", "Message-Id": "<20220821124343.487963-1-Rauch.Christian@gmx.de>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "quoted-printable", "X-Provags-ID": "V03:K1:7QJ1y+WyI6ZiG8d6ZeLcEln7mXc6NPQAGwLFo+Z6ZgUVJWX72gV\n\tQ9cSKN/w6B7rMbZ77r9cWJWoEwaU9vkiE/zj5BVdZyHb/chaWwcYEKIFAzShT2aPJdz/5ll\n\tM2o3HZLY8EGYIzAqj1dXn2MPvbVyxZCzITYSSkteaEUrbPXr2ZNniWlgFbTqEsfhmvtL3RU\n\t3ptzkQNzRJJMp6LoShokA==", "X-Spam-Flag": "NO", "X-UI-Out-Filterresults": "notjunk:1; V03:K0:a1Ous8fGPXo=:e9EVw2L9TU3UWkTq3o1ukH\n\tduVDtOfGIHoKiWXtGeLTImChO/+kis/9WGDiYZaHapq4zmkNdIIBkQi27yunwxpGR3ZGCwfQz\n\tMT5PBJ/1pHrG+UYMWzhsP1roszwhIyz1SeYzJ4cSFe0/uOenUvgflF/dOMWIKzZNMQ4DZcWf2\n\tT3Hm101OaYY5IwCCFKorcTSuER/lSetm2us7ZdHQCaSInTXqXO4Qj32zn41Jfo7y6EPL6CO24\n\t1wWm2iRvjXMHEK/+DOfZkzdKqEihb4/J/DRoNkDq6pcIRQ0xICRY8RPZIkaI8w1KnBjEglVXj\n\tJpqj4P7eg/OXRYM35hYYmPiD7aGIz2P6dUlcP5q3sLs3uRhAzAa/kmIdP6H3R87qxNDWLMFKI\n\t4s9QL+DyOpn/RB9NQfvFzwpO/4Fj9qWCD2nD6lt1H8lQ00DoR5JRiRdahCfp2+5X9zdxMpkcy\n\tzf5rgguI2cDhdmq9b5iQUQLpkTd3pI/0VQveY6DZynYFXuUdHRCGc+FTbkkSsiYdS35gXSWgZ\n\tDLLuE534NLWO48f21Lr7sSP2YG5fR9HwNUK1KmXEGEQeiO53sVpagJE7HYtzWMjpI3UczWR9v\n\toicZx6gyl13uANfz3uTePCP0Sjq4X/2tuW2of6myJYtn4Lmpt6nsAa9/Kzd1nnDToC7nHP8Vr\n\tlVZura++uUZANs8deR9tfB42yLg70dwenbFAanmhVUR5CIqE3lkiOy0rlhdonPT8sARh7K6+D\n\tIA4tgiiHbA36mlMU+vbUKGdDwKGcP+0Bu1dyM3YQP/KD/mmgnaUO5/0jKlSP3bLj3PlrZO2cn\n\tEtovU+RdM0Z0t3se5JAtzsOVwK6J7FHgC5dwUOXNHmE3dWJE8T0KK79N+U7YHLl3k+VjSfJKL\n\tAbDOVHvOUO26sl2sB4Tl7DdG8zT7p8sin/k30VgwWGkg+mYB63J+5BlfyTuAxF7QOJsq8QD/z\n\tQbhSYOUct1/GCHnDhKc5wGeEAyZl7xQ6AJEdXoqbUK2PjwgqhKLPlXZuPmgPWyJ0YuTG6MOwZ\n\tQ5V8EyxaS2fUz7KDSLXd1lrXDlkh0kq14ndqpyLtxPIVbifZ5K4OZfjnWZnhhUF+5HD2vykCb\n\t/+borQY5gkEBr6alRHTSVFtIpKFUZtVQ/1NHn0uo74p3+Z04MNsQwtNhg==", "Subject": "[libcamera-devel] [PATCH 1/2] libcamera: control: define an\n\texplicit default ControlInfo constructor", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Christian Rauch via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Christian Rauch <Rauch.Christian@gmx.de>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The default ControlInfo constructor allowed to partially initialised the\nmin/max/def values. Add an explicit default constructor in order to enforce\nthat either all or none of the min/max/def values are defined.\n\nSigned-off-by: Christian Rauch <Rauch.Christian@gmx.de>\n---\n include/libcamera/controls.h | 7 ++++---\n 1 file changed, 4 insertions(+), 3 deletions(-)\n\n--\n2.34.1", "diff": "diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\nindex ebc168fc..214ad7f3 100644\n--- a/include/libcamera/controls.h\n+++ b/include/libcamera/controls.h\n@@ -268,9 +268,10 @@ private:\n class ControlInfo\n {\n public:\n-\texplicit ControlInfo(const ControlValue &min = 0,\n-\t\t\t const ControlValue &max = 0,\n-\t\t\t const ControlValue &def = 0);\n+\texplicit ControlInfo() = default;\n+\texplicit ControlInfo(const ControlValue &min,\n+\t\t\t const ControlValue &max,\n+\t\t\t const ControlValue &def);\n \texplicit ControlInfo(Span<const ControlValue> values,\n \t\t\t const ControlValue &def = {});\n \texplicit ControlInfo(std::set<bool> values, bool def);\n", "prefixes": [ "libcamera-devel", "1/2" ] }