Patch Detail
Show a patch.
GET /api/1.1/patches/17179/?format=api
{ "id": 17179, "url": "https://patchwork.libcamera.org/api/1.1/patches/17179/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17179/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220819111615.39814-5-tomi.valkeinen@ideasonboard.com>", "date": "2022-08-19T11:16:13", "name": "[libcamera-devel,v4,4/6] py: Set EFD_CLOEXEC on eventfd to avoid fd leaking", "commit_ref": "dfa86000a63f8d94399a28e5432e445239526389", "pull_url": null, "state": "accepted", "archived": false, "hash": "91ab40ddae689e948ba2786b80bf5cde2d63b075", "submitter": { "id": 109, "url": "https://patchwork.libcamera.org/api/1.1/people/109/?format=api", "name": "Tomi Valkeinen", "email": "tomi.valkeinen@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17179/mbox/", "series": [ { "id": 3428, "url": "https://patchwork.libcamera.org/api/1.1/series/3428/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3428", "date": "2022-08-19T11:16:09", "name": "Python bindings: PyCameraManager and non-blocking eventfd", "version": 4, "mbox": "https://patchwork.libcamera.org/series/3428/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17179/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17179/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 88EFBBE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 19 Aug 2022 11:16:37 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3AC1861FCC;\n\tFri, 19 Aug 2022 13:16:37 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 41F0061FA4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 19 Aug 2022 13:16:32 +0200 (CEST)", "from deskari.lan (91-158-154-79.elisa-laajakaista.fi\n\t[91.158.154.79])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ADA583F1;\n\tFri, 19 Aug 2022 13:16:31 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660907797;\n\tbh=Ir9yWG2QFohno8uY8JuMwSpSfHmYnKcYj2mKDrRB6wU=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=Q9qc/ApeSv0ybcv9g9KIvoMmmTg94iC43d+w51/FtTukUzcOkwIkicoiY+XwqSD1U\n\tvoNic79mOwFAyDVPzWA/Oo7eGo8lA8NGsg9EXAueC/cD0S7Hu6HTdlyl6SpuNUMDLM\n\tmJcKe8t0/aaMUI4aEBdedkZFx3yV9avLIFYMrulgwwi3129ehGXUF8ALVZKYxQiu58\n\tQh03yUrBn1K2RIYZFT3hLEzM0RUSTCOAEnub8lVTXOCkMPHCH+erwob2P/pmjUH4pL\n\thfHLKwPW7W552gNO47fogI3LWI2ry999CpFEyWlQG6l9d1xeLEaAikm/2LoEbnJtZn\n\tASmNYV1czn6DQ==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1660907792;\n\tbh=Ir9yWG2QFohno8uY8JuMwSpSfHmYnKcYj2mKDrRB6wU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=knfLlvU62q9qWGEWNkst7XjBIGRe7bLGqCDMwQI0mJkT1cAFAue4czZglo4kikx2h\n\tQEe7Uj9LPY65bAKYvy2L/eo5wZB4quUK6X4dM4JgiRkCKoYHO9ge6e4Y1YfMovVf2Q\n\tcqtNi8ke9HQ1cpBr8pVZZDlFxa9QDp0YzvUAEQ9U=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"knfLlvU6\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org,\n\tDavid Plowman <david.plowman@raspberrypi.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tJacopo Mondi <jacopo@jmondi.org>", "Date": "Fri, 19 Aug 2022 14:16:13 +0300", "Message-Id": "<20220819111615.39814-5-tomi.valkeinen@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220819111615.39814-1-tomi.valkeinen@ideasonboard.com>", "References": "<20220819111615.39814-1-tomi.valkeinen@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 4/6] py: Set EFD_CLOEXEC on eventfd to\n\tavoid fd leaking", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Tomi Valkeinen via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Set EFD_CLOEXEC on eventfd to avoid fd leaking.\n\nSigned-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/py/libcamera/py_camera_manager.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/py/libcamera/py_camera_manager.cpp b/src/py/libcamera/py_camera_manager.cpp\nindex 18fdb623..8bfb8e57 100644\n--- a/src/py/libcamera/py_camera_manager.cpp\n+++ b/src/py/libcamera/py_camera_manager.cpp\n@@ -24,7 +24,7 @@ PyCameraManager::PyCameraManager()\n \n \tcameraManager_ = std::make_unique<CameraManager>();\n \n-\tint fd = eventfd(0, 0);\n+\tint fd = eventfd(0, EFD_CLOEXEC);\n \tif (fd == -1)\n \t\tthrow std::system_error(errno, std::generic_category(),\n \t\t\t\t\t\"Failed to create eventfd\");\n", "prefixes": [ "libcamera-devel", "v4", "4/6" ] }