Patch Detail
Show a patch.
GET /api/1.1/patches/17134/?format=api
{ "id": 17134, "url": "https://patchwork.libcamera.org/api/1.1/patches/17134/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17134/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220816015414.7462-8-laurent.pinchart@ideasonboard.com>", "date": "2022-08-16T01:54:12", "name": "[libcamera-devel,v4,7/9] ipa: rkisp1: Add enable field for AWB algorithm in IPA context", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "af00377a91b05acf183b2a7281adfcbf1ef2a614", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17134/mbox/", "series": [ { "id": 3418, "url": "https://patchwork.libcamera.org/api/1.1/series/3418/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3418", "date": "2022-08-16T01:54:05", "name": "Add DPF tuning support for RkISP1", "version": 4, "mbox": "https://patchwork.libcamera.org/series/3418/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17134/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17134/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 968ABC3272\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 16 Aug 2022 01:54:42 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 41E6861FD8;\n\tTue, 16 Aug 2022 03:54:42 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F275D603E3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 16 Aug 2022 03:54:37 +0200 (CEST)", "from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 953A9496;\n\tTue, 16 Aug 2022 03:54:37 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660614882;\n\tbh=K2EuVIZJxLrW4GpeyRSiCauCGy7HYgzJMlbdxtqHtzo=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=HNnhyuiJmTXstIdN9qeoVWSDug9zUvgZVyjsX+V+gE2OHKB+oqOkyOCB8TkAUQyzj\n\t+BP7QgPwp6SWcPLmsWyJvGA9yEBzhwwX+fV05INaLJ0zMSjiWsON5KqfodUeL+MmWT\n\t0SE0jLDHejwBsGaYrxeoSl5PpTZnCEwPEa0HJIh4eO+6KnweO5vF6wTdCx+7ga+AvA\n\tHT2YJG+NaWi7G8mn6aVKjjCZG23LH4fPXF9zDUQPI2wozdmviJutZLtQvah3bWJwDu\n\tl3YTa+/BpG9zcJ44mlSIFjC7WimR3W+ZN2oIp+0KPoYKd7DZEhL+8XPh0vH3f+Gpa9\n\tzguccq9aL001Q==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1660614877;\n\tbh=K2EuVIZJxLrW4GpeyRSiCauCGy7HYgzJMlbdxtqHtzo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=c1RukeYKvt63k6Z5osnWsy2reDV2WjPCjqUxOhnpvrKEwPF5w0Bs8CCnAQ3mG2ivX\n\tAQwB1x3je+xkq4HszS/P6OxDu0nSKGxSkYKq7kqQqTUWdBEiGf9+e1jv/dPVqHGKGm\n\t4wwhJM3Rxwsl+c9P+SaUMeHvOxv5ldY8UbdiEDzY=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"c1RukeYK\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 16 Aug 2022 04:54:12 +0300", "Message-Id": "<20220816015414.7462-8-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20220816015414.7462-1-laurent.pinchart@ideasonboard.com>", "References": "<20220816015414.7462-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 7/9] ipa: rkisp1: Add enable field for\n\tAWB algorithm in IPA context", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Florian Sylvestre <fsylvestre@baylibre.com>\n\nAdd an enable variable in the awb struct in IPASessionConfiguration which\nindicates if the awb algorithm has been configured. This will allow other\nalgorithms to retrieve this information.\n\nSigned-off-by: Florian Sylvestre <fsylvestre@baylibre.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/ipa/rkisp1/algorithms/awb.cpp | 2 ++\n src/ipa/rkisp1/ipa_context.cpp | 3 +++\n src/ipa/rkisp1/ipa_context.h | 1 +\n 3 files changed, 6 insertions(+)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\nindex 9f00364d12b1..d1328f011081 100644\n--- a/src/ipa/rkisp1/algorithms/awb.cpp\n+++ b/src/ipa/rkisp1/algorithms/awb.cpp\n@@ -48,6 +48,8 @@ int Awb::configure(IPAContext &context,\n \tcontext.configuration.awb.measureWindow.h_size = 3 * configInfo.outputSize.width / 4;\n \tcontext.configuration.awb.measureWindow.v_size = 3 * configInfo.outputSize.height / 4;\n \n+\tcontext.configuration.awb.enabled = true;\n+\n \treturn 0;\n }\n \ndiff --git a/src/ipa/rkisp1/ipa_context.cpp b/src/ipa/rkisp1/ipa_context.cpp\nindex ef8bb8e931c8..23a63f8c6e25 100644\n--- a/src/ipa/rkisp1/ipa_context.cpp\n+++ b/src/ipa/rkisp1/ipa_context.cpp\n@@ -87,6 +87,9 @@ namespace libcamera::ipa::rkisp1 {\n *\n * \\var IPASessionConfiguration::awb.measureWindow\n * \\brief AWB measure window\n+ *\n+ * \\var IPASessionConfiguration::awb.enabled\n+ * \\brief Indicates if the AWB hardware is enabled to apply colour gains\n */\n \n /**\ndiff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\nindex 2bdb6a81d7c9..7f7b3e4d88fa 100644\n--- a/src/ipa/rkisp1/ipa_context.h\n+++ b/src/ipa/rkisp1/ipa_context.h\n@@ -29,6 +29,7 @@ struct IPASessionConfiguration {\n \n \tstruct {\n \t\tstruct rkisp1_cif_isp_window measureWindow;\n+\t\tbool enabled;\n \t} awb;\n \n \tstruct {\n", "prefixes": [ "libcamera-devel", "v4", "7/9" ] }